[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-10-08 22:43:56 --- Comment #8 from Fedora Update System --- language-detector-0.5-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #7 from Fedora Update System --- language-detector-0.5-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cd0442d1d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/language-detector -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 --- Comment #5 from gil cattaneo --- (In reply to Mukundan Ragavan from comment #4) > If you time, can you help me complete my pile of review requests? > > Two more remaining - > > https://bugzilla.redhat.com/show_bug.cgi?id=1379095 > > and > > https://bugzilla.redhat.com/show_bug.cgi?id=1379096 > > > Thanks! Sure. Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/8081 https://admin.fedoraproject.org/pkgdb/package/requests/8082 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 --- Comment #4 from Mukundan Ragavan --- If you time, can you help me complete my pile of review requests? Two more remaining - https://bugzilla.redhat.com/show_bug.cgi?id=1379095 and https://bugzilla.redhat.com/show_bug.cgi?id=1379096 Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Mukundan Ragavan --- Thanks for the updated files. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 --- Comment #2 from gil cattaneo --- (In reply to Mukundan Ragavan from comment #1) > only two (relatively, minor) items - > > > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > > = MUST items = > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Apache (v2.0)", "Unknown or generated". 139 files have unknown > license. Detailed output of licensecheck in > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language- > detector/licensecheck.txt > > ---> Large number of files have no license header. Please request upstream > to add license headers. Reported @ https://github.com/optimaize/language-detector/issues/67 > [?]: Package is named according to the Package Naming Guidelines. > > ---> Shouldn't this be named java-language-detector? No, unless there is already a package with this name > Diff spec file in url and in SRPM > - > --- > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language-detector/srpm/ > language-detector.spec2016-09-30 20:21:14.151983090 -0400 > +++ > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language-detector/srpm- > unpacked/language-detector.spec 2016-09-28 14:08:22.0 -0400 > @@ -18,10 +18,8 @@ > BuildRequires: mvn(org.slf4j:slf4j-api) > > -# This is a fork from https://code.google.com/p/lang-guess/ (forked on > 2014-02-27) which itself is a fork > -# of the original project https://code.google.com/p/language-detection/ > with improvements > # Modified version of com.cybozu.labs:langdetect > # ./src/main/java/be/frma/langguess/GenProfile.java > # ./src/main/java/com/cybozu/labs/langdetect > -Provides: bundled(langdetect) = 1.1-20120112 > +Provides: bundled(langdetect) = 1.1 > > BuildArch: noarch > > > ---> please provide an updated spec and srpm Done Spec URL: https://gil.fedorapeople.org/language-detector.spec SRPM URL: https://gil.fedorapeople.org/language-detector-0.5-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 --- Comment #1 from Mukundan Ragavan --- only two (relatively, minor) items - Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 139 files have unknown license. Detailed output of licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language- detector/licensecheck.txt ---> Large number of files have no license header. Please request upstream to add license headers. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. ---> Shouldn't this be named java-language-detector? [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms = SHOULD items = Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and req
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 Mukundan Ragavan changed: What|Removed |Added CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 gil cattaneo changed: What|Removed |Added Blocks||1340387 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1340387 [Bug 1340387] CVE-2016-4434 tika: XML External Entity vulnerability [fedora-all] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380140] Review Request: language-detector - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1380140 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org