[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 Sergio Monteiro Basto changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed|2018-07-30 00:02:15 |2018-07-31 16:07:32 --- Comment #12 from Sergio Monteiro Basto --- Thank you . About BR gcc, I'll see how the other Qt / KDE packages behave -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2YMTKNVB3LO37NG7LLYE5KXJQXIVIRKL/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #11 from Igor Gnatenko --- Relying on transitive dependencies is bad. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OLY566EI4BDNZQ4NOYGG7RORNWA3P6SV/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #10 from Robert-André Mauchin --- (In reply to Igor Gnatenko from comment #7) > Missing BuildRequires for compiler. Whether it is gcc or gcc-c++. Same question as Sergio, since gcc-c++ is already implied by the BR, is it necessary to add them? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FBCUUFY3PQZFTCCQU7ILR2VHDLRVZJ3B/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #9 from Sergio Monteiro Basto --- (In reply to Igor Gnatenko from comment #7) > Missing BuildRequires for compiler. Whether it is gcc or gcc-c++. [1] gcc and gcc-c++ appears in Installing dependencies, should I explicitly add BR gcc gcc-c++ ? Thanks https://koji.fedoraproject.org/koji/taskinfo?taskID=28707198 https://kojipkgs.fedoraproject.org//work/tasks/7198/28707198/root.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LGB2IQEVWQYYJ5FTHAKDKUCOGWQGXWUK/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #8 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kwave -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4A3HWWJSGPLOP7ULMSIUBF5XKEUXQ64L/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #7 from Igor Gnatenko --- Missing BuildRequires for compiler. Whether it is gcc or gcc-c++. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IJMH2FGWYAQITH2LGM3YOBPZDJOYEXRJ/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #6 from Sergio Monteiro Basto --- OK , thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/46SRQJNGEPQZISRGU4OISYGLDATJWP7F/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #5 from Robert-André Mauchin ---
- Simply add in %install:
gzip -dS z %{buildroot}%{_datadir}/icons/hicolor/scalable/actions/*.svgz
gzip -dS z %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/kwave.svgz
→ -d = -d --decompress
→ -S z = When decompressing, add .z to the beginning of the list of suffixes
to try, when deriving an output file name from an input file name.
Package is approved, just add the ungzipping before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SFAOTL6UM5QHHLJZCREXXG5AGBOJFFPT/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 --- Comment #4 from Sergio Monteiro Basto --- Spec URL: https://www.serjux.com/rpms/kwave.spec SRPM URL: https://www.serjux.com/rpms/kwave-18.04.3-1.fc29.src.rpm Scriplets fixed, I don't know how to fix gzipped icons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5CHRNS2G32FF7WU23RQANXFVNQCY6GAQ/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #3 from Robert-André Mauchin ---
- None of these scriptlets are used anymore:
%post
/sbin/ldconfig
/usr/bin/update-desktop-database &> /dev/null || :
/bin/touch --no-create %{_kf5_datadir}/icons/hicolor &>/dev/null || :
%postun
/sbin/ldconfig
/usr/bin/update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_kf5_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_kf5_datadir}/icons/hicolor &>/dev/null ||
:
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_kf5_datadir}/icons/hicolor &>/dev/null || :
You can safely remove them. If you plan to support F27, add:
%ldconfig_scriptlets
- Don't set the checks to always true with "||:" :
%check
appstream-util validate-relax --nonet
%{buildroot}%{_kf5_metainfodir}/org.kde.%{name}.appdata.xml
desktop-file-validate
%{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop
- The icons should not be gzipped:
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_end.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_fwd.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_loop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause_2.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_record.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_rew.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_start.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_stop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmag.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmagfit.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_in.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_original.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_out.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/kwave.svgz
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated", "*No copyright*
GFDL CC0 (v1.0) GPL (v2)", "*No copyright* BSD (3 clause)", "BSD (2
clause) GPL (v2 or later)", "BSD (3 clause)", "CC by-sa (v4.0)", "GPL
(v2)". 529 files have unknown license. Detailed output of licensecheck
in /home/bob/packaging/review/kwave/review-kwave/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 Sergio Monteiro Basto changed: What|Removed |Added Blocks||656997 (kde-reviews) CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Sergio Monteiro Basto --- *** Bug 1186900 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WLZO4PPI3JXIPPBDHON4T2SGZXWGEYOC/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 Sergio Monteiro Basto changed: What|Removed |Added Status|CLOSED |NEW Resolution|DUPLICATE |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JN2G5LL45753JS7DJ2U3BI2IJQYFMVCH/
[Bug 1609629] Review Request: kwave - Sound Editor for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=1609629 Sergio Monteiro Basto changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2018-07-30 00:02:15 --- Comment #1 from Sergio Monteiro Basto --- *** This bug has been marked as a duplicate of bug 1186900 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BACQNMEINHZMLADAN2LP6CPZ6HY4QHLX/
