[Bug 1823724] Rename Review Request: yarnpkg - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1823724 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Spec is essentially identical minus the subpackage thing, so LGTM. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823724] Rename Review Request: yarnpkg - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1823724 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- This is weird: #%{nodejs_symlink_deps} The macro will still expand. Is that intended? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823724] Rename Review Request: yarnpkg - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1823724 Stephen Gallagher changed: What|Removed |Added CC||sgall...@redhat.com --- Comment #3 from Stephen Gallagher --- (In reply to Miro Hrončok from comment #2) > This is weird: > > #%{nodejs_symlink_deps} > > The macro will still expand. Is that intended? The macro happens to be a single line[1], so it will be commented-out, but you're right. This should be `#%%{nodejs_symlink_deps}` for safety. Or removed entirely, of course. I suspect it's there because the standard template for Node packages would use it, but as yarn has no dependencies on other Fedora-packaged Node modules, it's unneeded. [1] ``` %nodejs_sitelib %{_prefix}/lib/node_modules %nodejs_symlink_deps %{_rpmconfigdir}/nodejs-symlink-deps %{nodejs_sitelib} ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823724] Rename Review Request: yarnpkg - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1823724 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/yarnpkg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823724] Rename Review Request: yarnpkg - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1823724 Zuzana Svetlikova changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-04-19 22:47:41 --- Comment #5 from Zuzana Svetlikova --- I removed the %{nodejs_symlink_deps} and built the package. https://src.fedoraproject.org/rpms/yarnpkg https://koji.fedoraproject.org/koji/buildinfo?buildID=1494973 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org