[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-02-28 17:25:40 --- Comment #13 from Fedora Update System --- FEDORA-2021-66dbf6c1cb has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- FEDORA-2021-66dbf6c1cb has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-66dbf6c1cb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-66dbf6c1cb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #11 from Fedora Update System --- FEDORA-2021-66dbf6c1cb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-66dbf6c1cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #10 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/opendoas -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from dan.cer...@cgc-instruments.com ---
Looks good now except for one tiny typo: `anl` in line 10 should be a `and`.
Package approved, thanks for your work!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "ISC License", "BSD 3-clause "New" or
"Revised" License", "BSD 2-clause "Simplified" License". 10 files have
unknown license. Detailed output of licensecheck in /home/dan/fedora-
scm/1920754-opendoas/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: opendoas (description)
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #8 from Robert-André Mauchin --- (In reply to dan.cermak from comment #4) > Looks good to me overall, only a few minor things: > > - upstream publishes gpg signatures, consider using gpgverify > - the source contains not only isc licensed files, but BSD 3 clause and 2 > clause as well (both in libopenbsd/) > - consider declaring libopenbsd as a bundled dependency Thanks for the review, I have fixed all aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #7 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=62124832 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #6 from Robert-André Mauchin --- Koji scratch build: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #5 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/opendoas.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/opendoas-6.8.1-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 dan.cer...@cgc-instruments.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dan.cermak@cgc-instruments. ||com Assignee|nob...@fedoraproject.org|dan.cermak@cgc-instruments. ||com Doc Type|--- |If docs needed, set a value --- Comment #4 from dan.cer...@cgc-instruments.com --- Looks good to me overall, only a few minor things: - upstream publishes gpg signatures, consider using gpgverify - the source contains not only isc licensed files, but BSD 3 clause and 2 clause as well (both in libopenbsd/) - consider declaring libopenbsd as a bundled dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #3 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60772511 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #2 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/opendoas.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/opendoas-6.8.1-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command
https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #1 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60610439 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
