[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #20 from Fedora Update System --- FEDORA-2021-23c3fbaa92 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #19 from Fedora Update System --- FEDORA-2021-5c110d37ae has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-15 01:08:15 --- Comment #18 from Fedora Update System --- FEDORA-2021-8f3008f667 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #17 from Fedora Update System --- FEDORA-2021-23c3fbaa92 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-23c3fbaa92 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-23c3fbaa92 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #16 from Fedora Update System --- FEDORA-2021-5c110d37ae has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5c110d37ae \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5c110d37ae See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- FEDORA-2021-8f3008f667 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8f3008f667 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f3008f667 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #14 from Fedora Update System --- FEDORA-2021-8f3008f667 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f3008f667 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #13 from Fedora Update System --- FEDORA-2021-5c110d37ae has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5c110d37ae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2021-23c3fbaa92 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-23c3fbaa92 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #11 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-libcst -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #10 from Davide Cavalca --- Thanks! $ fedpkg request-repo python-libcst 1934194 https://pagure.io/releng/fedora-scm-requests/issue/32536 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194
c...@musicinmybrain.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(code@musicinmybra |
|in.net) |
--- Comment #9 from c...@musicinmybrain.net ---
Thanks, looks good. Approved. Re-review below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
The spec file looks fine, and the Requires and Provides look similar
to other Python packages. I am going to consider this a false positive.
I think it might be due to the indirect dependency, via
python3-metakernel-python, on python-jupyter-filesystem, which sounds
like an unversioned Python package even though it is not.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Expat License", "Expat
License Apache License 2.0", "Expat License", "Expat License
[generated file]". 68 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1934194-python-
libcst/20210304/1934194-python-libcst/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #8 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-4.fc35.src.rpm Changelog: - Fix intersphinx inventory path - Fix %%py_provides gating -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 c...@musicinmybrain.net changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194
--- Comment #7 from c...@musicinmybrain.net ---
> Note that even with the intersphinx fix you suggested I still get: …
Hmm, you’re right. It looks like intersphinx does not like file:// URIs, but it
does accept plain old paths
(https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping).
That should have been:
# Use local intersphinx inventory
sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \
docs/source/conf.py
I had to fix this on my own package too:
https://bugzilla.redhat.com/show_bug.cgi?id=1934257
%if 0%{?fedora} < 33 || 0%{?rhel} < 9
is not correct; either %fedora or %rhel is undefined, so either 0%{?fedora} is
0, which is less than 33, or 0%{?rhel} is 0, which is less than 9. So it always
evaluates true.
If this came from pyp2rpm, then it is a bug in pyp2rpm.
If you are not building for EPEL, you can just check if 0%{?fedora} == 32.
I’m getting
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
which I though was a false positive, triggered by the documentation package
%package -n python-%{pypi_name}-doc
It would be much more conventional to write that as
%packagedoc
which, with python-%{pypi_name} as the base name, would still give you the same
subpackage name.
I tested it with that change and still had the complaint, though.
I’m getting
Requires
python3-libcst (rpmlib, GLIBC filtered):
python(abi)
python3.9dist(pyyaml)
python3.9dist(typing-extensions)
python3.9dist(typing-inspect)
Provides
python3-libcst:
python-libcst
python3-libcst
python3.9-libcst
python3.9dist(libcst)
python3dist(libcst)
so something is going on that has nothing to do with the documentation.
I’ll post a full review after I figure out what the problem is.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #6 from Davide Cavalca --- The SRPM should be fixed, sorry about that. Note that even with the intersphinx fix you suggested I still get: loading intersphinx inventory from file://usr/share/doc/python3-docs/html/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'file://usr/share/doc/python3-docs/html/objects.inv' not fetchable due to : No connection adapters were found for 'file://usr/share/doc/python3-docs/html/objects.inv' I also tried adding changing this to file:// but that doesn't seem to make a difference. However, this doesn't break the build and I do get what looks like a valid -doc package in the end. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Davide Cavalca changed: What|Removed |Added Flags|needinfo?(dcava...@fb.com) | --- Comment #5 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-3.fc35.src.rpm Changelog: - Fix docs build and enable it by default -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194
c...@musicinmybrain.net changed:
What|Removed |Added
Flags||needinfo?(dcava...@fb.com)
--- Comment #4 from c...@musicinmybrain.net ---
Thanks. I’m getting a 404 error on the SRPM URL, though.
You can fix intersphinx trying to go to the Internet by the following, in
%prep:
# Use local intersphinx inventory
sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \
docs/source/conf.py
while adding
BuildRequires: python3-docs
and, to the -doc subpackage:
Requires: python3-docs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Davide Cavalca changed: What|Removed |Added Flags|needinfo?(dcava...@fb.com) | --- Comment #3 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-2.fc35.src.rpm Changelog: - Fix license - Switch to GitHub tarball - Add docs build (disabled by default) - Switch to pytest and document ignored tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194
c...@musicinmybrain.net changed:
What|Removed |Added
Flags||needinfo?(dcava...@fb.com)
--- Comment #2 from c...@musicinmybrain.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- License is not just MIT. See LICENSE file. The overall license should be
MIT and (MIT and Python) and ASL 2.0.
You must then add a comment above the License field explaining the multiple
licensing breakdown. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios.
Since the upstream LICENSE file actually does this (first time I’ve ever seen
that!) you could just reference it, or copy the relevant section.
- It would be nice (but not mandatory) to build the docs in a -doc subpackage.
The PyPI tarball is missing some of the documentation build files, but I
think you could do it if you switched to the GitHub tarball.
- For the tests you remove due to missing dependencies, I think you should note
which tests are removed for which dependencies, so there is a chance of
adding them back if the dependencies become available in the future. In some
cases, like test_codemod_cli.py, it is not obvious that there really is a
dependency problem.
- In general, when you remove or disable a test, it would be nice to have a
rationale. Something like “See upstream bug
https://example.com/issues/100” or “This test requires Internet access”
or at least “I tried foo and bar but I can’t report this upstream unless I
figure out baz”. This makes it much more likely that tests will be added back
in when they are no longer broken.
For example, the failure in test_codegen_clean.py is
https://github.com/Instagram/LibCST/issues/304.
Some of the others are discussed in
https://github.com/Instagram/LibCST/issues/331.
Another is https://github.com/Instagram/LibCST/issues/305.
- Testing by “setup.py test” is deprecated, and a message is printed to that
effect. Consider
%{__python3} -m unittest -v
instead. Or add a BR on pytest, and use the %pytest macro.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Expat License", "Expat
License Apache License 2.0", "Expat License", "Expat License
[generated file]". 31 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1934194-python-libcst/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
(except as noted)
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 c...@musicinmybrain.net changed: What|Removed |Added CC||c...@musicinmybrain.net Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=62947378 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
