[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2011-12-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Jussi Lehtola  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE
Last Closed|2010-07-20 06:23:05 |2011-12-16 05:01:13

--- Comment #52 from Jussi Lehtola  2011-12-16 05:01:13 
EST ---
This bug looks closed to me. Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-12-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #50 from Aleksey Popkov  2010-12-01 09:37:19 
EST ---
New Package SCM Request
===
Package Name: lightsquid
Short Description: lightsquid is a small and fast Squid log analyzer.
Owners: aleksey2005
Branches: f13 f14 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-12-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #51 from Aleksey Popkov  2010-12-01 09:38:06 
EST ---
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-10.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #49 from Jason Tibbitts  2010-11-22 08:43:30 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Ruediger Landmann  changed:

   What|Removed |Added

 AssignedTo|alek...@oscada.org.ua   |r.landm...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #48 from Aleksey Popkov  2010-11-19 16:30:28 
EST ---
Ok. Sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #47 from Jason Tibbitts  2010-11-19 07:22:20 EST 
---
Please do not reassign tickets; this package should be assigned to the
reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #46 from Aleksey Popkov  2010-11-19 04:38:47 
EST ---
New Package SCM Request
===
Package Name: lightsquid
Short Description: lightsquid is a small and fast Squid log analyzer.
Owners: aleksey2005
Branches: f13 f14 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

   Verified||Customer
   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #45 from Aleksey Popkov  2010-11-19 03:50:23 
EST ---
Thanks Ruediger Landmann.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

 AssignedTo|r.landm...@redhat.com   |alek...@oscada.org.ua
   Flag|needinfo?(alek...@oscada.or |
   |g.ua)   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Ruediger Landmann  changed:

   What|Removed |Added

   Flag||fedora-review+,
   ||needinfo?(alek...@oscada.or
   ||g.ua)

--- Comment #44 from Ruediger Landmann  2010-11-18 
22:43:14 EST ---
Thanks Aleksey, looking good now.

ACCEPT.

Please make your SCM request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #43 from Aleksey Popkov  2010-11-18 02:13:14 
EST ---
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-9.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #42 from Aleksey Popkov  2010-11-18 01:55:04 
EST ---
Hi Ruediger Landmann. Thanks.

Fixed:
1) md5sum
310a7e16017290232183753d73f3559d  lightsquid-1.8.tgz

2)
%description
%{name} is a small and fast Squid log analyzer.

3)
%description apache
%{name} configuration files and scripts for Apache.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

   Flag|needinfo?(alek...@oscada.or |
   |g.ua)   |

--- Comment #41 from Aleksey Popkov  2010-11-18 01:40:44 
EST ---
I try fixed, but:

Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz


[alek...@popkov SRPMS]$ rpmlint lightsquid-1.8-8.fc13.src.rpm 
lightsquid.src: W: no-%build-section
lightsquid.src: W: invalid-url Source0:
http://downloads.sourceforge.net/lightsquid/lightsquid-1.8.tar.gz HTTP Error
404: Not Found
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[alek...@popkov SRPMS]$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Ruediger Landmann  changed:

   What|Removed |Added

   Flag||needinfo?(alek...@oscada.or
   ||g.ua)

--- Comment #40 from Ruediger Landmann  2010-11-18 
00:00:27 EST ---
Hi Aleksey --

Much better! Thank you! 

The two other issues in there are:

[!] License field in the package spec file matches the actual license.
 License type in spec file: GPLv2

Files in package state "GNU General Public License as published by the Free
Software Foundation; either version 2 of the License, or (at your option) any
later version". Therefore:

License: GPLv2+

[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.

* md5sums do not match:
$ md5sum SOURCES/lightsquid-1.8.tgz 
9b7de3d45da769ae058ac06318c56c54  SOURCES/lightsquid-1.8.tgz
$ md5sum ~/Download/lightsquid-1.8.tgz 
310a7e16017290232183753d73f3559d  /home/rlandmann/Download/lightsquid-1.8.tgz

* Please express Source0 as:

Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

(preferred format according to
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net )

---

I also made a mistake about file ownership in the review; please disregard.
There is of course no problem here. :)

One last thing: improvements to my suggested wording for the descriptions:

%description
%{name} is a small and fast Squid log analyzer.

%description apache
%{name} configuration files and scripts for Apache.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

   Flag|needinfo?(alek...@oscada.or |
   |g.ua)   |

--- Comment #39 from Aleksey Popkov  2010-11-17 05:13:18 
EST ---
Ok. Thanks.
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-8.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Ruediger Landmann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||r.landm...@redhat.com
 AssignedTo|nob...@fedoraproject.org|r.landm...@redhat.com
   Flag||needinfo?(alek...@oscada.or
   ||g.ua)

--- Comment #38 from Ruediger Landmann  2010-11-16 
23:39:01 EST ---
Hi Aleksey: just a few more things to look at here:

 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [!] Rpmlint output is clean:

===

$ rpmlint SPECS/lightsquid.spec 
SPECS/lightsquid.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

* OK

$ rpmlint SRPMS/lightsquid-1.8-7.fc14.src.rpm 
lightsquid.src: W: spelling-error Summary(en_US) analizer -> analyzer,
canalize, nationalizer

* Please correct to "analyzer"; "Small" would also be better than "Little"
here:

%description
%{name} Small and fast Squid log analyzer.

* Also, I suggest:

Summary: Light, small, and fast log analyzer for Squid proxy

* Also, for the subpackage, I suggest:

%package apache
Summary: Web controls for %{name}
Group: Applications/Internet
Requires: %{name} = %{version}-%{release}
Requires: httpd
%description apache
Configuration files and scripts for Apache.



lightsquid.src: W: spelling-error %description -l en_US analizer -> analyzer,
canalize, nationalizer
lightsquid.src: W: strange-permission lightsquid.spec 0600L

* Should be 644

lightsquid.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 4 warnings.



$ rpmlint RPMS/noarch/lightsquid-1.8-7.fc14.noarch.rpm 
lightsquid.noarch: W: spelling-error Summary(en_US) analizer -> analyzer,
canalize, nationalizer
lightsquid.noarch: W: spelling-error %description -l en_US analizer ->
analyzer, canalize, nationalizer
lightsquid.noarch: E: executable-marked-as-config-file
/etc/cron.daily/lightsquid

* Remove:

%config(noreplace) %{_sysconfdir}/cron.daily/lightsquid

this is not a config file (yes, rpmlint will then complain
"non-conffile-in-etc", but this is expected)

lightsquid.noarch: E: script-without-shebang /etc/cron.daily/lightsquid

* Please fix

lightsquid.noarch: W: no-manual-page-for-binary lightparser.pl

* Unfortunate, but not a blocker

1 packages and 0 specfiles checked; 2 errors, 3 warnings.

$ rpmlint RPMS/noarch/lightsquid-apache-1.8-7.fc14.noarch.rpm 
lightsquid-apache.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

===

 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
 License type in spec file: GPLv2

* Files in package state "GNU General Public License as published by the Free
Software Foundation; either version 2 of the License, or (at your option) any
later version", therefore GPLv2+



 [/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
* GPL is in gnugpl.txt
 [/] Spec file is legible and written in American English.
 [!] Sources used to build the package matches the upstream source, as provided
in the spec URL.

* md5sums do not match:
$ md5sum SOURCES/lightsquid-1.8.tgz 
9b7de3d45da769ae058ac06318c56c54  SOURCES/lightsquid-1.8.tgz
$ md5sum ~/Download/lightsquid-1.8.tgz 
310a7e16017290232183753d73f3559d  /home/rlandmann/Download/lightsquid-1.8.tgz

* Please express Source0 as:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net



 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2605683
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] P

[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #37 from Aleksey Popkov  2010-07-22 03:32:18 
EDT ---
Moved all cgi scripts to the self lightsquid-apache package.

Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-7.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #36 from Aleksey Popkov  2010-07-20 12:20:11 
EDT ---
In the near future i want to add packages with configures for another
web-servers distributed with fedora (lighttpd, nginx), that's why i create
separate package with Apache configure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #35 from Aleksey Popkov  2010-07-20 12:11:19 
EDT ---
In the mear future i'am want to add package for lighttpd (Lightning fast
webserver with light system requirements) and nginx (Robust, small and high
performance http and reverse proxy server) web servers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #34 from Aleksey Popkov  2010-07-20 12:01:46 
EDT ---
It's the moment it's so.

Alyosha, you meant "bug", not "team" in comments 31 and 32 - Ok.Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

manuel wolfshant  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #33 from manuel wolfshant  2010-07-20 
10:59:20 EDT ---
And once again all the CGI scripts are in the main package and only apache's
config is in lightsquid-apache.rpm ...


Alyosha, you meant "bug", not "team" in comments 31 and 32.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 Resolution|NOTABUG |

--- Comment #32 from Aleksey Popkov  2010-07-20 10:29:54 
EDT ---
Reopen team at the request Andrey Lavrinenko.

Reload files.
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-6.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Aleksey Popkov  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #31 from Aleksey Popkov  2010-07-20 06:16:14 
EDT ---
Ok. Don't build of lightsquid for CentOs and Fedora.
Everyone can download lightsquid and build.

Close the team.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

manuel wolfshant  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||wo...@nobugconsulting.ro
 AssignedTo|wo...@nobugconsulting.ro|nob...@fedoraproject.org
   Flag|fedora-review?  |

--- Comment #30 from manuel wolfshant  2010-07-20 
06:09:49 EDT ---
So, now
- you try to run the cron script as the NONexisting user "lightsquid" ( there
will exist a group named lightsquid, but no user);
- you do not use at anything the group that you create in %pre;
- instead of simply deleting the line 
 %dir %{lightdir}
from the "%files apache" section, you have once again _moved_ ALL the cgi
scripts from lightscript-apache to the main package (which , by the way, does
not need "exclude" lines for the files which are included in lightsquid-apache)
- mind that I did not check what gets installed as default config file, now
that instead of removing the "%{__rm} -rf %{SOURCE1}.redhat" from %post you
decided to nuke all occurrences of %{SOURCE1}.redhat from the spec.

To be honest, I have doubts that you will be able to properly maintain the
package once imported, therefore I remove myself as package reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #29 from Aleksey Popkov  2010-07-20 05:38:54 
EDT ---
Thanks.
New files uploaded.

Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-5.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #28 from manuel wolfshant  2010-07-20 
04:51:21 EDT ---
Aleksey, this is the third and last time that I ask you to increase the release
tag EACH time you modify the spec.


Now, a couple of corrections which are needed:
- cron scripts placed in /etc/cron.d do not follow the format specified in man
5 crontab; they have an additional field which specifies the user which the
script runs as. Since you have decided to not use the lightsquid user, you MUST
use another user instead.
- the folder /usr/share/lightsquid (attention, I mean just the folder, not its
content) is already owned by the main lightsquid package; please do not include
it in lightsquid-apache, too.
- do not delete the existing files from /report. If the admin wants to delete
them, he can do that. But with your existing %post, you nuke all the history at
each install, including at updates
- what do you use the group created in %pre ? I see no file being installed as
group lightsquid.
- "%{__rm} -rf %{SOURCE1}.redhat" is useless. First of all because it's in the
buildroot which gets deleted anyway and second (this does not apply if you will
branch the package for EPEL) because cleaning the buildroot is no longer needed
by the new Fedora build process.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #27 from Aleksey Popkov  2010-07-19 15:12:12 
EDT ---
New files.
Changed /var/www/html to /usr/share and fixed little bugs.

Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #26 from Aleksey Popkov  2010-07-19 14:42:17 
EDT ---
Stop. Found error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #25 from Aleksey Popkov  2010-07-19 14:40:10 
EDT ---
Changed /var/www/html to /usr/share.

Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #24 from Aleksey Popkov  2010-07-19 14:25:51 
EDT ---
/var/www/html/lightsquid/report/ - It's directory used for subdirectories
reports.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #23 from Mamoru Tasaka  2010-07-19 
13:58:45 EDT ---
Well, again I don't know this package well, grep'ing /var/www seems
to show
- at least it seems *.cgi files can be moved to anywhere
  after modifying /etc/httpd/conf.d/lightsquid.conf
- I don't know how /var/www/html/lightsquid/report/ directory is
  to be used. If this directory is used for preserving some log files
  which need not be seen by somebody else, moving this directory
  to somewhere like /var/log/lightsquid/report after modifying
  /etc/lightsquid/lightsquid.cfg is preferable

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #22 from Aleksey Popkov  2010-07-19 13:10:30 
EDT ---
Ок. Advise please how to make?
I don't known how to do it another way.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #21 from Mamoru Tasaka  2010-07-19 
12:28:54 EDT ---
Well, "because other packages in Fedora do break rules" is
not a valid reason for this package
(I guess changing directory structure on packages which exist on
 Fedora for some long times needs some deeper investigation so that
 not to break things significantly. However for new packages it
 is different).

Note that again I don't know about this package and there may be some
reason that this package cannot avoid using /var/www. However again
"because there is httpd that is against this rule" is not a valid reason.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #20 from Aleksey Popkov  2010-07-19 11:42:38 
EDT ---
%define contentdir /var/www
%define suexec_caller apache 
%define mmn 20051115 
%define vstring Fedora
%define mpms worker event  
Summary: Apache HTTP Server
 Name: httpd
Version:2.2.15 
Release:1%?dist}   
URL:http://httpd.apache.org/   
  Source0: http://www.apache.org/dist/httpd/httpd-%{version}.tar.gz 
Source1:index.html  
Source3: httpd.logrotate
.


It's httpd.spec. Directive contentdir /var/www

:-)))

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Mamoru Tasaka  changed:

   What|Removed |Added

 CC||mtas...@ioa.s.u-tokyo.ac.jp

--- Comment #19 from Mamoru Tasaka  2010-07-19 
09:42:38 EDT ---
I don't know about this package well, however how is the following
guideline related to this package?

https://fedoraproject.org/wiki/Packaging/Guidelines#Web_Applications

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #18 from Aleksey Popkov  2010-07-19 08:42:18 
EDT ---
Ok. Changed.
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #17 from manuel wolfshant  2010-07-19 
07:54:14 EDT ---
Add all the cgi scripts to it and you will have a nice package with 13 files
(one config + 12 scripts)

%{apache_home} is already owned by httpd

Please increment the release tag and post again the links to the spec and
src.rpm file ( I do not see the updated versions at
http://aleksey2005.fedorapeople.org/ )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #16 from Aleksey Popkov  2010-07-19 07:44:04 
EDT ---
lightsquid-apache - One file [lightsquid.conf] in a package. Not rationally.

Added:

%files
%defattr(-,root,root)
%dir %{apache_home}
%dir %{lightdir}
%dir %{lightdir}/report

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #15 from manuel wolfshant  2010-07-19 
07:02:03 EDT ---
Problems with version 4 of your spec file:
- the %defattr line in %files should precede the file list. And is should not
be commented, of course.
- /etc/lightsquid/ is not owned
- /var/www/html/lightsquid/ is not owned
- /var/www/html/lightsquid/report/ is not owned

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #14 from manuel wolfshant  2010-07-19 
06:30:46 EDT ---
Could you please explain why did you give up your initial idea of creating the
separate lightsquid-apache package ?
As I have already explained in #12, forcing the installation of httpd is not
incorrect but awkward.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #13 from Aleksey Popkov  2010-07-19 05:49:17 
EDT ---
Added Require: httpd.
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec

Now SRPM package not change. )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #12 from manuel wolfshant  2010-07-19 
04:41:45 EDT ---
Only that now you install the CGI scripts below /var/www/html/lightsquid, but
the /var/www/html path is not owned by anyone.

To cut it short
- you either need to Require: httpd (in order to have an onwer for
/var/www/html)
or
- create the -apache subpackage as you have done in the initial spec, BUT do it
correctly ( move CGI scripts and apache's config to it + Require: httpd).

In my opinion requiring httpd by the log parser is not really a good idea,
squid and httpd can very well run on different machines. Admins may choose to
install the main package ( i.e. log parser) on the box running squid and
transfer the resulted html pages to another box where a webserver ( not
necessarily httpd -- I for one use lighttpd) runs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #11 from Aleksey Popkov  2010-07-16 06:29:25 
EDT ---
%package apache - Oh. It's was error. :-)))

crond - Scrips running from root user.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #10 from manuel wolfshant  2010-07-16 
06:07:19 EDT ---
(In reply to comment #9)

> 
> lightsquid-apache - One file in a package. Not rationally.

why don't you add all the cgi scripts to this package ? not to mention that you
removed the "%files -f apache" section, but you have left the "%package apache"
section in place


> As better to makes for cron daemon ?
I see no special reason to run the log analyzer as a dedicated user, but the
variant that you have used in  lightsquid-1.8-2.fc11.src.rpm  seemed fine to
me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #9 from Aleksey Popkov  2010-07-16 05:47:30 
EDT ---
("Litle" should be "Little") - Thaks. :-)))

dos2unix - Removed. The doc files was edition of author lightsquid.

lightsquid-apache - One file in a package. Not rationally.

As better to makes for cron daemon ?


RPM packages reupload.
Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #8 from manuel wolfshant  2010-07-16 
04:40:14 EDT ---
Aleksey, please increase the release tag each time you modify the spec file.
Mind that in the new spec you have introduced a typo, under %description
("Litle" should be "Little").

Why did you decide to go back to dos2unix instead of using sed for the files
below /doc ? It is not incorrect, but not needed, the previous version, using
sed was OK.

Why did you give up in creating the lightsquid-apache subpackage ?  Instead of
moving the scripts to the subpackage, you have moved the apache config file to
the main package. You can see at
http://koji.fedoraproject.org/koji/getfile?taskID=2323573&name=lightsquid-1.8-2.fc14.noarch.rpm
what I am talking about.

Since you have decided to create a system _group_ named lightsquid, the cron
entry which is supposed to run as _user_ lightsquid is now incorrect. OTOH
could you please explained the rationale for this new group ? I do not see it
being used anywhere in the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #7 from Aleksey Popkov  2010-07-16 03:16:04 
EDT ---
New rpm package.

Spec URL: http://aleksey2005.fedorapeople.org/lightsquid.spec
SRPM URL: http://aleksey2005.fedorapeople.org/lightsquid-1.8-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

manuel wolfshant  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
   Flag||fedora-review?

--- Comment #6 from manuel wolfshant  2010-07-15 
08:36:24 EDT ---
As far as I can see, you have chosen to create a separate lightsquid-apache
rpm, but it only includes the apache config file. I suggest to move all the
files stored below %{lightdir} ( the scripts + the folders containing them)
over there as well. Otherwise you'll install them in an unowned directory
structure:
In addition to that, /var/www/html/lightsquid/ and
/var/www/html/lightsquid/report/ must also be owned by the lightsquid-apache
rpm. In the current spec these folders are not owned by anyone.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-02-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Gareth John  changed:

   What|Removed |Added

 AssignedTo|gareth.l.j...@googlemail.co |nob...@fedoraproject.org
   |m   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-02-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Gareth John  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

2010-02-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

Gareth John  changed:

   What|Removed |Added

   Flag|fedora-review?  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review