[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
https://bugzilla.redhat.com/show_bug.cgi?id=555653 --- Comment #15 from Jens Petersen peter...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Jens Petersen peter...@redhat.com --- Package Change Request == Package Name: ghc-haskeline New Branches: el5 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? Bug 555653 depends on bug 620046, which changed state. Bug 620046 Summary: Review Request: ghc-terminfo - Haskell terminfo binding https://bugzilla.redhat.com/show_bug.cgi?id=620046 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Jens Petersen peter...@redhat.com 2010-10-03 22:13:27 EDT --- Package Change Request == Package Name: ghc-haskeline New Branches: el6 Owners: petersen InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Alias||ghc-haskeline -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Depends on||620046 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-02-18 17:41:12 EST --- ghc-haskeline-0.6.2.1-2.1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #9 from Jens Petersen peter...@redhat.com 2010-02-17 01:21:42 EST --- in the end I built -2.1, shrug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-02-17 01:48:25 EST --- ghc-haskeline-0.6.2.1-2.1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ghc-haskeline-0.6.2.1-2.1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Jens Petersen peter...@redhat.com 2010-02-15 20:19:37 EST --- New Package CVS Request === Package Name: ghc-haskeline Short Description: Haskell command-line interface for user input Owners: petersen Branches: devel InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 --- Comment #8 from Jens Petersen peter...@redhat.com 2010-02-16 02:54:44 EST --- imported but builds failing with pg.DatabaseError: error 'ERROR: duplicate key value violates unique constraint rpminfo_unique_nvra -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status Whiteboard||ready -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added CC||kon...@tylerc.org AssignedTo|nob...@fedoraproject.org|kon...@tylerc.org Flag||fedora-review? --- Comment #2 from Conrad Meyer kon...@tylerc.org 2010-02-15 00:48:58 EST --- Taking this review... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=555653
Conrad Meyer kon...@tylerc.org changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Conrad Meyer kon...@tylerc.org 2010-02-15 01:56:01 EST ---
BAD = Please fix.
N/A = Doesn't apply to this package.
YES = Fine.
??? = I have some question(s).
- [ ??? ] MUST: rpmlint must be run on every package. The output should
be posted in the review.
ghc-haskeline.src: W: spelling-error Summary(en_US) Haskell - Harrell,
Rathskeller, Hastily
ghc-haskeline.src: W: spelling-error %description -l en_US readline -
breadline, deadline, headline
ghc-haskeline.src: W: spelling-error %description -l en_US Haskell - Harrell,
Rathskeller, Hastily
ghc-haskeline.src: W: strange-permission haskeline-0.6.2.1.tar.gz 0600
ghc-haskeline.src: W: no-cleaning-of-buildroot %install
ghc-haskeline.src: W: no-buildroot-tag
ghc-haskeline.spec: W: no-cleaning-of-buildroot %install
ghc-haskeline.spec: W: no-buildroot-tag
1 packages and 1 specfiles checked; 0 errors, 8 warnings.
The spelling errors can be safely ignored. I think the permission thing ought
to be fixed before import, but it's not a blocker. The buildroot cleaning
is still needed with rpmbuild in rawhide, unless I'm mistaken. The
buildroot-tag may not be needed anymore (at least in development RPM), but
I'm not sure about this for F-12 and rawhide versions of RPM. Please
verify that F-12 and rawhide don't need a buildroot tag.
- [ YES ] MUST: The package must be named according to the Package Naming
Guidelines.
- [ YES ] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption on
Package Naming Guidelines.
- [ YES ] MUST: The package must meet the Packaging Guidelines.
cabal2spec-diff looks reasonable.
- [ YES ] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines.
- [ YES ] MUST: The License field in the package spec file must match
the actual license.
- [ YES ] MUST: If (and only if) the source package includes the text
of the license(s) in its own file, then that file, containing the text
of the license(s) for the package must be included in %doc.
- [ YES ] MUST: The spec file must be written in American English.
- [ YES ] MUST: The spec file for the package MUST be legible. If the
reviewer is unable to read the spec file, it will be impossible to
perform a review. Fedora is not the place for entries into the
Obfuscated Code Contest (http://www.ioccc.org/).
- [ YES ] MUST: The sources used to build the package must match the
upstream source, as provided in the spec URL. Reviewers should use
md5sum for this task. If no upstream URL can be specified for this
package, please see the Source URL Guidelines for how to deal with this.
f03a65b41c853e572506d8875f27a5b86ab002154ab50f020700fe9dfa64a3ab8fe72b5122a567da79fd6121e65ff47ea0d0b5754656505c3c4bf1c894455a80
haskeline-0.6.2.1.tar.gz
f03a65b41c853e572506d8875f27a5b86ab002154ab50f020700fe9dfa64a3ab8fe72b5122a567da79fd6121e65ff47ea0d0b5754656505c3c4bf1c894455a80
haskeline-0.6.2.1.tar.gz.orig
- [ YES ] MUST: The package must successfully compile and build into
binary rpms on at least one supported architecture.
Tested on x86_64, rawhide.
- [ YES ] MUST: If the package does not successfully compile, build or
work on an architecture, then those architectures should be listed in
the spec in ExcludeArch. Each architecture listed in ExcludeArch needs
to have a bug filed in bugzilla, describing the reason that the package
does not compile/build/work on that architecture. The bug number should
then be placed in a comment, next to the corresponding ExcludeArch line.
New packages will not have bugzilla entries during the review process,
so they should put this description in the comment until the package is
approved, then file the bugzilla entry, and replace the long explanation
with the bug number. The bug should be marked as blocking one (or more)
of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86, FE-ExcludeArch-x64, FE-ExcludeArch-ppc,
FE-ExcludeArch-ppc64
- [ YES ] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the Packaging
Guidelines; inclusion of those as BuildRequires is optional.
Apply common sense.
- [ N/A ] MUST: The spec file MUST handle locales properly. This is done
by using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
- [ N/A ] MUST: Every binary RPM package which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
- [ N/A ] MUST: If the package is
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=555653
Jens Petersen peter...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #4 from Jens Petersen peter...@redhat.com 2010-02-15 02:23:07 EST
---
Thanks for reviewing! :)
ghc-haskeline.src: W: strange-permission haskeline-0.6.2.1.tar.gz 0600
Ugh again (silly chromium) - yup will fix
ghc-haskeline.spec: W: no-cleaning-of-buildroot %install
ghc-haskeline.spec: W: no-buildroot-tag
I believe these are now optional though rpmlint still complains.
- [ BAD ] MUST: At the beginning of %install, each package MUST run
rm -rf %{buildroot} (or $RPM_BUILD_ROOT). See Prepping BuildRoot For
%install for details.
See the note at
https://fedoraproject.org/wiki/Packaging/Guidelines#PreppingBuildRootForInstall
So should be ok. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 --- Comment #5 from Conrad Meyer kon...@tylerc.org 2010-02-15 02:33:58 EST --- Ok, everything looks good -- APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555653 Jens Petersen peter...@redhat.com changed: What|Removed |Added Blocks||522953 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
