[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
https://bugzilla.redhat.com/show_bug.cgi?id=562469 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #46 from Michal Ambroz re...@seznam.cz --- Package Change Request == Package Name: openvas-scanner New Branches: epel7 Owners: huzaifas sgros rebus xavierb fab Hello SCM team, plase can you add epel7 branch for the openvas-scanner package? Thank you Michal Ambroz -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
https://bugzilla.redhat.com/show_bug.cgi?id=562469 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||openvas-scanner-3.0.2-4.fc1 ||3 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #43 from Fedora Update System upda...@fedoraproject.org 2010-04-26 18:45:26 EDT --- openvas-scanner-3.0.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/openvas-scanner-3.0.2-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #44 from Fedora Update System upda...@fedoraproject.org 2010-04-26 22:22:01 EDT --- openvas-scanner-3.0.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #42 from Michal Ambroz re...@seznam.cz 2010-04-25 07:23:17 EDT --- Hello guys, I have patched scripts for downloading the NVT feed to use separate nvt and gsf plugin directories to separate it from plugins we deliver with the package. Update is in cvs of all branches now (F-12, F-13, devel, EL-5) I have rebuild openvas-scanner for F12 and devel. Submitted it to F12 updates via bodhi. Rebuild for F13 was not possible, bacause openvas-libraries package is still in F13 update-testing and I am not able to find a way how to build against it. Rebuild for EL-5 was not possible at this point as we do not have branch for openvas-libraties for EL-5. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #41 from Fedora Update System upda...@fedoraproject.org 2010-04-24 22:04:36 EDT --- openvas-scanner-3.0.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/openvas-scanner-3.0.2-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #40 from Kevin Fenzi ke...@tummy.com 2010-04-17 21:39:45 EDT --- CVS done (by process-cvs-requests.py). Xavier: Please remember to assign the review to yourself instead of leaving it as nob...@fedoraproject.org. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #31 from Stjepan Gros stjepan.g...@gmail.com 2010-04-16 02:25:45 EDT --- I'll revert back permissions to 644. And those provides have to be removed because they are not in the package. The question is how to do it. One option is to remove those files after the installation stage, but is there some better method? When I remove those I'll submit new revision. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562469
--- Comment #32 from Xavier Bachelot xav...@bachelot.org 2010-04-16 03:36:02
EDT ---
Something like the following should do it :
%filter_provides_in %{_libdir}/openvas/plugins
%filter_setup
See https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #33 from Stjepan Gros stjepan.g...@gmail.com 2010-04-16 03:51:40 EDT --- Ok, here is the new package: Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner-3.0.2-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #34 from Xavier Bachelot xav...@bachelot.org 2010-04-16 05:01:12 EDT --- You did not update the spec and the srpm link is 404. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #35 from Stjepan Gros stjepan.g...@gmail.com 2010-04-16 06:01:37 EDT --- Ups, sorry. Now they are updated! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #36 from Xavier Bachelot xav...@bachelot.org 2010-04-16 06:18:26 EDT --- Looks good. Please go ahead and request the creation of the cvs module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #26 from Xavier Bachelot xav...@bachelot.org 2010-04-14 02:33:42 EDT --- You're right, perms should be 755. Fix the 2 remaining issues before importing and then this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #28 from Michal Ambroz re...@seznam.cz 2010-04-14 13:11:06 EDT --- Hello, I have tried with ( the current) perrmissions 644 and it works. I was testing openvas_ Libraries are apparently explicitly loaded and not linked to executable - so they do not need executable bit. In my opinion permissions can stay as they are. Cosmetics: What I see bit unfortunate is that everything (nasl, nes, inc) is mixed in one directory. Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #29 from Michal Ambroz re...@seznam.cz 2010-04-14 13:11:46 EDT --- I forgot so say ... thanks ... everything works as expected for me. Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #22 from Stjepan Gros stjepan.g...@gmail.com 2010-04-13 02:28:46 EDT --- Here is the updated version of openvas-scanner: Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner-3.0.2-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562469
--- Comment #23 from Michal Ambroz re...@seznam.cz 2010-04-13 08:40:01 EDT ---
Hello Stjepan,
Man you are fast :) - thank you for update.
I have tried to test it and found these issues:
1) It seems there is a typo in the Source link
Link says:
http://wald.intevation.org/frs/download.php/467/%{name}-%{version}.tar.gz
And it should be:
http://wald.intevation.org/frs/download.php/724/%{name}-%{version}.tar.gz
It seems the number identifies the download from their pages and
name is there just for information (ehh?!) .
2) Library paths
Thank you for including the sed for paths in the spec.file for configuring the
paths.
Please could you include the modified conf file as well?
Otherwise the lib64 is not changed to lib on different platforms.
Thank you
Michal Ambroz
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562469
Xavier Bachelot xav...@bachelot.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Comment #24 from Xavier Bachelot xav...@bachelot.org 2010-04-13 19:07:37
EDT ---
+ : OK
- : Not OK
= : non applicable
? : not tested
+* MUST: rpmlint must be run on every package. The output should be posted
in the review.
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
+* MUST: The package must be named according to the Package Naming
Guidelines.
+* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
+* MUST: The package must meet the Packaging Guidelines.
+* MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
-* MUST: The License field in the package spec file must match the actual
license.
License is GPLv2 not GPLv2+
+* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
+* MUST: The spec file must be written in American English.
+* MUST: The spec file for the package MUST be legible.
-* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL.
Source0 URL is wrong, as noted by Michal in comment 23. Tarball matches
upstream though : 0fbadc838d4f21c43f1ce6c8180287e6
+* MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
=* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
+* MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines.
=* MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
=* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
+* MUST: Packages must NOT bundle copies of system libraries.
=* MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
+* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
+* MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
-* MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
Plugins should be 644, not 755.
+* MUST: Each package must consistently use macros.
+* MUST: The package must contain code, or permissable content.
=* MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
+* MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
=* MUST: Header files must be in a -devel package.
=* MUST: Static libraries must be in a -static package.
=* MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
=* MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
+* MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
=* MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section.
+* MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon.
+* MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
+* MUST: All filenames in rpm
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #20 from Stjepan Gros stjepan.g...@gmail.com 2010-03-31 05:56:37 EDT --- I agree with your additions/changes to scanner. But for now I'm waiting response from the others. It is, IMHO, time to push this package (and client) to rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #21 from Stjepan Gros stjepan.g...@gmail.com 2010-03-31 05:58:17 EDT --- I agree with your additions/changes to scanner. But for now I'm waiting response from the others. It is, IMHO, time to push this package (and client) to rawhide. BTW, your site is inaccessible at this moment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #19 from Michal Ambroz re...@seznam.cz 2010-03-29 09:25:05 EDT --- If you preffer for review, here are the proposed changes to the package SPEC URL: http://rebus.webz.cz/d/openvas-scanner.spec SRPM URL: http://rebus.webz.cz/d/openvas-scanner-3.0.1-6.fc12.src.rpm Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Alias||openvas-scanner -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562469
--- Comment #11 from Xavier Bachelot xav...@bachelot.org 2010-03-10 20:01:40
EST ---
the cron should be tagged as %config(noreplace). Also, it would be better to
store it in /etc/cron.d/openvas-scanner, it'll then be easier to tweak the
execution time.
The reload initscript target should be made a no op, as per the guidelines.
Sorry about my previous misleading comment. See
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Required_Actions.
As already written above, prog variable could probably be changed to
openvas-scanner (and then the initscript tweaked accordingly) for nicer startup
messages.
I still find having the sysconfdir be owned by openvas-libraries strange. I'd
rather have that owned by both -client and -server.
It's not good to strip the plugins manually, it's better to have them stripped
by duringthe rpm build in order to have the symbols in the -debuginfo package.
As the files need to be installed executable to be stripped, you can remove the
exec bit in the %files section rather than in the %install section. It makes
the %files section a bit longer, but something like that should do :
%dir %{_libdir}/openvas
%dir %{_libdir}/openvas/plugins
%attr(644,-,-) %{_libdir}/openvas/plugins/*.nes
then the following lines can be removed from the %install section:
# Fix permissions on included plugins and strip binaries
chmod 644 $RPM_BUILD_ROOT%{_libdir}/openvas/plugins/*
strip $RPM_BUILD_ROOT%{_libdir}/openvas/plugins/*
This package and the client package are getting in a good shape now. A quick
comment (or more ;-)) from Huzaifa would be nice. I'll do the formal reviews
soon.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #12 from Xavier Bachelot xav...@bachelot.org 2010-03-10 20:05:41 EST --- (In reply to comment #11) the cron should be tagged as %config(noreplace). Also, it would be better to store it in /etc/cron.d/openvas-scanner, it'll then be easier to tweak the execution time. oops, typo, I meant /etc/cron.d/openvas-sync-plugins. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #10 from Stjepan Gros stjepan.g...@gmail.com 2010-03-09 04:27:13 EST --- Ok, I added sysconfig file, daily cron script. I also added new option to init.d script, reloadplugins, that sends HUP signal to openvas scanner if it is running. Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner-3.0.1-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #8 from Stjepan Gros stjepan.g...@gmail.com 2010-03-04 04:19:47 EST --- Ok, using your tip I managed to get rid of that warning too. So, here are the new SPEC file and SRPM file: Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-scanner-3.0.1-3.fc12.src.rpm I also unified reload and restart as you suggested. For the HUP signal I don't know how exactly openvas behaves because nothing is said in the manual about signals. Source[123] I wrote, so there is no upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #9 from Xavier Bachelot xav...@bachelot.org 2010-03-04 04:56:00 EST --- It does support SIGHUP : http://openvas.org/nvt-feeds.html My understading is it will not reload its conf, but it will reload its plugins. Also, on the plugins subject, I think it would be handy to provide a cronjob periodically running openvas-nvt-sync, disabled by default, but that can be enabled with a conf in /etc/sysconfig/openvas-scanner or something like that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Summary|Review Request: |Review Request: |openvas-scanner - Open |openvas-scanner - Open |Vulnerability Assessment|Vulnerability Assessment |(OpenVAS) Scanner |(OpenVAS) Scanner -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #6 from Stjepan Gros stjepan.g...@gmail.com 2010-03-03 03:45:03 EST --- Ok, I fixed everything but changing init.d script name gives rpmlint error this time: openvas-scanner.x86_64: E: incoherent-subsys /etc/rc.d/init.d/openvas-scanner openvassd So, should I ignore the warning you reported? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #7 from Xavier Bachelot xav...@bachelot.org 2010-03-03 04:16:19 EST --- Or either you can also change the lockfile in the initscript to : lockfile=/var/log/subsys/openvas-scanner prog variable could also probably be changed to openvas-scanner for nicer startup messages. About the reload entry, I would have changed restart) to restart|reload), rather than duplicating the restart entry. Also, can openvas-scanner reload its conf on SIGHUP ? This would be even better. Btw, is there an upstream source for the Source[123] files, or did you wrote them yourself ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562469
--- Comment #5 from Xavier Bachelot xav...@bachelot.org 2010-03-02 16:36:35
EST ---
* Missing BuildRequires: on glib2-devel, libpcap-devel, gnutls-devel,
gpgme-devel.
* After fixing the BR:s, rpmlint is not silent :
openvas-scanner.i686: E: non-standard-executable-perm
/usr/lib/openvas/plugins/openvas_tcp_scanner.nes 0555
openvas-scanner.i686: E: non-standard-executable-perm
/usr/lib/openvas/plugins/find_service.nes 0555
openvas-scanner.i686: E: non-standard-executable-perm
/usr/lib/openvas/plugins/synscan.nes 0555
openvas-scanner.i686: E: non-standard-executable-perm
/usr/lib/openvas/plugins/ssl_ciphers.nes 0555
-- Fix the perms on the plugins (0644).
openvas-scanner.i686: E: non-readable /etc/openvas/openvassd.conf 0600
-- Why does the perms need to be so tight ?
openvas-scanner.i686: W: no-reload-entry /etc/rc.d/init.d/openvassd
-- either add a reload entry or map it to restart if not possible.
openvas-scanner.i686: E: incoherent-logrotate-file /etc/logrotate.d/openvassd
openvas-scanner.i686: W: incoherent-init-script-name openvassd
('openvas-scanner', 'openvas-scannerd')
-- Replace openvassd in the initscript and logrotate filenames with
openvas-scanner.
- Maybe replace OpenVAS Server by OpenVAS Scanner in the initscript comments ?
- Search for vuurmuur in the initscript and logrotate file. What is this ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Bug 562469 depends on bug 562467, which changed state. Bug 562467 Summary: Review Request: openvas-libraries - Support libraries for Open Vulnerability Assessment (OpenVAS) Server https://bugzilla.redhat.com/show_bug.cgi?id=562467 What|Old Value |New Value Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Blocks||563471(FE-SECSPIN) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Stjepan Gros stjepan.g...@gmail.com changed: What|Removed |Added Depends on||562467 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #1 from Stjepan Gros stjepan.g...@gmail.com 2010-02-06 16:14:45 EST --- *** Bug 538298 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 --- Comment #2 from Stjepan Gros stjepan.g...@gmail.com 2010-02-06 16:15:22 EST --- *** Bug 538297 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
