[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Fedora Update System changed: What|Removed |Added Fixed In Version|iapetal-1.0-3.fc12 |iapetal-1.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #13 from Fedora Update System 2010-06-15 12:07:15 EDT --- iapetal-1.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||iapetal-1.0-3.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #12 from Fedora Update System 2010-06-15 12:02:44 EDT --- iapetal-1.0-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #10 from Fedora Update System 2010-06-14 08:47:08 EDT --- iapetal-1.0-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/iapetal-1.0-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #11 from Fedora Update System 2010-06-14 08:47:14 EDT --- iapetal-1.0-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/iapetal-1.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #9 from Kevin Fenzi 2010-06-14 00:25:31 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Jon Ciesla changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Jon Ciesla 2010-06-11 09:12:27 EDT --- Awesome, thanks! New Package CVS Request === Package Name: iapetal Short Description: A 2D space rescue game Owners: limb Branches: F-13 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Randall Berry changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Randall Berry 2010-06-10 13:01:25 EDT --- Looks good to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Jon Ciesla changed: What|Removed |Added Flag|needinfo?(l...@jcomserv.net | |) | --- Comment #6 from Jon Ciesla 2010-06-10 09:03:18 EDT --- http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-3.fc13.src.rpm I sorta forgot that I upgraded to f13. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Randall Berry changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|randyn3...@gmail.com Flag||needinfo?(l...@jcomserv.net ||) --- Comment #5 from Randall Berry 2010-06-09 18:46:58 EDT --- Dead srpm link http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #4 from Jon Ciesla 2010-06-09 10:13:07 EDT --- SPEC: http://zanoni.jcomserv.net/fedora/iapetal/iapetal.spec SRPM: http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-3.fc12.src.rpm Whoops, wrong url. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #3 from Jon Ciesla 2010-06-09 10:11:53 EDT --- SPEC: http://zanoni.jcomserv.net/fedora/iapetal/iapetal.spec SRPM: http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-2.fc12.src.rpm Fixed. Also, if doing the review, in addition to the flag, assign it to yourself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 Randall Berry changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590832
Randall Berry changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||randyn3...@gmail.com
--- Comment #2 from Randall Berry 2010-06-09 01:50:50
EDT ---
Key:
[P] Pass
[F] Fail
[-] Not applicable
[?] Questions (see comments)
[P] MUST: rpmlint must be run on every package. The output should be
posted in the review.
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
iapetal.noarch: W: no-manual-page-for-binary iapetal
Each executable in standard binary directories should have a man page.
iapetal.noarch: W: no-manual-page-for-binary iapetal-launcher
Each executable in standard binary directories should have a man page.
[P] MUST: The package must be named according to the Package Naming
Guidelines.
[P] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption.
[P] MUST: The package must meet the Packaging Guidelines.
[P] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines. GPLv3
[P] MUST: The License field in the package spec file must match
the actual license. GPLv3
[P] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[P] MUST: The spec file must be written in American English.
[P] MUST: The spec file for the package MUST be legible.
[P] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
[-] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture. Python
[-] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec
in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be
placed in a comment, next to the corresponding ExcludeArch line.
[P] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the
Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
forbidden.
[-] MUST: Every binary RPM package (or sub package) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[P] MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package.
Without this, use of Prefix: /usr is considered a blocker.
[P] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory. Refer to the Guidelines for examples.
[P] MUST: A package must not contain any duplicate files in the %files
listing.
[P] MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section
must include a %defattr(...) line.
[P] MUST: Each package must have a %clean section, which contains
rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ).
[P] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
[P] MUST: The package must contain code, or permissible content.
This is described in detail in the code vs. content section
of Packaging Guidelines.
[-] MUST: Large documentation files should go in a -doc sub package.
(The definition of large is left up to the packager's best judgment,
but is not restricted to size. Large can refer to either size or quantity)
[-] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program
must run properly if it is not present.
[-] MUST: Header files must be in a -devel package.
[-] MUST: Static libraries must be in a -st
[Bug 590832] Review Request: iapetal - A 2D space rescue game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590832 --- Comment #1 from Jon Ciesla 2010-05-18 13:53:01 EDT --- SPEC: http://zanoni.jcomserv.net/fedora/iapetal/iapetal.spec SRPM: http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-2.fc12.src.rpm Updated desktop file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
