[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #10 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: compiz-plugins-main New Branches: f17 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NMBEitAcr4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SLWJ9wbwbKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-28 10:12:04 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rAIV89gulYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- compiz-plugins-main-0.8.8-5.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SI63N6kmCMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- compiz-plugins-main-0.8.8-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9kEbMN0K2xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRcTMALoo5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IwyWZAEqala=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- compiz-plugins-main-0.8.8-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/compiz-plugins-main-0.8.8-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=96AB10vbYYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MlnedYNCVAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #3 from Wolfgang Ulbrich chat-to...@raveit.de --- New starting point. f19 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4769350 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-main.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-main-0.8.8-4.fc19.src.rpm Ready for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cP12cLMJU1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851802
leigh scott leigh123li...@googlemail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #4 from leigh scott leigh123li...@googlemail.com ---
Approved
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: %config files are marked noreplace or the reason is justified.
Note: %config %{_sysconfdir}/mateconf/schemas/*.schemas
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/compiz-plugins-main
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[ ]: Package contains no bundled libraries.
[ ]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[ ]: Sources contain only permissible code or content.
[!]: %config files are marked noreplace or the reason is justified.
Note: %config %{_sysconfdir}/mateconf/schemas/*.schemas
[x]: Each %files section contains %defattr if rpm 4.4
[ ]: Macros in Summary, %description expandable at SRPM build time.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[ ]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
devel, %package mate
[ ]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/leigh/Desktop/review
/review-compiz-plugins-main/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[ ]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[ ]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/compiz-plugins-main
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[ ]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: compiz-plugins-main New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mt56yDJ1RUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=InGhNHY457a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #2 from leigh scott leigh123li...@googlemail.com --- Lot of thing wrong, try this spec and srpm Spec URL: http://leigh123linux.fedorapeople.org/pub/compiz-plugins-main/compiz-plugins-main.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/compiz-plugins-main/compiz-plugins-main-0.8.8-2.fc17.src.rpm %changelog * Sun Oct 07 2012 Leigh Scott leigh123li...@googlemail.com - 0.8.8-2 - patch for Mate - remove build require gawk - fix source url - fix plugin-matecompat.svg permissions - spec file cleanup - fix scriptlets -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
https://bugzilla.redhat.com/show_bug.cgi?id=851802 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co ||m -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851802] Review Request: compiz-plugins-main - Collection of Compiz Fusion plugins for Compiz
https://bugzilla.redhat.com/show_bug.cgi?id=851802 --- Comment #1 from Wolfgang Ulbrich chat-to...@raveit.de --- This is a re-review of a retired package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
