[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: compiz-manager New Branches: f17 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=upW1FSRrjTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MHqVZPTQoPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-29 01:59:16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T6balUyNw7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iiRLUq6XHea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|leigh123li...@googlemail.co |mario.blaetterm...@gmail.co |m |m Flags||fedora-review? --- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com --- New scratch build (the previous one was outdated): http://koji.fedoraproject.org/koji/taskinfo?taskID=4852927 $ rpmlint -i -v *compiz-manager.noarch: I: checking compiz-manager.noarch: E: explicit-lib-dependency libcompizconfig You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. compiz-manager.noarch: I: checking-url http://www.compiz.org/ (timeout 10 seconds) compiz-manager.noarch: E: incorrect-fsf-address /usr/share/doc/compiz-manager-0.6.0/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. compiz-manager.noarch: W: no-manual-page-for-binary compiz-manager Each executable in standard binary directories should have a man page. compiz-manager.src: I: checking compiz-manager.src: I: checking-url http://www.compiz.org/ (timeout 10 seconds) compiz-manager.src: I: checking-url http://releases.compiz.org/0.6.0/compiz-manager-0.6.0.tar.gz (timeout 10 seconds) compiz-manager.spec: I: checking-url http://releases.compiz.org/0.6.0/compiz-manager-0.6.0.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 2 errors, 1 warnings. No manual page - not your problem. Wrong FSF address - not your problem. But in both cases, you have to inform the upstream developers, if possible, so that they can fix it in future releases. explicit-lib-dependency libcompizconfig is no problem in our case. In a noarch package without special build requirements, we don't have specific library calls which could rpm use to generate runtime dependencies. Stay tuned for a full review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZtZElVSkuPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- - key: [+] OK [.] OK, not applicable [X] needs work - [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [.] MUST: The License field in the package spec file must match the actual license. GPLv2+ [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * acf5668ae6d12c7f33daef251f750b75634eac92ceca5ebb0745527fe8a60479 compiz-manager-0.6.0.tar.gz acf5668ae6d12c7f33daef251f750b75634eac92ceca5ebb0745527fe8a60479 compiz-manager-0.6.0.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [.] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #6 from Wolfgang Ulbrich chat-to...@raveit.de --- Thank you for the review. Notice upstream about rpmlint issues would be difficult, because http://bugs.compiz.org/502 - Bad Gateway Seems like compiz close this site. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0FGTKx31s0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: compiz-manager New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pETBjoh9Fza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #3 from Wolfgang Ulbrich chat-to...@raveit.de --- Package builds on rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=4797329 scratch build srpm link: http://kojipkgs.fedoraproject.org//work/tasks/7330/4797330/compiz-manager-0.6.0-16.fc19.src.rpm Starting point: Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-manager.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-manager-0.6.0-16.fc19.src.rpm Ready to review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lInY4fBPRKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #2 from Wolfgang Ulbrich chat-to...@raveit.de --- New starting point. Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-manager.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-manager-0.6.0-16.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kiIWQcbMG5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
https://bugzilla.redhat.com/show_bug.cgi?id=851812 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co ||m -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #1 from Wolfgang Ulbrich chat-to...@raveit.de --- This is a re-review of a retired package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review