[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866158 Bug 866158 depends on bug 840149, which changed state. Bug 840149 Summary: Tracker for MATE packages https://bugzilla.redhat.com/show_bug.cgi?id=840149 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HkrZedAXIsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2012-10-30 05:48:22 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- mate-terminal-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/FEDORA-2012-16168/mate-terminal-1.4.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #4 from leigh scott leigh123li...@googlemail.com --- (In reply to comment #2) Please remove scrollkeeper from BR and add rarian-devel and rarian-compat. Why would I want to do that when the code knows nothing about rarian so cant use it. [leigh@main-pc mate-terminal-1.4.0]$ grep -i rarian * grep: caja: Is a directory grep: help: Is a directory grep: po: Is a directory grep: src: Is a directory [leigh@main-pc mate-terminal-1.4.0]$ cd src/ [leigh@main-pc src]$ grep -i rarian * grep: skey: Is a directory [leigh@main-pc src]$ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #5 from leigh scott leigh123li...@googlemail.com --- Spec URL: http://leigh123linux.fedorapeople.org/pub/review/mate-terminal/2/mate-terminal.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/mate-terminal/2/mate-terminal-1.4.0-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Dan Mashal dan.mas...@gmail.com --- APPROVED. SHOULD: As per packaging guidelines please keep in mind the following: Scrollkeeper In all current Fedora, rarian has replaced scrollkeeper. There is no scriptlet needed for rarian. For instructions on what to do in EPEL releases, see Packaging:EPEL#Scrollkeeper You can use rarian-devel and rarian-compat to replace scrollkeeper. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from leigh scott leigh123li...@googlemail.com --- New Package SCM Request === Package Name: mate-terminal Short Description: Terminal emulator for MATE Owners: leigh123linux rdieter vicodan Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158
--- Comment #1 from Dan Mashal dan.mas...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[ ]: Package contains no bundled libraries.
[ ]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[ ]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[ ]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[ ]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[ ]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated, LGPL (v2 or later) (with
incorrect FSF address), GPL (v3 or later) (with incorrect FSF
address), LGPL (v3 or later) (with incorrect FSF address), GPL (v2 or
later) (with incorrect FSF address). 6 files have unknown license.
Detailed output of licensecheck in /home/dan/866158-mate-
terminal/licensecheck.txt
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[ ]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[ ]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[ ]: Useful -debuginfo package or justification otherwise.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[ ]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[!]: SourceX / PatchY prefixed with %{name}.
Note: Source0
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #2 from Dan Mashal dan.mas...@gmail.com --- Please remove scrollkeeper from BR and add rarian-devel and rarian-compat. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Depends On||840149 (MATE-DE-tracker) Alias||mate-terminal -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866158] Review Request: mate-terminal - Terminal emulator for MATE
https://bugzilla.redhat.com/show_bug.cgi?id=866158 --- Comment #3 from Dan Mashal dan.mas...@gmail.com --- Also please remove: BuildRequires: gettext BuildRequires: intltool BuildRequires: libtool These get pulled in by mate-common. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
