[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #41 from John Heidemann --- Package Change Request == Package Name: perl-Fsdb New Branches: el6 Owners: johnh InitialCC: perl-sig I maintain this package against EPEL7 and want to get into the older RHEL6 tree. (RHEL5, you are dead to me, but RHEL6 lives on.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877096 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J0mqnjatlU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? --- Comment #17 from Petr Šabata --- Ok, I'll take a look at this. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #18 from Petr Šabata --- Could you please provide current SPEC and SRPM links? I see perl-Fsdb.spec is there, using version 2.47-1, however there is no SRPM. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #19 from John Heidemann --- Thanks, Petr. A current SRPM is: https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb-2.47-1.fc19.src.rpm The spec is in the SRPM, or at https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb.spec (Sigh, there's an rpmlint warning about mixing spaces and tabs in the spec that I will fix in the next release.) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #20 from Petr Šabata --- There's no such package as perl-Jdb or anything providing perl(Jdb); could you explain that obsoletes/provides? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #21 from John Heidemann --- Wrt comment #20, perl-Jdb was an earlier version of Fsdb. The name changed in 2008. We packaged it for internal use. Since it was not publicly released, and is now very old, I will remove those lines in the next release. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #22 from John Heidemann --- Created attachment 813534 --> https://bugzilla.redhat.com/attachment.cgi?id=813534&action=edit updated perl-Fsdb.spec wrt comment 20/21 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096
--- Comment #23 from Petr Šabata ---
Ok, I'll repeat some of the things that have already been mentioned but are
still in the spec.
Just remove the old cruft unless you really want to support this package in
EPEL5. That means the BuildRoot tag (line 10), buildroot removal (line 58),
and the %clean section (lines 72-73).
As this is a noarch package, you don't need line 61. Remove it.
I think the lines 64 and 65 could be replaced with simple %{_fixperms}
%{buildroot}/*.
EE::MM supports DESTDIR and using that is preferred over PERL_INSTALL_ROOT.
Now about the dependencies:
You have to BuildRequire everything used during the build phase which isn't
available in the minimal buildroot (see the Packaging Guidelines for the list).
This, of course, includes all the perl modules used by the executed code.
When it comes to runtime dependencies, rpmbuild tries to parse the code present
in the final RPM and generate the dependency list from that. It's fairly smart
but has some known issues. I'd recommend not explicitly Requiring anything,
building the package, checking the detected dependencies with 'rpm -qRp
package.rpm', and just adding what's missing.
In your case, the following BRs are required (Makefile.PL, executed scripts,
testsuite, and the tested code):
perl
perl(Carp)
perl(Config)
perl(Exporter)
perl(ExtUtils::MakeMaker)
perl(File::Copy)
perl(Getopt::Long)
perl(IO::File)
perl(IO::Handle)
perl(IO::Uncompress::AnyUncompress)
perl(Pod::Usage)
perl(strict)
perl(Test::More)
perl(vars)
The IO::Compress::, Text::CSV_XS, and HTML::Parser modules don't seem to be
required at build time. You should drop those. Both Text::CSV_XS and
HTML::Parser will most likely be autodetected by rpmbuild, too. No need to
Require them explicitly.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #24 from John Heidemann --- Thank you for the suggestions in comment 23. I will update the spec again. I thought I had picked up all prior comments, but maybe not. A couple of things though: - yes I do want to support EL5; we have some old boxes here - wrt IO::Compress::, etc. not being reuqired at build time: they should be exercised in the test suites I will post an updated spec when I can check all these out. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #25 from Petr Šabata --- (In reply to John Heidemann from comment #24) > Thank you for the suggestions in comment 23. I will update the spec again. > I thought I had picked up all prior comments, but maybe not. > > A couple of things though: > > - yes I do want to support EL5; we have some old boxes here Alright, keep the buildroot and the related things in there then. > - wrt IO::Compress::, etc. not being reuqired at build time: they should be > exercised in the test suites Those are only loaded in the _enable_compression() sub which doesn't seem to be called during the test phase. But I might be wrong. > I will post an updated spec when I can check all these out. Ok :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #26 from John Heidemann --- Created attachment 834601 --> https://bugzilla.redhat.com/attachment.cgi?id=834601&action=edit updated perl-Fsdb.spec wrt comment 23 to comment 25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096
--- Comment #27 from John Heidemann ---
A new release is out:
https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb-2.48-1.fc20.src.rpm
The spec is in the SRPM, or at
https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb.spec
This includes the updated spec (see comment 26), fixes some small bugs, and
adds an =encoding to work with perl-5.18 in Fedora-20 (due to someone's name
with a unicode character in it :-).
Unfortunately I just noticed it gets rpmlint errors "non-standard-dir-perm".
This is because the suggestion in comment 23 about using %{_fixperms} is not
sufficiently strongly---fixperms sets many things, but doesn't include g-s for
the directories.
Please let me know if this is sufficient to address the concerns needed to
unblock this package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 John Heidemann changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #42 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #28 from John Heidemann --- Folks, I think spec issues have been addressed. Can we move this package forward? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #29 from Petr Šabata --- Oh, I've missed the update. I'll take a look at the new version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #30 from Petr Šabata --- Ok, this is a different version, so going through it again... Notes on %description: - s/FSDB is package/FSDB is a package/ - I'd cut it at the "Although it's often easy" sentence. Missing BRs: perl(utf8) perl(warnings) Unneeded BRs: perl(HTML::Parser) is not used during build perl(Text::CSV_XS) is not used during build perl(vars) is not used used during build (anymore?) Unneeded runtime dependencies: perl(HTML::Parser) is detected and added automatically by rpmbuild perl(Test::More) is not needed at runtime at all perl(Text::CSV_XS) is detected and added automatically by rpmbuild -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #31 from John Heidemann --- Ok, thank you. Changes in comment #30 made. New release at https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb-2.50-1.fc20.src.rpm The spec is in the SRPM, or at https://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb.spec Your turn again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Petr Šabata changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #32 from Petr Šabata --- Alright, looks good enough now, approving. I've also just sponsored you into the Packager group. Welcome aboard. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #33 from Petr Šabata --- You may now submit the SCM request for this package. See the following guide: http://fedoraproject.org/wiki/Package_SCM_admin_requests Also, since this is a perl package, add `perl-sig' to `InitialCC', please. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #34 from John Heidemann --- Thanks! New Package SCM Request === Package Name: perl-Fsdb Short Description: A set of commands for manipulating flat-text databases from the shell Upstream URL: https://www.isi.edu/~johnh/SOFTWARE/FSDB/Fsdb-2.50.tar.gz Owners: johnh Branches: f19 f20 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 John Heidemann changed: What|Removed |Added Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 John Heidemann changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #35 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #36 from Fedora Update System --- perl-Fsdb-2.50-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Fsdb-2.50-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #37 from Fedora Update System --- perl-Fsdb-2.50-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Fsdb-2.50-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #38 from Fedora Update System --- perl-Fsdb-2.50-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Fsdb-2.50-1.fc20 Resolution|--- |ERRATA Last Closed||2014-06-17 19:33:23 --- Comment #39 from Fedora Update System --- perl-Fsdb-2.50-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Fsdb-2.50-1.fc20 |perl-Fsdb-2.50-1.fc19 --- Comment #40 from Fedora Update System --- perl-Fsdb-2.50-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Christopher Meng changed: What|Removed |Added CC||jo...@isi.edu Flags||needinfo?(jo...@isi.edu) --- Comment #5 from Christopher Meng --- ping. Are you still interested in this package? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UkhVG9nHzo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096
John Heidemann changed:
What|Removed |Added
Flags|needinfo?(jo...@isi.edu)|
--- Comment #6 from John Heidemann ---
Yes, I'm happy to maintain this package, in that we maintain it internally for
our research group, we run Fedora, and I am the package's lead developer.
But the guidelines for getting sponsored are a bit vague ("hang out on irc").
I think I submit reasonable bug reports if you want to assess my clue level.
It's unclear (to me) how I should proceed.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=l6n2xc6e2D&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096
--- Comment #7 from Michael Schwendt ---
Please run rpmlint (or rpmlint -I) on the src.rpm *and* all built rpms. Feel
free to ignore obvious false positives, but fix reported issues and/or comment
on them.
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
> Release: 1
Just to mention its existance:
https://fedoraproject.org/wiki/Packaging:DistTag
Depending on which build targets you'd like to release this package for, you
could remove a few old items from the spec file.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
> OPTIMIZE="$RPM_OPT_FLAGS"
$RPM_OPT_FLAGS and %optflags are C/C++ compiler flags and don't apply to noarch
Perl packages.
> find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
Not needed, pretty much useless (since empty dirs in buildroot don't cause any
build error) and more of a hindrance in packages where you would like to
include an empty directory actually.
> %defattr(-,root,root,-)
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
> it's not clear to me what the %changelog problem is
The %changelog contains an entry for 2.28-1 whereas the linked spec file says
2.40-1.
> But the guidelines for getting sponsored are a bit vague ("hang out on irc").
Well, that's just one way that works for some people to get to know other
package maintainers and potential sponsors. IRC can be time-consuming and is
not mandatory. Doing a few reviews can be one way to show that you know
Fedora's Packaging Guidelines (and especially where to find them when it
becomes necessary to look them up):
http://fedoraproject.org/PackageReviewStatus/
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Reviewing_packages
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Eobkx8CQ4S&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #8 from John Heidemann --- rpmlint found some problems; I'll fix them in the next release. Thanks for the pointers wrt optimize/find/etc. There's some level of cargo cultery there (rpm documentation is not always obvious). I was hoping to avoid %changelog since it has nothing useful to say, since I am both developer and packager. But I can fill it with low-content but rpmlint-satisfying entries "updated for version x". (I realize in most cases developer and packager are different parties.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1AjHxbRhCV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #9 from John Heidemann --- All of the problems mentioned in comment 7, plus most other rpmlint errors, are now fixed in release 2.41 at http://www.isi.edu/~johnh/SOFTWARE/FSDB/ I have this rpmlint error on the srpm: perl-Fsdb.src: E: invalid-spec-name which seems puzzling to me, as the only contents of that rpm are: Fsdb-2.41.tar.gz Fsdb.spec and that spec looks valid to me. (Unless maybe the spec need to be perl-Fsdb.spec?) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2IBiRZA9h5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #10 from Christopher Meng --- Can you provide the links? I don't know the problem if you just talk. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RQtnYKMv0Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #11 from John Heidemann --- I quoted the error message in comment 9, but if you get: Spec URL: http://www.isi.edu/~johnh/SOFTWARE/FSDB/Fsdb.spec SRPM URL: http://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb-2.41-1.src.rpm bash> rpmlint perl-Fsdb-2.41-1.fc19.src.rpm perl-Fsdb.src: W: spelling-error %description -l en_US outliers -> outlines perl-Fsdb.src: E: invalid-spec-name 1 packages and 0 specfiles checked; 1 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E5oxfIKftT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #12 from John Heidemann --- Sorry, wrong url (cut and paste error). It should be: SRPM URL: http://www.isi.edu/~johnh/SOFTWARE/FSDB/perl-Fsdb-2.41-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8pIkNP3QQ5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #13 from Christopher Meng --- Aha of course it's wrong... In your SRPM: perl-Fsdb.spec, not Fsdb.spec... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7xoyi5ENuO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #14 from John Heidemann --- Wrt comment 13: you're correct. Will be fixed in next release. I believe then it rpmlints without error, and with only one warning about an incorrect spelling error. Are there any other changes needed to get this package accepted? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TuE1h5pyDt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Christopher Meng changed: What|Removed |Added CC||bugs.mich...@gmx.net Flags||needinfo?(bugs.michael@gmx. ||net) --- Comment #15 from Christopher Meng --- I don't know(haven't looked into very deep.) You can leave these to your sponsor. I suggest that you should get in touch with perl SIG people, maybe they can sponsor you. Not every sponsor knows perl very well. Ah..Michael, will you do him a favor? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=81n4eFPZU4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Michael Schwendt changed: What|Removed |Added CC|bugs.mich...@gmx.net| Flags|needinfo?(bugs.michael@gmx. | |net)| --- Comment #16 from Michael Schwendt --- Hmm, I don't even maintain a Perl based package anymore. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XFlKRf4M1W&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #1 from John Heidemann --- This bug is marked "needsponser". What is the mechanism to get that resolved? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eG4riDoeXB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877096 Petr Šabata changed: What|Removed |Added CC||psab...@redhat.com --- Comment #2 from Petr Šabata --- (In reply to comment #1) > This bug is marked "needsponser". What is the mechanism to get that > resolved? This might interest you: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XQD7YeQ0cG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877096
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #3 from Christopher Meng ---
In my opinion, I think you should use cpanspec and create a spec from cpan.org.
Explicitly, I think the URL and source should be filled like this(Just an
example):
URL:http://search.cpan.org/dist/Fsdb/
Source0:
http://search.cpan.org/CPAN/authors/id/J/JO/JOHNH/Fsdb-%{version}.tar.gz
And, the %changelog has incorrect version with %{version}.
Also,if you want to maintain a spec for EPEL also, you can keep Group and
%defattr(-,root,root,-) and %clean, otherwise you should remove them.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=7rgVkXGFYU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #4 from John Heidemann --- Thanks for the tips in comment #3. I ran cpanspec. It had some dependencies I picked up; they'll be in Fsdb-2.39 (not yet out). But my website is the upstream, not CPAN, and it's not clear to me what the %changelog problem is (although I don't actually track changes with that since I maintain the spec and the software). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m4f6DvMlo4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
