[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #31 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #30 from Susi Lehtola susi.leht...@iki.fi --- Package Change Request == Package Name: libint2 New Branches: epel7 Owners: jussilehtola -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Dominik 'Rathann' Mierzejewski domi...@greysector.net changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libint2-2.0.3-2.641hg.fc19 |libint2-2.0.3-2.641hg.el6 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b0OX9gZLgda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libint2-2.0.3-2.641hg.el6 |libint2-2.0.3-2.641hg.el5 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0bQuYGryYVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libint2-2.0.3-2.641hg.fc18 Resolution|--- |ERRATA Last Closed||2013-05-29 22:58:36 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xdH7dg6Z11a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libint2-2.0.3-2.641hg.fc18 |libint2-2.0.3-2.641hg.fc19 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bgm5eughVIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libint2-2.0.3-2.641hg.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gj9ooYG6TCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libint2-2.0.3-2.641hg.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Vr4kxh1Sca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libint2-2.0.3-2.641hg.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X21xMx4ma1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.3-2.641hg.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libint2-2.0.3-2.641hg.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cQqJcFxIh0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SeL03S2daVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.2-2.618hg.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libint2-2.0.2-2.618hg.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=faW7vb2EfBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.2-2.618hg.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libint2-2.0.2-2.618hg.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Re6wj8ICM8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.2-2.618hg.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libint2-2.0.2-2.618hg.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x0nY0T63hja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- libint2-2.0.2-2.618hg.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e6Ge1kVeSZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #16 from Susi Lehtola susi.leht...@iki.fi --- Package Change Request == Package Name: libint2 New Branches: EL-5 EL-6 Owners: jussilehtola InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kUl4D49Jxxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X4vw8McZi0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I2Prhy4hUra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=srrblGbkSfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=itZxuFTle0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Alex G. mr.nuke...@gmail.com changed: What|Removed |Added CC||mr.nuke...@gmail.com Assignee|nob...@fedoraproject.org|mr.nuke...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O5iTNml33ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #7 from Alex G. mr.nuke...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libint2-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/home/mrnuke/rpmbuild/review/903380-libint2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 911360 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: Uses parallel make.
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #8 from Alex G. mr.nuke...@gmail.com ---
-- MUST --
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libint2-devel
Requires: libint2 = %{version}-%{release}
This is incorrect. The -devel package dependency must be arch-specific.
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
libint2.x86_64: E: incorrect-fsf-address /usr/share/doc/libint2-2.0.0/LICENSE
The LICENSE file includes the following fsf address:
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
The correct address is:
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
Please have upstream update their LICENSE file.
-- SHOULD --
BuildRoot:
rm -rf %{buildroot}
%defattr
%clean
If you plan to also package for EPEL5, I recommend you only keep the above in
the EPEL5 branch, and remove them from EPEL6 and Fedora branches.
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 911360 bytes in 2 files.
I would recommend putting the programming manual (progman.pdf) in a separate
-doc or -devel-doc package. It accounts for the majority of the size of the
-devel rpm.
[!]: Uses parallel make.
fedora-review identifies this as a fail. That's a flase positive. I can see 8
cc1plus processes spawn during the build.
make -C doc
Can the documentation use parallel make?
%{_libdir}/libint*.so.*
Please consider versioning here:
%{_libdir}/libint*.so.1*
This makes it very easy to catch soname version bumps, and is much safer than
undiscriminately accepting any library the build spits out.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=y8LYOYpVfPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #9 from Susi Lehtola susi.leht...@iki.fi ---
(In reply to comment #7)
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[ ]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
I'm also targetting EPEL5 so these are necessary.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libint2-devel
Added the %{?_isa}.
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 911360 bytes in 2 files.
I'm following the same rationale as in libint. This is a highly specialized
package, and is only going to be installed by developers, for which the
documentation is very much important, since the library is pretty much useless
without it (requires many pages worth of initializing procedures).
(Note that the compiled library itself is 201MB!)
(In reply to comment #8)
libint2.x86_64: E: incorrect-fsf-address
/usr/share/doc/libint2-2.0.0/LICENSE
The LICENSE file includes the following fsf address:
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
The correct address is:
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
Please have upstream update their LICENSE file.
I'll ask upstream to perform the update, and possibly add a proper COPYING file
as well.
If you plan to also package for EPEL5, I recommend you only keep the above in
the EPEL5 branch, and remove them from EPEL6 and Fedora branches.
There's no sense in multiplying the workload without any added benefit. The
obsoleted stuff doesn't hurt anything.
[!]: Uses parallel make.
fedora-review identifies this as a fail. That's a flase positive. I can see 8
cc1plus processes spawn during the build.
make -C doc
Can the documentation use parallel make?
Not really - it's about running LaTeX on a single file, and doxygen.
%{_libdir}/libint*.so.*
Please consider versioning here:
%{_libdir}/libint*.so.1*
This makes it very easy to catch soname version bumps, and is much safer than
undiscriminately accepting any library the build spits out.
Well, in the case of libint sonames don't have much use anyway, since in my
experience one can break the ABI compatibility just by changing the configure
flags.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3HPMjfHBeGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #10 from Alex G. mr.nuke...@gmail.com ---
(In reply to comment #9)
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libint2-devel
Added the %{?_isa}.
Where is the new .spec ?
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 911360 bytes in 2 files.
I'm following the same rationale as in libint. This is a highly specialized
package, and is only going to be installed by developers, for which the
documentation is very much important, since the library is pretty much
useless without it (requires many pages worth of initializing procedures).
(Note that the compiled library itself is 201MB!)
My rationale is that some developers (such as myself) like to install a minimal
-devel package and read the documentation online. Now, a pdf file of 1MB is
not a big issue. It's your choice. This point is [x].
(In reply to comment #8)
The correct address is:
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
Please have upstream update their LICENSE file.
I'll ask upstream to perform the update, and possibly add a proper COPYING
file as well.
Cool. Thanks.
If you plan to also package for EPEL5, I recommend you only keep the above
in
the EPEL5 branch, and remove them from EPEL6 and Fedora branches.
There's no sense in multiplying the workload without any added benefit. The
obsoleted stuff doesn't hurt anything.
Ok. I accept your answer.
Can the documentation use parallel make?
Not really - it's about running LaTeX on a single file, and doxygen.
Then it's not a problem.
%{_libdir}/libint*.so.*
Please consider versioning here:
%{_libdir}/libint*.so.1*
This makes it very easy to catch soname version bumps, and is much safer
than
undiscriminately accepting any library the build spits out.
Well, in the case of libint sonames don't have much use anyway, since in my
experience one can break the ABI compatibility just by changing the
configure flags.
OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mP5lo2maMNa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #11 from Susi Lehtola susi.leht...@iki.fi ---
(In reply to comment #10)
(In reply to comment #9)
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libint2-devel
Added the %{?_isa}.
Where is the new .spec ?
Since you asked for it...
http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2-2.0.0-3.607hg.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kCOJKavA8Ya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Alex G. mr.nuke...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #12 from Alex G. mr.nuke...@gmail.com --- Since you asked for it... http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2-2.0.0-3.607hg.fc18. src.rpm The .spec link still has the 2.0.0-2, but I was able to get the correct .spec from the new srpm. Since I see no blockers, this package is APPROVED :) . Best wishes on your studies/research! I'm just about to finish my undergrad studies soonish. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T2qmJo61Jya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #13 from Susi Lehtola susi.leht...@iki.fi --- (In reply to comment #12) Since you asked for it... http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2-2.0.0-3.607hg.fc18. src.rpm The .spec link still has the 2.0.0-2, but I was able to get the correct .spec from the new srpm. You probably forgot to hit browser refresh ;) Since I see no blockers, this package is APPROVED :) . Best wishes on your studies/research! I'm just about to finish my undergrad studies soonish. Thanks, you too! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09Do3k2NLwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #14 from Susi Lehtola susi.leht...@iki.fi --- New Package SCM Request === Package Name: libint2 Short Description: A library for efficient evaluation of electron repulsion integrals Owners: jussilehtola Branches: F-18 F-19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0Yo62pRYpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Alias||libint2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n0mwUadavSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks||505154 (FE-SCITECH) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AKFrBJn5qTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
--- Comment #6 from Susi Lehtola susi.leht...@iki.fi ---
(In reply to comment #5)
Depricated:
* %clean section
* rm -rf %{buildroot}
* %defattr(-,root,root,-)
Not in EPEL5.
Try fedora-review -r -n srpm_path localy - I get error checking this bug.
Uhm.. I get a single fail in the SHOULD section, namely that parallel make is
not enabled... which is spurious.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=DEcC5yVwsCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903380
Eugene A. Pivnev ti.eug...@gmail.com changed:
What|Removed |Added
CC||ti.eug...@gmail.com
--- Comment #5 from Eugene A. Pivnev ti.eug...@gmail.com ---
Depricated:
* %clean section
* rm -rf %{buildroot}
* %defattr(-,root,root,-)
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Try fedora-review -r -n srpm_path localy - I get error checking this bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=utbPQu4k8Aa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #3 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Why are you using Mercurial snapshot instead of released tarball? http://downloads.sourceforge.net/project/libint/libint-for-mpqc/libint-2.0.0-stable.tgz -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S4EUZHpYxaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #4 from Susi Lehtola susi.leht...@iki.fi --- (In reply to comment #3) Why are you using Mercurial snapshot instead of released tarball? http://downloads.sourceforge.net/project/libint/libint-for-mpqc/libint-2.0.0- stable.tgz It's because that one is not the compiler, it's a generated source code tarball. The compiler doesn't have tarball releases. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S1E4NPreOga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #1 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Created attachment 699221 -- https://bugzilla.redhat.com/attachment.cgi?id=699221action=edit fix spec issues Looks like it doesn't build out-of-the-box at least on F18/x86_64 (in mock). Attached patch to fix the missing TeX dependencies and some rpmlint issues (-devel not depending on main package). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N698PT6oTwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #2 from Susi Lehtola susi.leht...@iki.fi --- Thanks! Patched files http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/libint2-2.0.0-2.607hg.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F8XCku43x8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
