[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
https://bugzilla.redhat.com/show_bug.cgi?id=904328 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||perl-Config-ApacheFormat-1. ||2-1.fc17 Resolution|--- |CURRENTRELEASE Last Closed||2014-04-03 12:18:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3pPvhioxTMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fM2ygbZtYxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #13 from Petr Šabata psab...@redhat.com --- Alright, approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cVdW2JcogZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Normunds fedora...@rule.lv changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Normunds fedora...@rule.lv --- Thanks. Adding fedora-cvs flag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6XDNvogz1Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- No SCM request found, unsetting flag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=popLHmiUVwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Normunds fedora...@rule.lv changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Normunds fedora...@rule.lv --- Sorry for that. Re-trying. New Package SCM Request === Package Name: perl-Config-ApacheFormat Short Description: Use Apache format config files. Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ghx3tdZxIwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W1lhSwmkfba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0RD0nrexhJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LJgN6axOTca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fKMeIZggn7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #12 from Normunds fedora...@rule.lv --- Another reviewer suggested to use simpler e-mail obfuscation, so, to be consistent, I changed it for all packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lMn6BMwyXba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #10 from Petr Šabata psab...@redhat.com --- (In reply to comment #9) [...] wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now? Still getting used to rpmbuild behavior. I was assuming that if rpmbuild detects Requirement and requirement is specified in spec file, it will show duplicate Requirement in rpm --requires output. It used to be like that. Not anymore. The duplicates get filtered out. * perl(Class::MethodMaker) removed from Requirements. Ok. * Added obfuscated e-mail. *sigh* If you must... enclose it with qw( ) at least. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3Un2bCJaea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #11 from Normunds fedora...@rule.lv --- Spec file/srpm updated, added to e-mail. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1gNj0cuutka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #9 from Normunds l...@rule.lv --- [...] wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now? Still getting used to rpmbuild behavior. I was assuming that if rpmbuild detects Requirement and requirement is specified in spec file, it will show duplicate Requirement in rpm --requires output. * perl(Class::MethodMaker) removed from Requirements. * Added obfuscated e-mail. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AYLrl6bG7La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #8 from Petr Šabata psab...@redhat.com --- (In reply to comment #7) Moved Data::Dumper to Requires Good. Indeed, it wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now? I see you've removed your email address from the changelog here too; why? https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6jCidnQHgja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #7 from Normunds l...@rule.lv --- Moved Data::Dumper to Requires, removed macro. Please check. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zwq4ysuegLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Petr Šabata psab...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #5 from Petr Šabata psab...@redhat.com --- Removing FE-NEEDSPONSOR. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D4MI2vZakEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904328
--- Comment #6 from Petr Šabata psab...@redhat.com ---
I see you also added the Data::Dumper dependency. Its only used in the dump()
subroutine which is not called from the tests at all. You may drop this again
:)
And again, that %{__perl} macro in MODULE_COMPAT...
Not approving yet.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Bp0IPsZK4Xa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? --- Comment #2 from Petr Šabata psab...@redhat.com --- Taking the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lzcI2o3mwza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #3 from Petr Šabata psab...@redhat.com --- Issues similar to those of other reviews... Missing build-time dependency: perl(Carp) Unneeded runtime dependencies: perl(Class::MethodMaker) perl(File::Spec) perl(Scalar::Util) perl(Text::Balanced) Those are automatically picked up by rpmbuild. Lines 40 and 41 are unneeded. None of the files has executable bits set. Line 52 is also unneeded (done by rpmbuild). And the command macros could be replaced with simple calls. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pMbzQ2uH3Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #4 from Normunds l...@rule.lv --- Spec file and src package updated. * Fixed dependencies. * Replaced macros with simple commands. * Removed useless lines New package overwritten in original location. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h4A7YUnRMFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 Normunds l...@rule.lv changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZRmpUuzPZaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #1 from Normunds l...@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems. Need sponsor. bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iqQkvnQwEIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
