[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PYY6FgGjXUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2m0vrUgYHfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-21 20:41:14 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uBA8jwuEuEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=98jw1RDZhWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dBpmlqyQSma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AwDYoPVzg2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iZIpA9LS0xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Added f19 branch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TzaFEZJ8rAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4FniJW8TBga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jgettext-0.13-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xeUOa4fepua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jgettext-0.13-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UlaQIUFQQwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- jgettext-0.13-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jgettext-0.13-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I45ntXBGsUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #10 from Patrick Huang pahu...@redhat.com --- amended spec according to Comment 9. SPEC URL: http://fedorapeople.org/~pahuang/jgettext.spec SRPM URL: http://fedorapeople.org/~pahuang/jgettext-0.13-2.fc17.src.rpm f19 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5263140 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6AjShxJ3Cma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Patrick Huang pahu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Patrick Huang pahu...@redhat.com --- New Package SCM Request === Package Name: jgettext Short Description: An ANTLR-based parser and generator for GNU Gettext PO/POT in Java Owners: pahuang seanf Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YPGocJ1CRTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #9 from Tomas Radej tra...@redhat.com --- I can't object to the conditional build solution you chose, but I personally would go with different SPECs for rawhide/F19+ and F18-. The SPEC is okay apart from mixing Requires and BuildRequires. They should be in separate, non-overlapping groups. I am, though, trusting you to fix this before you upload. Additional notes: * Group tag is not necessary, so unless you intend to support EPEL, you may omit it. * BuildRequires on jpackage-utils is not necessary for maven packages, it's automatically required by maven-local. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T9IGcSuJb3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908594
--- Comment #7 from Tomas Radej tra...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= Issues =
(These problems block the review)
[!]: Package complies to the Packaging Guidelines
You should use the newest packaging method, i. e. building with %mvn_build
and installing with %mvn_install, unless you intend to submit this package
for Fedora 17 or 18. If this is the case, I will approve the review. If
not, I kindly ask you to migrate the SPEC to the current method as
specified in the Fedora Java Packaging Guidelines:
http://fedoraproject.org/wiki/Packaging:Java#Apache_Maven
= Notes =
(These are nice to have things)
[x]: Pom files have correct add_maven_depmap call
You can simply use %add_maven_depamp without arguments in this case.
This point is only valid for older Fedora releases, as 19 and rawhide
should use %mvn_install.
[!]: Requires correct, justified where necessary.
You can omit these packages from BR as they are provided by maven-local:
maven-compiler-plugin
maven-jar-plugin
maven-javadoc-plugin
maven-surefire-plugin
[!]: Latest version is packaged.
0.13 is out, but I am not blocking the review on that.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jgettext-
javadoc
[!]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/tradej/reviews/908594-jgettext/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #8 from Patrick Huang pahu...@redhat.com --- f19 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5139614 Updated according to review. Yes I also intended to submit to F17 and F18. I choose a conditional build so in F19 it will comply with the guideline. SPEC URL: http://fedorapeople.org/~pahuang/jgettext.spec SRPM URL: http://fedorapeople.org/~pahuang/jgettext-0.13-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KdUHWNOXEWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #6 from Patrick Huang pahu...@redhat.com --- it builds in f17 and f18: f18 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5051321 Only fail in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P04Bzs7rdwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #4 from Tomas Radej tra...@redhat.com --- Package fails to build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5037324 Please, fix this before I can continue with the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AMMqtPekIOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added CC||socho...@redhat.com --- Comment #5 from Stanislav Ochotnicky socho...@redhat.com --- (In reply to comment #4) Package fails to build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5037324 Please, fix this before I can continue with the review. This is a bug that I have yet to track down (most likely in antlr or antlr plugin). I'll keep you posted -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MJujylco7Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com Assignee|nob...@fedoraproject.org|tra...@redhat.com Flags||fedora-review? --- Comment #1 from Tomas Radej tra...@redhat.com --- I will do this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSVPLr7wXca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908594
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
CC||mizde...@redhat.com
--- Comment #2 from Mikolaj Izdebski mizde...@redhat.com ---
%if 0%{?fedora} 18
%define mvnbuildRequires maven-local
%else
%define mvnbuildRequires maven
%endif
This is not needed. BR: maven-local can be used in all Fedoras (F16+)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=5eBW3Yntifa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 --- Comment #3 from Patrick Huang pahu...@redhat.com --- Updated spec file according to comment 2 Spec URL: http://fedorapeople.org/~pahuang/jgettext.spec SRPM URL: http://fedorapeople.org/~pahuang/jgettext-0.12-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=888QDXrv1Wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
