[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #9 from Rex Dieter rdie...@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines-4.10.0-3.fc18.src.rpm %changelog * Thu Feb 21 2013 Rex Dieter rdie...@fedoraproject.org 4.10.0-3 - update summary, fix typo in description -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MOJmU31FRya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 nucleo alekc...@googlemail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from nucleo alekc...@googlemail.com --- MUST Items: + rpmlint output $ rpmlint klines-4.10.0-1.fc18.i686.rpm klines-debuginfo-4.10.0-1.fc18.i686.rpm klines-4.10.0-3.fc18.src.rpm klines.spec klines.i686: W: no-manual-page-for-binary klines klines.src: W: spelling-error %description -l en_US Kolor - Color, Dolor 3 packages and 1 specfiles checked; 0 errors, 2 warnings. + named and versioned according to the Package Naming Guidelines. Package name match the upstream tarball name klines-4.10.0.tar.xz + spec file name klines.spec matches base package name + complies with all the legal guidelines: + License: GPLv2+ and GFDL, matches actual license (added notices for parts under different licenses) + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc + source matches upstream: MD5: c67ae3a077351397aeb96a33350aec4b klines-4.10.0.tar.xz SHA1: 0886b2c788725034f4b8367a6f5db16344a87159 klines-4.10.0.tar.xz SHA256: c97cbf53c71d05cd39068b07d8ab7948e681bbf87b9ccd567b405b1ec6371392 klines-4.10.0.tar.xz + builds on at least one arch build from mock is in F18 kde-unstable repo + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) + locales are handled properly by using %find_lang %{name} --with-kde macro + ldconfig call not needed (no shared libraries) + no duplicated system libraries + package not relocatable (no Prefix tag) + directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/%{name}/) + no duplicate files in %files + permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions + macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir}) + non-code content: only permitted content, themes under license that matches the code + no large documentation files, so no -doc package needed + no %doc files required at runtime + no header files, no -devel package needed + no static libraries, so no -static package needed + no devel symlinks which would need to be in a -devel subpackage + devel packages must require the base package (no -devel package) + no .la files + klines.desktop file for the GUI app klines present + desktop-file-validate is used in %check and the klines.desktop file passes validation + all filenames are valid UTF-8 + other packaging guidelines: + complies with the Filesystem Hierarchy Standard (all files in %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir},%{_kde4_configdir}) + proper changelog, tags, BuildRequires, Summary, Description (got from klines's documentation) + no non-UTF-8 characters + all relevant documentation included as %doc (COPYING, COPYING.DOC, AUTHORS README.themes) + RPM_OPT_FLAGS are used in %{cmake_kde4} macro + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it) + no rpaths (no check-rpaths error) + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + timestamps are preserved + %{?_smp_mflags} used + not a web application, so web application guideline doesn't apply + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps) SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (built for kde-unstable) - successfully tested the package functionality (no testing yet) + scriptlets are sane (updating icon chache in %post, %postun, %posttrans) + subpackages other than devel should require the base package using a fully versioned dependency (no subpackages) + no .pc files, so placement of .pc files is irrelevant + no file dependencies - package should contain man pages for binaries/scripts APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pUx74aLvh6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 nucleo alekc...@googlemail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||alekc...@googlemail.com Assignee|nob...@fedoraproject.org|alekc...@googlemail.com Flags||fedora-review? --- Comment #8 from nucleo alekc...@googlemail.com --- In desktop it just Kolor lines or Tactical Game but maybe better summary will be Color lines game. There is typo in %description ame board. , should be game board Everything else fine. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7sL3wF0RQZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #1 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - MUST: The spec file must be written in American English. [5] OK -read complete spec file MUST: The spec file for the package MUST be legible. [6]--OK -read and reviewed spec file -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c9UGctKYpaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #2 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden---OK --this spec file shows %find_lang %{name} --with-kde -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uHIl2AugS3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #3 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] -- --OK --this spec file shows %files -f %{name}.lang -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZzY1ojiOnHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #4 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18]-- --OK --this spec file shows %doc COPYING -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BxsZJ8VHi5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #5 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[19]---OK --this spec file shows no .la -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9u28mWLlzOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #6 from Vijay Richard richardv...@fedoraproject.org --- FAS : Richardvj11 I am not an official package reviewer yet, but an aspiring package reviewer. - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [26]---OK --this spec file no Non-English handling/requirement -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n6n2tBHxgCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines-4.10.0-2.fc18.src.rpm %changelog * Fri Feb 15 2013 Rex Dieter rdie...@fedoraproject.org 4.10.0-2 - update license, description Vijay, thanks for the feedback and informal review. One bit of advice, better to batch all your SHOULD/MUST feedback into a single (or few) bugzilla comments... no need to make it one item per comment (which is far less efficient). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dVZwGvXpxMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||907993 (kde-4.10), 656997 ||(kde-reviews) Depends On||908920 (libkdegames) Alias||klines -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lCKiKd8w0ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 Bug 910510 depends on bug 908920, which changed state. Bug 908920 Summary: Review Request: libkdegames - Common code and data for many KDE games https://bugzilla.redhat.com/show_bug.cgi?id=908920 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=evYX4LF3Mxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review