[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Rich Mattes richmat...@gmail.com --- Package Change Request == Package Name: python-catkin_pkg New Branches: el6 epel7 Owners: rmattes ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-catkin_pkg-0.1.18-1. ||fc18 Resolution|--- |ERRATA Last Closed||2013-08-23 19:57:51 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-catkin_pkg-0.1.18-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PutfYjfagga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-catkin_pkg-0.1.18-1. |python-catkin_pkg-0.1.18-1. |fc18|fc19 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-catkin_pkg-0.1.18-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vLCr6XJgFGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-catkin_pkg-0.1.18-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lGTfEaAPxKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Thanks Rich. New Package SCM Request === Package Name: python-catkin_pkg Short Description: Library for retrieving information about catkin packages Owners: ankursinha Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WEToM6JYwSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lXEpdtgq6ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pINfB0v7Woa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8qmfagB9xia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-catkin_pkg-0.1.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-catkin_pkg-0.1.18-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SRy461vUDxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-catkin_pkg-0.1.18-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-catkin_pkg-0.1.18-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U2SqrDzjB6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- (In reply to Christopher Meng from comment #4) No big problem here. Should be given + Only a suggestion: %global module_name catkin_pkg Well module_name is 11 chars, and catkin_pkg is 10 chars, why not keeping its original name? It isn't to do with saving space. It's to do with clarity. Rich, I forgot to mention: the make file doesn't have a doc target. The docs folder doesn't have much as docs anyway. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1SBjKhi9W1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Rich Mattes richmat...@gmail.com --- Looks good. I mis-spoke when I was talking about the documentation; it looks like there aren't any sphinx docs like most of the other ROS packages. So with your new changes, this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tdxN5w1BOva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #2 from Rich Mattes richmat...@gmail.com --- Any updates here? I'd like to get bug 975896 taken care of. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wYKGDnLZGta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #3 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Updated spec/srpm: http://ankursinha.fedorapeople.org/python-catkin_pkg/python-catkin_pkg.spec http://ankursinha.fedorapeople.org/python-catkin_pkg/python-catkin_pkg-0.1.18-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5y0TnzXZpra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #4 from Christopher Meng cicku...@gmail.com --- No big problem here. Should be given + Only a suggestion: %global module_name catkin_pkg Well module_name is 11 chars, and catkin_pkg is 10 chars, why not keeping its original name? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSWTvfkLxNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||975896 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WzqoPK0lb2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|richmat...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bvWJ8khH2ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034
Rich Mattes richmat...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||richmat...@gmail.com
Flags||fedora-review?
--- Comment #1 from Rich Mattes richmat...@gmail.com ---
I'll take this review.
Initial comments:
1. It's probably better to use the real upstream repository instead of the
archives loaded to pypi. The pypi archives don't have any documentation. Real
upstream is at https://github.com/ros-infrastructure/catkin_pkg/tags, and the
github source URL guidelines and the snapshot package naming guidelines apply.
2. Unless you're targeting el5, you probably don't need the python-site* at the
top of the spec. These are defined on el6 and fedora.
Fedora-review, finished by me:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), Unknown or generated. 5 files have unknown license.
Detailed output of licensecheck in /home/rich/tmp/926034-python-
catkin_pkg/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926034 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=871197 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=INqVTVbDfha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
