[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #17 from Fedora Update System --- golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #16 from Fedora Update System --- golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Jan Chaloupka changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-09-22 04:06:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #15 from Fedora Update System --- golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #14 from Fedora Update System --- golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Jan Chaloupka changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Jan Chaloupka --- New Package SCM Request === Package Name: golang-github-mreiferson-go-httpclient Short Description: A Go HTTP client library Upstream URL: https://github.com/mreiferson/go-httpclient/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Lokesh Mandvekar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Lokesh Mandvekar --- LGTM. specfile follows golang packaging draft guidelines: https://fedoraproject.org/wiki/PackagingDrafts/Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #10 from Jan Chaloupka --- Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7631916 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857
--- Comment #9 from Lokesh Mandvekar ---
Vincent, btw, I don't think we need "ExclusiveArch: %{go_arches} noarch" in
the main package. We could just have BuildArch: noarch in the devel package for
now.
Also, aren't %{go_arches} and noarch contradictory?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|vba...@redhat.com |l...@fedoraproject.org Flags||fedora-review? --- Comment #8 from Lokesh Mandvekar --- Hey Vincent, I'm kinda bored and finishing up the review for this :). It's pretty much done anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Lokesh Mandvekar changed: What|Removed |Added CC||l...@fedoraproject.org --- Comment #7 from Lokesh Mandvekar --- %check is likely gonna fail in koji: + go test github.com/mreiferson/go-httpclient --- FAIL: TestHttpsConnection (1.00 seconds) httpclient_test.go:93: 1st request failed - Get https://httpbin.org/ip: dial tcp: i/o timeout FAIL FAILgithub.com/mreiferson/go-httpclient3.963s error: Bad exit status from /var/tmp/rpm-tmp.OK8Fqh (%check) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library
https://bugzilla.redhat.com/show_bug.cgi?id=1120857
Jan Chaloupka changed:
What|Removed |Added
Summary|Review Request: |Review Request:
|golang-github-mreiferson-go |golang-github-mreiferson-go
|-httpclient |-httpclient - A Go HTTP
||client library
--- Comment #6 from Jan Chaloupka ---
Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient.spec
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient-0-0.0.gitc121dfe.fc21.src.rpm
Description: A Go HTTP client library
$ rpmlint
/root/rpmbuild/SRPMS/golang-github-mreiferson-go-httpclient-0-0.0.gitc121dfe.fc21.src.rpm
/root/rpmbuild/RPMS/noarch/golang-github-mreiferson-go-httpclient-devel-0-0.0.gitc121dfe.fc21.noarch.rpm
golang-github-mreiferson-go-httpclient.spec
golang-github-mreiferson-go-httpclient.src: W: spelling-error %description -l
en_US librarys -> library, library's, library s
golang-github-mreiferson-go-httpclient.src:38: W: macro-in-comment %check
golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{buildroot}
golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{gopath}
golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{gopath}
golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment
%{import_path}
golang-github-mreiferson-go-httpclient.spec:38: W: macro-in-comment %check
golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment
%{buildroot}
golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{gopath}
golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{gopath}
golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment
%{import_path}
2 packages and 1 specfiles checked; 0 errors, 11 warnings.
Initial commit by Colin Walters
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7592220
%check commented so we can enable the test in future, now it fails to check in
koji.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #5 from Jan Chaloupka --- $ rpmlint golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.spec:30: W: setup-not-quiet 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Patch + rpmlint warnings applied. Pull request created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857
--- Comment #4 from Vincent Batts ---
Created attachment 936275
--> https://bugzilla.redhat.com/attachment.cgi?id=936275&action=edit
tweaks on layout
comments to accommodate the attached patch:
* %{gopath} is provided by the golang rpm
* exclusivearch to have this not build on the ppc and s390 builders
* sane version constaints
* this -devel is noarch
* preserve time on source
* include tests
* removing the directories that are owned by the golang rpm
* include the version in the changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #3 from Jan Chaloupka --- Eric, yes, it is. $ rpmlint golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.spec:30: W: setup-not-quiet Vincent, I guess * preserve timestamps of source copied is still valid here. Otherwise, the tarball contains only: $ ls httpclient.go httpclient_test.go LICENSE README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Eric Paris changed: What|Removed |Added CC||epa...@redhat.com, ||jchal...@redhat.com --- Comment #2 from Eric Paris --- Jan, Is this the latest git location of the spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Vincent Batts changed: What|Removed |Added CC||vba...@redhat.com Assignee|nob...@fedoraproject.org|vba...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 Colin Walters changed: What|Removed |Added Blocks||1047194 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1047194 [Bug 1047194] etcd-0.4.5 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #1 from Colin Walters --- Er, Spec URL: https://github.com/projectatomic/golang-github-mreiferson-go-httpclient-package/blob/master/golang-github-mreiferson-go-httpclient.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
