[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #30 from Fedora Update System  ---
libu2f-host-1.0.0-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-10-26 23:37:48 |2015-11-12 18:28:59



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #31 from Fedora Update System  ---
libu2f-host-1.0.0-3.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #29 from Upstream Release Monitoring 
 ---
jjelen's scratch build of
yubico-piv-tool?#f493f908260c8e3946798b6730c4e20e37b367fa for
git://pkgs.fedoraproject.org/yubico-piv-tool?#f493f908260c8e3946798b6730c4e20e37b367fa
and rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11804105

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #26 from Fedora Update System  ---
libu2f-host-1.0.0-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-3edb5a0c25

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #25 from Fedora Update System  ---
libu2f-host-1.0.0-3.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-f51a4a41c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|DUPLICATE   |---
   Keywords||Reopened



--- Comment #27 from Fedora Update System  ---
libu2f-host-1.0.0-3.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libu2f-host'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-f51a4a41c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #22 from Seth Jennings  ---
Unversioned .so files belong in the -devel package per the guidelines (rpmlint
complains).

Yes, this libu2f-host review and the libu2f-server review (1259460) both need
some attention.  The packages are very similar.  A single reviewer could review
them both.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #21 from Baptiste Mille-Mathias  
---
Hi gents,

As it seems there is no review done yet on this package, perhaps you should ask
some on the developers mailing-list?
I've quickly look at the packages, is there any reason the *.so file is
provided by the -devel package ?
Looking forward to see this package be available on the repo :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Seth Jennings  changed:

   What|Removed |Added

 Resolution|DEFERRED|DUPLICATE



--- Comment #24 from Seth Jennings  ---
Actually, marking as a dup of the new bug is better.

*** This bug has been marked as a duplicate of bug 1275487 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Seth Jennings  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
Last Closed||2015-10-26 23:37:48



--- Comment #23 from Seth Jennings  ---
Closing this bug so review can proceed in another bug per Andy's request in
comment 19.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #19 from Andy Lutomirski  ---
Seth, if you want to own this, can you close this bug and open a new one?  I
think that's required for the semi-automatic review magic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Seth Jennings  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1259460



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #18 from Seth Jennings  ---
Now that my first package, yubioath-desktop, is fully complete and know the
process and I'm coming back to this.

Based on Andy's previous submissions + changes to address Till's feedback in
comment 15:
https://www.variantweb.net/pub/review/libu2f-host.spec
https://www.variantweb.net/pub/review/libu2f-host-1.0.0-1.fc22.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=10917441

Feedback welcome!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #16 from spartacu...@gmail.com ---
Andy, are you still interested in maintaining this?  If not, I can pick it up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #17 from Andy Lutomirski l...@mit.edu ---
Sure!  Or we could co-maintain.

I want to remove the udev policy from here in favor of:

https://github.com/amluto/u2f-hidraw-policy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #15 from Till Maas opensou...@till.name ---
Sorry, I did not noctice your update until now.

There are still some issues:
- The license of the library is actually LGPLv2+ only the command line tools
are GPLv3+
- There is more documentation that is not included yet:
AUTHORS ChangeLog  NEWS  THANKS  doc/Mode_switch_YubiKey_NEO.adoc
- The LGPV2 license is currently missing in the upstream release (but it is in
git), I opnened an upstream ticket for this:
https://github.com/Yubico/libu2f-host/issues/20 - please mention this in the
spec and include it once upstream makes a new release
- Upstream provides a GPG signature, therefore it could be checked in the SPEC
file, for example like here:
http://pkgs.fedoraproject.org/cgit/youtube-dl.git/tree/youtube-dl.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #14 from Andy Lutomirski l...@mit.edu ---
I updated to the new version, make those changes, and dropped the udev rule. 
I'll make another new package with a udev rule, since I think it should be
separate.

Spec URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0.4-1/libu2f-host.spec
SPRM URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0.4-1/libu2f-host-0.0.4-1.fc21.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8927516

Could one of you review this, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #13 from Till Maas opensou...@till.name ---
some further remarks:
- COPYING should probably be marked as %license
- The manpage pattern should be: %{_mandir}/man1/u2f-host.1* - so it also works
when the man page is not compressed at all

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Till Maas opensou...@till.name changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #12 from Till Maas opensou...@till.name ---
There were several new releases:
https://developers.yubico.com/libu2f-host/Releases/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #10 from Andy Lutomirski l...@mit.edu ---
Spec URL: http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-4/libu2f-host.spec
SRPM URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-4/libu2f-host-0.0-4.fc20.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7994193

Updated for the Plug-up key.  Still waiting for a response from upstream
systemd :-/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #11 from Andy Lutomirski l...@mit.edu ---
This is now getting ridiculous.  When fixing the _udevrulesdir thing, I clearly
failed to redo the mock build, and I was missing BR: systemd.  Sorry!

Spec URL: http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-5/libu2f-host.spec
SRPM URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-5/libu2f-host-0.0-5.fc20.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7994304

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826

Finnbarr P. Murphy j321...@gmail.com changed:

   What|Removed |Added

 CC||j321...@gmail.com



--- Comment #9 from Finnbarr P. Murphy j321...@gmail.com ---
I downloaded and build the package on F21 Alpha.  Installed Google Chrome ver
38.0.2125.111 (64-bit).   Used Yubico FIDO U2K device for 2 factor user
authentication.  All worked as expected. Good work!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #8 from Andy Lutomirski l...@mit.edu ---
Adam, Patrick, are either of you planning on reviewing this?  The bug is still
unassigned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #4 from Adam Goode a...@spicenitz.org ---
I think you want to use the _udevrulesdir macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #5 from Andy Lutomirski l...@mit.edu ---
Will do for -3.  Want a new version now or later?

FWIW, I'm hoping to get rid of that udev rule entirely.  I send a patch to
systemd to handle U2F devices for real instead of trying to list all
vendor/product combinations:

http://lists.freedesktop.org/archives/systemd-devel/2014-October/024667.html

If that patch is rejected, then I'll have to figure out what to with it.  In
the mean time, the rules in here should be more or less good enough, and I'll
update then as I learn about new devices.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #6 from Adam Goode a...@spicenitz.org ---
No rush. Solving it in systemd is a nice solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #7 from Andy Lutomirski l...@mit.edu ---
Spec URL: http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-3/libu2f-host.spec
SRPM URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-3/libu2f-host-0.0-3.fc20.src.rpm

The only changes are a bump to -3, using _udevrulesdir, and the addition of a
comment about the systemd patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #2 from Andy Lutomirski l...@mit.edu ---
I'm going to have to send a new version with a trivial update: libu2f-host
needs a udev rule to work correctly as non-root, and I didn't include it in
this version.  I post an update later today.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #3 from Andy Lutomirski l...@mit.edu ---
Spec URL: http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-2/libu2f-host.spec
SRPM URL:
http://web.mit.edu/luto/www/fedora/libu2f_host_0.0-2/libu2f-host-0.0-2.fc20.src.rpm
Description: libu2f-host provides a C library that implements the host-side of
the U2F protocol. There are APIs to talk to a U2F device and perform the U2F
Register and U2F Authenticate operations.
Fedora Account System Username: amluto
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7949379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1155826] Review Request: libu2f-host - Yubico Universal 2nd Factor (U2F) Host C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155826



--- Comment #1 from Andy Lutomirski l...@mit.edu ---
Created attachment 949602
  -- https://bugzilla.redhat.com/attachment.cgi?id=949602action=edit
Self-review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review