[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gdesklets-0.36.3-18.fc22 Resolution|--- |ERRATA Last Closed||2015-06-24 11:58:53 --- Comment #27 from Fedora Update System --- gdesklets-0.36.3-18.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Fedora Update System changed: What|Removed |Added Fixed In Version|gdesklets-0.36.3-18.fc22|gdesklets-0.36.3-18.fc21 --- Comment #28 from Fedora Update System --- gdesklets-0.36.3-18.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #26 from Fedora Update System --- gdesklets-0.36.3-18.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #25 from Fedora Update System --- gdesklets-0.36.3-18.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gdesklets-0.36.3-18.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #24 from Fedora Update System --- gdesklets-0.36.3-18.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gdesklets-0.36.3-18.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Sergio Monteiro Basto changed: What|Removed |Added Flags|fedora-cvs? | --- Comment #23 from Sergio Monteiro Basto --- https://fedorahosted.org/rel-eng/ticket/6194 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #22 from gil cattaneo --- (In reply to Sergio Monteiro Basto from comment #21) > I'm not sure that is solved by rel-eng ticket see > https://fedorahosted.org/rel-eng/ticket/6148 :) > > koji list-pkgs --show-blocked --package gdesklets > > gdesklets f20 sergiomb > gdesklets f21 orphan [BLOCKED] > gdesklets f21-beta orphan [BLOCKED] > gdesklets f22-Alphaorphan [BLOCKED] > gdesklets f22-Beta orphan [BLOCKED] this mean: you should open an rel-eng ticket as in previous comment#20 see: https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #21 from Sergio Monteiro Basto --- I'm not sure that is solved by rel-eng ticket see https://fedorahosted.org/rel-eng/ticket/6148 :) koji list-pkgs --show-blocked --package gdesklets gdesklets f20 sergiomb gdesklets f21 orphan [BLOCKED] gdesklets f21-beta orphan [BLOCKED] gdesklets f22-Alphaorphan [BLOCKED] gdesklets f22-Beta orphan [BLOCKED] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #20 from gil cattaneo --- sorry, i am not yet awake, i meant you have requested to *unlock* the package to the branch in question? see https://fedorahosted.org/rel-eng/ticket/5104 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #19 from gil cattaneo --- have request the package for the requested branch? example https://fedorahosted.org/rel-eng/ticket/5104 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Sergio Monteiro Basto changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #18 from Sergio Monteiro Basto --- Hi, I can't build it. Koji says: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10010324 open (arm04-builder07.arm.fedoraproject.org) -> FAILED: BuildError: package gdesklets is blocked for tag f23 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10010476 open (arm02-builder21.arm.fedoraproject.org) -> FAILED: BuildError: package gdesklets is blocked for tag f22-updates-candidate on https://koji.fedoraproject.org/koji/packageinfo?packageID=1828 we got in tags : Name Owner :Included? (...) f20sergiomb yes f21 orphan no f21-beta orphan no f22-Alpha orphan no f22-Beta orphan no Shouldn't all the owners be me ( sergiomb ) ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #17 from Jon Ciesla --- Complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #16 from Sergio Monteiro Basto --- Package Change Request == Package Name: gdesklets New Branches: f21 devel Owners: sergiomb I already have f22 approved with Request new branch in : https://admin.fedoraproject.org/pkgdb/package/gdesklets/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Sergio Monteiro Basto changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Sergio Monteiro Basto --- (In reply to gil cattaneo from comment #13) > INFO: enabled ccache > Mock Version: 1.2.9 > INFO: Mock Version: 1.2.9 > Traceback (most recent call last): > File "/usr/sbin/mock", line 831, in > main() BTW: mock-1.2.10-1.fc21 fix this https://admin.fedoraproject.org/updates/search/mock (In reply to gil cattaneo from comment #14) > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address > Please, you should report to upstream the problem I will report upstream and also I will report others patches left . > Please, correct the description section, now you use comical.appdata.xml ones > are there some problems with the description in the attached file? > fix also the summary "usually the same as the Comment value in the desktop > file" > as reported @ http://people.freedesktop.org/~hughsient/appdata/ Done > Approved Thanks Package Change Request == Package Name: gdesklets New Branches: f21 f22 devel Owners: sergiomb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from gil cattaneo --- NON blocking issues: gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/svg.c gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/x11.c gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Please, you should report to upstream the problem Please, correct the description section, now you use comical.appdata.xml ones are there some problems with the description in the attached file? fix also the summary "usually the same as the Comment value in the desktop file" as reported @ http://people.freedesktop.org/~hughsient/appdata/ Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518
--- Comment #13 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in gdesklets
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/gdesklets
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/gnome/48x48,
/usr/share/appdata, /usr/share/icons/gnome/48x48/mimetypes,
/usr/share/licenses, /usr/share/icons/gnome
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/gdesklets/Displays
(gdesklets-quote-of-the-day, gdesklets), /usr/share/gdesklets
(gdesklets-quote-of-the-day, gdesklets)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in gdesklets
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 122880 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be r
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #12 from gil cattaneo --- (In reply to gil cattaneo from comment #11) > (In reply to Sergio Monteiro Basto from comment #10) > > gdesklets.appdata.xml example , but I will update soon . > > Please, correct the description section, now you use comical.appdata.xml ones > are there some problems with the description in the attached file? fix also the summary "usually the same as the Comment value in the desktop file" as reported @ http://people.freedesktop.org/~hughsient/appdata/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #11 from gil cattaneo --- (In reply to Sergio Monteiro Basto from comment #10) > gdesklets.appdata.xml example , but I will update soon . Please, correct the description section, now you use comical.appdata.xml ones are there some problems with the description in the attached file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #10 from Sergio Monteiro Basto --- (In reply to gil cattaneo from comment #9) > Created attachment 1037068 [details] > gdesklets.appdata.xml example Thanks you already have a new version uploaded, I hadn't use yet gdesklets.appdata.xml example , but I will update soon . - Dropped desktop-file-validate. - Added AppData https://fedoraproject.org/wiki/Packaging:AppData Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #9 from gil cattaneo --- Created attachment 1037068 --> https://bugzilla.redhat.com/attachment.cgi?id=1037068&action=edit gdesklets.appdata.xml example -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518
--- Comment #8 from gil cattaneo ---
Issues:
https://fedoraproject.org/wiki/Packaging:AppData
"If a package contains a GUI application, then it SHOULD also install a
.appdata.xml file into %{_datadir}/appdata/. Installed .appdata.xml files MUST
follow the AppData specification page."
you should add a similar file, with the procedures reported in the above page
NOTE: i never used this software, please change "FIXME" with appropriate value
gdesklets
gdesklets.desktop
gDesklets
FIXME
https://launchpad.net/gdesklets
https://bugs.launchpad.net/gdesklets
FIXME
GPL-2.0+
BuildRequires: libappstream-glib
install -Dp %{SOURCE1} %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml
%endif
appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml
and request to upstream to integrate it in their distribution
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation
NON blocking issues:
gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Please, report to upstream the problem
desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
is unnecessary, cause desktop-file-install already validate the .desktop file
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #7 from Sergio Monteiro Basto --- - Add patch to fix obsoleted m4s. - Add desktop-database scriptlet and desktop-file-validate. - Fix License tag and License macro. - Spec clean up. - Fix mixed-use-of-spaces-and-tabs. Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518
--- Comment #6 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in gdesklets
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
IGNORE: already done
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
Please, fix
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
IGNORE: already done
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/gdesklets
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in gdesklets
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
Please, fix
= MUST items =
C/C++:
[?]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
Please, fix license field should be GPLv2+
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "GPL (v2 or later) (with incorrect
FSF address)", "Unknown or generated". 192 files have unknown license.
Detailed output of licensecheck in
/home/gil/1229518-gdesklets/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/gnome/48x48,
/usr/share/icons/gnome/48x48/mimetypes, /usr/share/icons/gnome
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/gdesklets/Displays
(gdesklets-quote-of-the-day, gdesklets), /usr/share/gdesklets
(gdesklets-quote-of-the-day, gdesklets)
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
Note: Especially check following dirs for bundled code:
/home/gil/1229518-gdesklets/upstream-
unpacked/Source0/gdesklets-0.36.3/Sensors/External
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[?]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 143360 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachm
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #5 from gil cattaneo --- an other issues: you must use %license macro for COPYING file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518
--- Comment #4 from gil cattaneo ---
seem there are some issues:
1. in install section unneeded rm -rf %{buildroot}
2. see https://fedoraproject.org/wiki/Packaging:AppData
"If a package contains a GUI application, then it SHOULD also install a
.appdata.xml file into %{_datadir}/appdata/. Installed .appdata.xml files MUST
follow the AppData specification page."
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? --- Comment #3 from gil cattaneo --- can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1228162 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 --- Comment #2 from Sergio Monteiro Basto --- Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm Summary : Architecture for desktop applets Description: 'gDesklets' provides an advanced architecture for desktop applets - tiny displays that sit on your desktop such as status meters, icon bars, weather sensors, news tickers. This package was orphan on F20 and retired on F21 , since it is maintained on https://launchpad.net/gdesklets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229518] Unretiring gdesklets
https://bugzilla.redhat.com/show_bug.cgi?id=1229518 Sergio Monteiro Basto changed: What|Removed |Added CC||package-review@lists.fedora ||project.org Component|gdesklets |Package Review Assignee|ser...@serjux.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
