[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #19 from Fedora Update System --- FEDORA-EPEL-2021-17576d21af has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #18 from Fedora Update System --- FEDORA-2021-e03a72ed74 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #17 from Fedora Update System --- FEDORA-2021-48e39bade3 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-27 00:16:21 --- Comment #16 from Fedora Update System --- FEDORA-2021-4ee51217e2 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #15 from Fedora Update System --- FEDORA-2021-e03a72ed74 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e03a72ed74 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e03a72ed74 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #13 from Fedora Update System --- FEDORA-2021-48e39bade3 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-48e39bade3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-48e39bade3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2021-17576d21af has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-17576d21af See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- FEDORA-2021-4ee51217e2 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4ee51217e2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4ee51217e2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2021-17576d21af has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-17576d21af -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #10 from Fedora Update System --- FEDORA-2021-e03a72ed74 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e03a72ed74 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #9 from Fedora Update System --- FEDORA-2021-48e39bade3 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-48e39bade3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #8 from Fedora Update System --- FEDORA-2021-4ee51217e2 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4ee51217e2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||disk-utilities-0-0.1.202103 ||17git2ec77a4.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #7 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/disk-utilities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #6 from Davide Cavalca --- Thanks! $ fedpkg request-repo disk-utilities 1938471 https://pagure.io/releng/fedora-scm-requests/issue/33042 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 Davide Cavalca changed: What|Removed |Added Summary|Review Request: |Review Request: |Disk-Utilities - Collection |disk-utilities - Collection |of utilities for ripping, |of utilities for ripping, |dumping, analysing, and |dumping, analysing, and |modifying disk images |modifying disk images -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: Disk-Utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #4 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/disk-utilities/disk-utilities.spec SRPM URL: https://dcavalca.fedorapeople.org/review/disk-utilities/disk-utilities-0-0.1.20210317git2ec77a4.fc35.src.rpm Changelog: - Rename to disk-utilities - Update build requires - Add COPYING to libs subpackage - Bump commit - Shorten summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: Disk-Utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #2 from Robert-André Mauchin 🐧 ---
- For a prerelease, the Release field should start at 0.1:
Release:0.1%{?dist}
- The code is written in C, not C++:
BuildRequires: gcc
- Consider lower casing the name. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming
-Consider bumping to the latest GIT commit with your changes instead of a
patch:
%global commit 12ec77a466801b45e8a89fbed820261c0ca4cf618
[…]
* Sat Jan 23 2021 Davide Cavalca -
0-1.20210317git12ec77a
- Please install the license file the lib subpackage as it can be installed
independently of the main package:
%files -n libdisk
%license COPYING
%{_libdir}/libdisk.so.0*
- The summary must be below 80 characters:
Disk-Utilities.x86_64: E: summary-too-long C Collection of utilities for
ripping, dumping, analysing, and modifying disk images
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[-]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "the Unlicense", "Unknown or generated". 190 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/Disk-Utilities/review-Disk-
Utilities/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named usi
[Bug 1938471] Review Request: Disk-Utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=63708698 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
