[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Kalev Lember changed: What|Removed |Added AssignedTo|ka...@smartlink.ee |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Robin Lee changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DUPLICATE Flag|fedora-review?, | |needinfo?(jonathanstef...@g | |mail.com) | Last Closed||2010-09-01 12:11:18 --- Comment #22 from Robin Lee 2010-09-01 12:11:18 EDT --- I take over this review request. *** This bug has been marked as a duplicate of bug 629324 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #21 from Kalev Lember 2010-08-28 09:57:52 EDT --- Jonathan, could you please respond? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #20 from Toshio Ernie Kuratomi 2010-08-17 01:53:30 EDT --- """ When naming packages for Fedora, the maintainer must use the dash '-' as the delimiter for name parts. The maintainer must NOT use an underscore '_', a plus '+', or a period '.' as a delimiter. There are a few exceptions to the no underscore '_' rule. [But no exceptions for the '+' or '.'] """ https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators If you think this should be changed, you can submit a draft to the packaging committee. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Chen Lei changed: What|Removed |Added CC||a.bad...@gmail.com --- Comment #19 from Chen Lei 2010-08-16 22:44:45 EDT --- Hi Toshio, Would you mind to help us to point out which name is suitable for this package, python-zc.buildout or python-zc-buildout? Currently, debian/ubuntu use python-zc.buildout, however some existed packages in fedora repo use python-zope-* as package names. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Kalev Lember changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #18 from Kalev Lember 2010-08-16 17:07:19 EDT --- Jonathan, could you address the issues pointed out by Chen and Robin? Setting fedora‑review flag back to "?". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Kalev Lember changed: What|Removed |Added Flag||needinfo?(jonathanstef...@g ||mail.com) --- Comment #17 from Kalev Lember 2010-08-09 12:35:02 EDT --- Jonathan, are you still interested in this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521707
--- Comment #16 from Robin Lee 2010-07-10 02:25:36
EDT ---
It is not acceptable that this package owns the directory %{python_sitelib}/zc/
!
We should decide a more sophisticated and uniform mechanism to deal with
namespaces. I will soon post a proposal to the python-devel mailing list.
And package name usually contains no '.', 'python-zc-buildout' is preferred.
This package requires 'python-setuptools'.
I also drafted a version of python-zc-buildout.spec:
http://fedorapeople.org/gitweb?p=cheeselee/public_git/zope-rpm.git;a=blob;f=python-zc-buildout/F-13/python-zc-buildout.spec;hb=master
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521707
Robin Lee changed:
What|Removed |Added
CC||robinlee.s...@gmail.com
--- Comment #15 from Robin Lee 2010-07-10 02:21:44
EDT ---
It is not acceptable that this package owns the directory
%{python_sitelib}/zc/{,/recipe/} !
We should decide a more sophisticated and uniform mechanism to deal with
namespaces. I will soon post a proposal to the python-devel mailing list.
And package name usually contains no '.', 'python-zc-buildout' is preferred.
This package requires 'python-setuptools'.
I also drafted a version of python-zc-buildout.spec:
http://fedorapeople.org/gitweb?p=cheeselee/public_git/zope-rpm.git;a=blob;f=python-zc-buildout/F-13/python-zc-buildout.spec;hb=master
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #14 from Kalev Lember 2010-07-09 15:01:09 EDT --- Jonathan, what's the status here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Rakesh Pandit changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|ka...@smartlink.ee --- Comment #13 from Rakesh Pandit 2010-06-21 03:22:26 EDT --- Fixed missing assigned to. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #12 from Chen Lei 2010-06-20 05:02:17 EDT --- I list all the dependecies of Zope2 in http://fedoraproject.org/wiki/Zope2 I also add some informations on your wiki page http://fedoraproject.org/wiki/SIGs/Zope, next we need to create some communication way e.g. mailist IRC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #11 from Chen Lei 2010-06-19 23:00:55 EDT --- (In reply to comment #5) > Hoping for some progress on this. Plone 4 utilizes zope 2.12.x which supports > python 2.6 so we can get this stack back into Fedora. However, a lot more > projects are utilizing zc.buildout. I've updated the package to the lastest > stable release. Zope2 is already packaged :) See http://cheeselee.fedorapeople.org/yum/zope/ Maybe you can work together with cheeselee after python2.7 is available in F14, some of those modules need patch to make it compatible with python2.7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #10 from Chen Lei 2010-06-19 21:32:58 EDT --- Note: Normally all xxx.yyy python should be renamed to python-xxx-xxx, because namespace for those modules are xxx/yyy See http://koji.fedoraproject.org/koji/packageinfo?packageID=8780 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #9 from Chen Lei 2010-06-19 21:30:12 EDT --- This package should renamed to python-zc-buildout before import to cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521707
Kalev Lember changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Kalev Lember 2010-06-19 20:37:35 EDT
---
Fedora review python-zc.buildout-1.4.3-2.fc13.src.rpm 2010-06-20
+ OK
! needs attention
(In reply to comment #7)
> python-zc.buildout.noarch: W: no-manual-page-for-binary buildout
> 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
> There is no upstream manpage and I'm not sure there should really be one.
Yes, I also think there's no real need for a man page. Even Debian (usually
very strict about man pages) doesn't have one for this package.
+ rpmlint warning can be ignored
+ The package is named according to the Package Naming Guidelines.
Naming Guildelines [1] say that a package must not use . as a separator,
but I think it's OK in this case:
- rpm / yum seems to handle it just fine
- there are already a few packages which have . in their names
(openoffice.org and java-1.6.0-openjdk for example)
- upstream uses . in package name
- debian also calls it python-zc.buildout
[1] http://fedoraproject.org/wiki/PackageNamingGuidelines#Separators
+ Spec file name matches the base package name
+ The package follows the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
n/a The package doesn't contain a separate license file and thus it's also not
in %doc
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
527cece8ca7ee087dc4e23360bbd9bcb zc.buildout-1.4.3.tar.gz
527cece8ca7ee087dc4e23360bbd9bcb Download/zc.buildout-1.4.3.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file handles locales properly
+ Package does not bundle copies of system libraries
n/a Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package contains code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #7 from Jonathan Steffan 2010-06-19 19:50:15 EDT --- python-zc.buildout.noarch: W: no-manual-page-for-binary buildout 2 packages and 0 specfiles checked; 0 errors, 1 warnings. SPEC URL: http://jsteffan.fedorapeople.org/SPECS/python-zc.buildout.spec SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/python-zc.buildout-1.4.3-2.fc13.src.rpm There is no upstream manpage and I'm not sure there should really be one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521707
Kalev Lember changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||ka...@smartlink.ee
Flag|needinfo? |fedora-review?
--- Comment #6 from Kalev Lember 2010-06-19 19:29:12 EDT
---
Taking for review.
I think "fixing" the spec to use %{__rm} doesn't add anything useful and if you
wish you should just revert back to using plain rm. There was a recent
discussion about the %__ macros in fedora-devel list and the consensus was that
they are useless.
Are the .txt files in site-packages/zc/buildout/ and
site-packages/zc.buildout-1.4.1-py2.6.egg-info/ needed? Perhaps they'd be more
useful in the standard docdir?
You could do something like this at the end of %install to move them to docdir:
mkdir _docdir
find $RPM_BUILD_ROOT%{python_sitelib}/ -name "*.txt" -exec echo mv {} _docdir/
\;
and then later:
%files
%doc _docdir/*
> # Remove CFLAGS=... for noarch packages (unneeded)
> CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
You can remove CFLAGS= as you commented yourself.
Current python guidelines [1] suggest to wrap the sitelib definition in an %if,
as it's not needed in F13 and up. But this is just nitpicking and no real need
to change it.
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif
[1] https://fedoraproject.org/wiki/Packaging:Python
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 --- Comment #5 from Jonathan Steffan 2010-06-19 17:45:09 EDT --- Hoping for some progress on this. Plone 4 utilizes zope 2.12.x which supports python 2.6 so we can get this stack back into Fedora. However, a lot more projects are utilizing zc.buildout. I've updated the package to the lastest stable release. SPEC URL: http://jsteffan.fedorapeople.org/SPECS/python-zc.buildout.spec SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/python-zc.buildout-1.4.3-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521707
Jonathan Steffan changed:
What|Removed |Added
Flag||needinfo?
--- Comment #4 from Jonathan Steffan 2010-04-10
19:28:11 EDT ---
Updated to fix rpmlint warnings. Updated License field. Updated to use %{__rm}
macro. The ZPL 2.1 license is not shipped with the upstream source.
http://www.zope.org/Resources/ZPL which is GPL compatible and is approved for
use with Fedora: http://fedoraproject.org/wiki/Licensing#Good_Licenses (see ZPL
2.1)
Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-zc.buildout.spec
SRPM URL:
http://jsteffan.fedorapeople.org/SRPMS/python-zc.buildout-1.4.1-1.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
