[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #19 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FumaFvWttn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
https://bugzilla.redhat.com/show_bug.cgi?id=717966 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eqGL6dckal&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
https://bugzilla.redhat.com/show_bug.cgi?id=717966 Ian McLeod changed: What|Removed |Added CC||imcl...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Ian McLeod --- Package Change Request == Package Name: python-psphere New Branches: el6 Owners: imcleod -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v2JLBrCQnU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #17 from Jon Ciesla 2011-09-24 11:28:15 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Chris Lalancette changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #16 from Chris Lalancette 2011-09-21 14:18:47 EDT --- Package Change Request == Package Name: python-psphere New Branches: f15 Owners: clalance InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Chris Lalancette changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-07-27 05:34:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #15 from Jon Ciesla 2011-07-14 19:38:44 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Chris Lalancette changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Chris Lalancette 2011-07-14 13:09:15 EDT --- New Package SCM Request === Package Name: python-psphere Short Description: vSphere SDK for Python Owners: clalance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #13 from Chris Lalancette 2011-07-14 13:08:31 EDT --- Thanks Mark. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Mark McLoughlin changed: What|Removed |Added AssignedTo|mar...@redhat.com |clala...@redhat.com Flag|fedora-review? |fedora-review+ --- Comment #12 from Mark McLoughlin 2011-07-14 12:56:36 EDT --- Awesome, looks perfect now! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #11 from Chris Lalancette 2011-07-14 11:14:34 EDT --- OK, the upstream maintainer responded. He: a) Changed the license to ASL 2.0, which I've updated in the SPEC and b) Done a formal release of psphere 0.1.4 upstream. Based on this, I took the tarball from his release and used that to generate a new package. It is available here: SPEC: http://people.redhat.com/clalance/python-psphere/python-psphere.spec SRPM: http://people.redhat.com/clalance/python-psphere/python-psphere-0.1.4-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Chris Lalancette changed: What|Removed |Added Blocks||721144 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #10 from Chris Lalancette 2011-07-12 13:24:02
EDT ---
(In reply to comment #8)
> > %{!?python_sitelib: %global python_sitelib %(python -c "from
> > distutils.sysconfig import get_python_lib; print get_python_lib()")}
>
> Not needed anymore:
>
> http://fedoraproject.org/wiki/Packaging:Python#Macros
Ah, I had no idea about that one. Fixed.
>
> > %dir %attr(0755, root, root) %{python_sitelib}/psphere
> > %{python_sitelib}/psphere/*
>
> A simple:
>
> %{python_sitelib}/psphere/
And fixed.
(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #3)
> > > - There is no 0.1 release of psphere yet, so we should either wait for a
> > > release or (uggh) get into:
> > >
> > >
> > > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
> >
> > This is the nastiest one here. When you run "python setup.py sdist" on the
> > hg
> > sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given
> > the
> > "Referencing_Source" link below, I feel like we should stick with that
> > version
> > number, even though there is no official upstream release.
>
> Nope, that doesn't cut it - upstream could release 0.1 some time in the future
> with newer code
>
> 0.1 as a version number is meaningless right now - it doesn't refer to a
> specific version of the code
>
> It sounds like you're in good contact with upstream - how about suggesting a
> release? That might be the simplest way of resolving it?
>
> Otherwise, it should be python-vsphere-0.1-0.1.42accc3ffe67hg
I've written to the upstream maintainer, I'll wait on his reply.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #9 from Mark McLoughlin 2011-07-12 13:03:07 EDT --- (In reply to comment #7) > (In reply to comment #3) > > - There is no 0.1 release of psphere yet, so we should either wait for a > > release or (uggh) get into: > > > > > > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease > > This is the nastiest one here. When you run "python setup.py sdist" on the hg > sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the > "Referencing_Source" link below, I feel like we should stick with that version > number, even though there is no official upstream release. Nope, that doesn't cut it - upstream could release 0.1 some time in the future with newer code 0.1 as a version number is meaningless right now - it doesn't refer to a specific version of the code It sounds like you're in good contact with upstream - how about suggesting a release? That might be the simplest way of resolving it? Otherwise, it should be python-vsphere-0.1-0.1.42accc3ffe67hg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #8 from Mark McLoughlin 2011-07-12 12:48:01 EDT
---
> %{!?python_sitelib: %global python_sitelib %(python -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib()")}
Not needed anymore:
http://fedoraproject.org/wiki/Packaging:Python#Macros
> %dir %attr(0755, root, root) %{python_sitelib}/psphere
> %{python_sitelib}/psphere/*
A simple:
%{python_sitelib}/psphere/
does the exact same. See:
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #7 from Chris Lalancette 2011-07-12 09:54:03
EDT ---
Thanks for the review, Mark.
(In reply to comment #3)
> Okay, first up ... rpmlint output:
>
> python-psphere.spec: W: invalid-url Source0:
> http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error
> 500: Internal Server Error
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
>
> python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere,
> sphere, spherule
> python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python
> python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v
> Sphere, sphere, spherule
> python-psphere.noarch: W: no-documentation
> python-psphere.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env
> 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
>
> What I think needs fixing:
>
> - There is no 0.1 release of psphere yet, so we should either wait for a
> release or (uggh) get into:
>
>
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
This is the nastiest one here. When you run "python setup.py sdist" on the hg
sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the
"Referencing_Source" link below, I feel like we should stick with that version
number, even though there is no official upstream release.
>
> - We need either a URL for the tarball created by upstream, or no
> URL at all and instructions on how to regenerate the tarball from
> a tag. See:
>
> http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source
Right, fixed this up according to the link above.
>
> - The non-executable-script error can be fixed using a variant of:
>
>
> http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
Stolen from your example SPEC, and fixed.
>
> What can be ignored:
>
> - Spelling warnings about vSphere, it's correct
>
> - no-documentation warning - none is included in the tarball
>
> - The licensing change; no need to wait for that, GPLv3 is perfectly
> fine for inclusion into Fedora
(In reply to comment #4)
> Okay, some more comments:
>
> - no need for the BuildRoot tag anymore
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Removed.
>
> - no need for %clean section anymore
> http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
Removed.
>
> - the description should be longer and end with a period. Can just take
>the "Welcome" text from the website
Fixed.
>
> - the -n argument to %setup is redundant; you're using the default value
Fixed.
>
> - no need for Prefix tag
Removed.
>
> - we should own the /usr/lib/python2.7/site-packages/psphere/ directory
Fixed.
>
> - recommendation is to avoid using INSTALLED_FILES
> http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
> http://fedoraproject.org/wiki/Packaging:Python_Eggs
Fixed.
>
> - use the %{__python} macro
Fixed.
>
> - URL: instead of Url:
Fixed.
>
> - should pass --skip-build argument to setuptools install
Fixed.
>
> - I'd avoid the optimize argument to setuptools install, no reason to
>override the default
Fixed.
I've uploaded a new SPEC:
http://people.redhat.com/clalance/python-psphere/python-psphere.spec and new
SRPM:
http://people.redhat.com/clalance/python-psphere/python-psphere-0.1-4.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #5 from Mark McLoughlin 2011-07-12 09:17:41 EDT --- Created attachment 512426 --> https://bugzilla.redhat.com/attachment.cgi?id=512426 new spec Here's a new spec with all the comments above resolved if you want to use it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #6 from Mark McLoughlin 2011-07-12 09:19:04 EDT --- If you use the new spec, the only thing that you still need is an upstream release - either a released tarball, or a tag in hg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #4 from Mark McLoughlin 2011-07-12 09:15:01 EDT
---
Okay, some more comments:
- no need for the BuildRoot tag anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
- no need for %clean section anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
- the description should be longer and end with a period. Can just take
the "Welcome" text from the website
- the -n argument to %setup is redundant; you're using the default value
- no need for Prefix tag
- we should own the /usr/lib/python2.7/site-packages/psphere/ directory
- recommendation is to avoid using INSTALLED_FILES
http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
http://fedoraproject.org/wiki/Packaging:Python_Eggs
- use the %{__python} macro
- URL: instead of Url:
- should pass --skip-build argument to setuptools install
- I'd avoid the optimize argument to setuptools install, no reason to
override the default
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Mark McLoughlin changed: What|Removed |Added Status|NEW |ASSIGNED CC||mar...@redhat.com AssignedTo|nob...@fedoraproject.org|mar...@redhat.com Flag||fedora-review? --- Comment #3 from Mark McLoughlin 2011-07-12 09:12:33 EDT --- Okay, first up ... rpmlint output: python-psphere.spec: W: invalid-url Source0: http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error 500: Internal Server Error 0 packages and 1 specfiles checked; 0 errors, 1 warnings. python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: no-documentation python-psphere.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 4 warnings. What I think needs fixing: - There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease - We need either a URL for the tarball created by upstream, or no URL at all and instructions on how to regenerate the tarball from a tag. See: http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source - The non-executable-script error can be fixed using a variant of: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries What can be ignored: - Spelling warnings about vSphere, it's correct - no-documentation warning - none is included in the tarball - The licensing change; no need to wait for that, GPLv3 is perfectly fine for inclusion into Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #2 from Chris Lalancette 2011-07-12 08:30:18 EDT --- OK, we've sorted the license out for this package with the imagefactory. This package will stay as GPLv3 for now, and the imagefactory as ASLv2, which is a valid combination. So we should be good to go with the package review here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #1 from Chris Lalancette 2011-07-05 14:47:26 EDT --- We are still sorting out the license a bit with upstream. The problem is that the upstream sources are GPLv3, but the program that wants to use them (imagefactory) is GPLv2. We are discussing the best path forward with upstream, and I'll update the package once we have sorted it out. Chris Lalancette -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
