[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Michel Alexandre Salim mic...@michel-slm.name changed: What|Removed |Added CC||hicham.haou...@gmail.com Flags||needinfo?(hicham.haouari@gm ||ail.com) --- Comment #16 from Michel Alexandre Salim mic...@michel-slm.name --- Hicham, ping? Let me know if you have objection to an EPEL7 branch, and if you'd like to comaintain. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Hicham HAOUARI hicham.haou...@gmail.com changed: What|Removed |Added Flags|needinfo?(hicham.haouari@gm | |ail.com)| --- Comment #17 from Hicham HAOUARI hicham.haou...@gmail.com --- Hi, Sorry for this late response. I don't have any objection concerning this. You have my approval. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Michel Alexandre Salim mic...@michel-slm.name changed: What|Removed |Added Flags||fedora-cvs? --- Comment #18 from Michel Alexandre Salim mic...@michel-slm.name --- Thanks Hicham! Package Change Request == Package Name: cryptkeeper New Branches: epel7 Owners: salimma -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #13 from Michel Alexandre Salim mic...@michel-slm.name --- *** Bug 1098472 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Michel Alexandre Salim mic...@michel-slm.name changed: What|Removed |Added CC||mic...@michel-slm.name Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Michel Alexandre Salim mic...@michel-slm.name --- Package Change Request == Package Name: cryptkeeper New Branches: epel7 Owners: salimma -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Comments from the primary maintainer? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #15 from Michel Alexandre Salim mic...@michel-slm.name --- @ Jon: no response to my branch request from several months ago in the bug report I marked as a duplicate of this. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-08-02 20:56:28 EDT --- cryptkeeper-0.9.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|cryptkeeper-0.9.5-1.fc14|cryptkeeper-0.9.5-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-08-02 21:12:52 EDT --- cryptkeeper-0.9.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|cryptkeeper-0.9.5-1.fc13|cryptkeeper-0.9.5-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-08-01 15:23:05 EDT --- cryptkeeper-0.9.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-07-30 16:34:14 EDT --- GIT done (by process-cvs-requests.py). with f14 branch added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-07-30 17:18:54 EDT --- cryptkeeper-0.9.5-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/cryptkeeper-0.9.5-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-07-30 17:18:26 EDT --- cryptkeeper-0.9.5-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/cryptkeeper-0.9.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-07-30 17:19:00 EDT --- cryptkeeper-0.9.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/cryptkeeper-0.9.5-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@rasmil.dk AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk Flag||fedora-review? --- Comment #1 from Tim Lauridsen t...@rasmil.dk 2010-07-28 04:26:52 EDT --- I will review this none -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617986
--- Comment #2 from Tim Lauridsen t...@rasmil.dk 2010-07-28 04:31:25 EDT ---
Key:
[P] Pass
[F] Fail See [n]
[-] Not applicable
[?] Questions (see comments)
[P] MUST: rpmlint must be run on every package. The output should be
posted in the review.
$ rpmlint cryptkeeper-0.9.5-1.fc13.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ~/rpmbuild/RPMS/x86_64/cryptkeeper-0.9.5-1.fc13.x86_64.rpm
cryptkeeper.x86_64: W: unstripped-binary-or-object /usr/bin/cryptkeeper
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[P] MUST: The package must be named according to the Package Naming
Guidelines.
[P] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption.
[P] MUST: The package must meet the Packaging Guidelines.
[P] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines.
GPLv3
[P] MUST: The License field in the package spec file must match
the actual license.
GPLv3
[P] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[P] MUST: The spec file must be written in American English.
[P] MUST: The spec file for the package MUST be legible.
[P] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
d02918b2058854177d2f59b837c2743f cryptkeeper-0.9.5.tar.gz (upstream)
d02918b2058854177d2f59b837c2743f cryptkeeper-0.9.5.tar.gz (srpm)
[P] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture.
[-] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec
in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be
placed in a comment, next to the corresponding ExcludeArch line.
[P] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the
Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
[P] MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
forbidden.
[-] MUST: Every binary RPM package (or sub package) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[-] MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package.
Without this, use of Prefix: /usr is considered a blocker.
[P] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory. Refer to the Guidelines for examples.
[P] MUST: A package must not contain any duplicate files in the %files
listing.
[P] MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section
must include a %defattr(...) line.
[P] MUST: The %clean section is not required for F-13 and above. Each package
for F-12 and below (or EPEL) MUST have a %clean section, which contains
rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[P] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
[P] MUST: The package must contain code, or permissible content.
This is described in detail in the code vs. content section
of Packaging Guidelines.
[-] MUST: Large documentation files should go in a -doc sub package.
(The definition of large is left up to the packager's best judgement,
but is not restricted to size. Large can refer to either size or quantity)
[P] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program
must run properly if it is not present.
[-] MUST: Header files must be in a -devel package.
[-] MUST: Static libraries
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 --- Comment #3 from Hicham HAOUARI hicham.haou...@gmail.com 2010-07-28 09:18:30 EDT --- Thanks Tim for reviewing this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617986] Review Request: cryptkeeper - A Linux system tray applet that manages EncFS encrypted folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617986 Hicham HAOUARI hicham.haou...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
