[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 Michal Ambroz changed: What|Removed |Added Alias|libemu | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 --- Comment #17 from Fedora Update System --- libemu-0.2.0-8.20130410gitab48695.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-27aaee2a9c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 --- Comment #18 from Fedora Update System --- libemu-0.2.0-8.20130410gitab48695.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ad1355662c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 --- Comment #19 from Fedora Update System --- libemu-0.2.0-8.20130410gitab48695.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-42ed2dfa4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation
https://bugzilla.redhat.com/show_bug.cgi?id=1559711 --- Comment #20 from Fedora Update System --- libemu-0.2.0-8.20130410gitab48695.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-6e774e5bc6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563925] New: Review Request: ghc-cabal-helper - Simple interface to some of Cabal' s configuration state, mainly used by ghc-mod
https://bugzilla.redhat.com/show_bug.cgi?id=1563925 Bug ID: 1563925 Summary: Review Request: ghc-cabal-helper - Simple interface to some of Cabal's configuration state, mainly used by ghc-mod Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://qulogic.fedorapeople.org//ghc-cabal-helper.spec SRPM URL: https://qulogic.fedorapeople.org//ghc-cabal-helper-0.8.0.2-1.fc27.src.rpm Description: Cabal's little helper provides access to build information gathered by 'cabal' when configuring a project. Specifically we're interested in retrieving enough information to bring up a compiler session, using the GHC API, which is similar to running 'cabal repl' in a project. While simple in principle this is complicated by the fact that the information Cabal writes to disk is in an unstable format and only really accessible through the Cabal API itself. Since we do not want to bind the user of a development tool which utilises this library to a specific version of Cabal we compile the code which interfaces with the Cabal library's API on the user's machine, at runtime, against whichever version of Cabal was used to write the on disk information for a given project. If this version of Cabal is not available on the users machine anymore, which is fairly likely since cabal-install is usually linked statically, we have support for compiling the Cabal library also. In this case the library is installed into a private, isolated, package database in '$XDG_CACHE_HOME/cabal-helper' so as to not interfere with the user's package database. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563925] Review Request: ghc-cabal-helper - Simple interface to some of Cabal' s configuration state, mainly used by ghc-mod
https://bugzilla.redhat.com/show_bug.cgi?id=1563925 --- Comment #1 from Elliott Sales de Andrade --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26173883 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563942] New: Review Request: rubygem-rspec-collection_matchers - Collection cardinality matchers
https://bugzilla.redhat.com/show_bug.cgi?id=1563942 Bug ID: 1563942 Summary: Review Request: rubygem-rspec-collection_matchers - Collection cardinality matchers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pval...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://pvalena.fedorapeople.org/gems/rubygem-rspec-collection_matchers.spec SRPM URL: https://pvalena.fedorapeople.org/gems/rubygem-rspec-collection_matchers-1.1.3-1.fc29.src.rpm Description: Collection cardinality matchers, extracted from rspec-expectations. Fedora Account System Username: pvalena Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26174019 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563831] Review Request: qspec - GUI testing library for Qt desktop applications
https://bugzilla.redhat.com/show_bug.cgi?id=1563831
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Fix your %changelog entry:
* Wed Apr 4 2018 Raphael Groner -
0.2-1.20160909gitd5878c9
- Initial package
- Missing %{?_isa} in the -devel subpackage Requires:
Requires: %{name}%{?_isa} = %{version}-%{release}
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "GPL (v2 or later)", "Unknown or generated".
34 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/qspec/review-qspec/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/include/qt5
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qspec-
devel
[x]: Package functions as described.
[x]: Latest
[Bug 1563839] Review Request: nodejs-conventional-changelog-express - A conventional-changelog express preset
https://bugzilla.redhat.com/show_bug.cgi?id=1563839 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - Latest version packaged - License ok - Builds in Mock - No rpmlint errors - Conforms to the Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563204] Review Request: rust-tokio-timer - Timer facilities for Tokio
https://bugzilla.redhat.com/show_bug.cgi?id=1563204 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-04-05 02:52:09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563611] Review Request: perl-Path-Tiny-Rule - Path::Iterator:: Rule subclass that returns Path::Tiny objects
https://bugzilla.redhat.com/show_bug.cgi?id=1563611 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Path-Tiny-Rule-0.01-1. ||fc29 Resolution|--- |RAWHIDE Last Closed||2018-04-05 02:52:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1563843] Review Request: nodejs-conventional-changelog-jquery - A conventional-changelog jquery preset
https://bugzilla.redhat.com/show_bug.cgi?id=1563843 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - Latest version packaged - License ok - Builds in Mock - No rpmlint errors - Conforms to the Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
