[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.1-42-gd0c487d4
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via d0c487d4dcc6fec6f4bd8e1cefa1de9ffbe0e460 (commit) via 0a25548cd0910f66dea2dfab21f75a6d15366d64 (commit) via 21af79860403f9120d2c0412a95ec97d06368e11 (commit) via c3852ff42569542b787d9e49289f5358ad22f900 (commit) via e54617c7d554e0c14c039432b5f7bef66e43769c (commit) via d626a17ef94d79975ff17d04250152ea46aaade3 (commit) via 2856a7dea3c0d4584e126b5ca5957e13e23f83d1 (commit) via 2e32d51a262fef398a94a17c0a0d4ff3233990b5 (commit) via 75bf8e887cd9fe0f6ba1eb2b6554dbfbcda0294a (commit) via 0965023fc57495ca819127eee1d7e881e1ed7c3c (commit) from acaed30e243ff139b5549fd51dc3cb5472415b0a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit d0c487d4dcc6fec6f4bd8e1cefa1de9ffbe0e460 Author: morganamilo Date: Sun Jan 26 07:01:42 2020 + Docs docs docs libalpm: move docs from .c files into alpm.h And fix/expand some along the way. Signed-off-by: Allan McRae commit 0a25548cd0910f66dea2dfab21f75a6d15366d64 Author: morganamilo Date: Thu Jan 23 06:38:35 2020 + libalpm: fix alpm_option_set_assumeinstalled It looks like this function has never actually worked. The current list is never set to NULL after being freed. So the new deps were just appended to the already freed list, leading to a segfault. Signed-off-by: Allan McRae commit 21af79860403f9120d2c0412a95ec97d06368e11 Author: Allan McRae Date: Thu Jan 23 12:14:14 2020 +1000 makepkg: add CRC checksums and set these to be the default Checksums arrays should be filled with values provided by upstream. We currently have md5 set as an unsecure default, and are constantly asked to change it to sha2. However, just changing the default to a stronger checksum gives the user the impression that "makepkg -g" checksums are perfect. Instead, change the default checksum to a CRC, to make it clear that any checksum generated purely by "makepkg -g" is not ideal. Signed-off-by: Allan McRae commit c3852ff42569542b787d9e49289f5358ad22f900 Author: Allan McRae Date: Thu Jan 23 12:04:28 2020 +1000 Note that checksums from "makepkg -g" are not ideal Generating checksums with "makepkg -g" only determines that the user of a PKGBUILD has the same file as the packager (assuming no collision). This means an upstream source could be maliciously changed and passed on as valid by a PKGBUILD. To avoid this, it is essential that any checksums used in a PKGBUILD are as provided by upstream. Signed-off-by: Allan McRae commit e54617c7d554e0c14c039432b5f7bef66e43769c Author: Allan McRae Date: Thu Jan 23 10:47:02 2020 +1000 Fix "pacman -U " operations Commit e6a6d307 detected complete part files by comparing a payload's max_size to initial_size. However, these values are also equal when we use pacman -U on a URL as max_size is set to 0 in that case. Add a further condition to avoid that. Signed-off-by: Allan McRae commit d626a17ef94d79975ff17d04250152ea46aaade3 Author: Eli Schwartz Date: Thu Jan 16 12:27:34 2020 -0500 makepkg: make per-package files containing '$pkgname' consistently work Extracting function variables containing arbitrarily scoped variables of arbitrary nature is a disaster, but let's at least cover the common case of using the actual '$pkgname' in an install/changelog file. It's the odd case of actually being basically justified use of disambiguating between the same variable used in multiple different split packages... and also, --printsrcinfo already uses and overwrites the variable 'pkgname' in pkgbuild_extract_to_srcinfo, so this "works" in .SRCINFO but doesn't work in .src.tar.gz It doesn't work in lint_pkgbuild either, but in that case the problem is being too permissive, not too restrictive -- we might end up checking the same file twice, and printing that it is missing twice. Fixes FS#64932 Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit 2856a7dea3c0d4584e126b5ca5957e13e23f83d1 Author: Allan McRae Date: Sun Jan 19 09:30:54 2020 +1000 Increase maximum database size We previously has the maximum database size as 25MB. This was set in the days before repos had as many packages as they do now, and before we started distributing files databases. Increase this limit to 128MB. Signed-off-by: Allan McRae commit
Re: [pacman-dev] [PATCH 2/2] Docs docs docs and more docs
On 26/1/20 5:01 pm, morganamilo wrote: > Write docs for every public alpm member and expand on the existing > documentation for other members. > > --- > > The entire .h file has basically been restructed. The best way to see > the end result is either to read the generated man pages or enabled html > and view the generated html. > > Also note alpm_list is still not documented. Awesome work! Great that someone is taking this on. Here are my comments... Often with little context, but you can search for what I have left. + + * If the database is already preasant in the dbpath then it will be usable. Otherwise, present + * the database needs to be downloaded using \link alpm_db_update \endlink. Even if the s/. E/, e/ + /** Permmision denied */ Typo + /** Handle should be null */ ALPM_ERR_HANDLE_NULL, + /** Handle should not be null */ ALPM_ERR_HANDLE_NOT_NULL, I think these comments are switched + /** Database should not be null */ ALPM_ERR_DB_NULL, + /** Database should be null */ ALPM_ERR_DB_NOT_NULL, And again + /** Fauked to write to the database */ Failed. + /** Fauked to remove entry from database */ Failed + /** A transaction has not been initialized */ ALPM_ERR_TRANS_NULL, + /** A transaction has not been initialized */ ALPM_ERR_TRANS_NOT_INITIALIZED, Distinguish these + /** Package is in ignorepkg */ ALPM_ERR_PKG_IGNORED, Or --ignore was used. Just "Package is ignored" + /** Files conflict. */ ALPM_ERR_FILE_CONFLICTS, Only one with trailing fullstop. + /** A character representing the encryption algorithm used by the public key Double space. + /** The amount of results in the array */ The number of + /** The conflict results with a another target in the transaction */ The conflict is with another ... + /** A hash of the name, used to speed up dependnecy checks */ Typo + /** The name of the package that also owns the file if there is one*/ Space before comment end. +/** When a hook should be ran */ run (?) +/** An event that may reprisent any event */ Typo +/** A pacnew file was created */ A .pacnew file ... +/** A pacsace file was created */ A .pacsave file ... +/** pre/post transaction hooks are to be ran */ run + /** Type of event it's always safe to access this. */ Type of event. It is always... + /** The any event type. It's always safe to access this. */ It is + /** An optdept was remove */ optdep ... removed + /** A pacnew file was created */ .pacnew + /** A pacsave file was created */ .pacsave + /** Pre/post transaction hooks are being ran */ Run + /** The type of question. It's always safe to access this. */ It is + /** A question that can represent any question. +* It's always safe to access this. */ It is + /** Package Integrity checking */ lower case i + * @param howmany the total amount of items in the action total number of + * many libalpm will produce log output. Additionally any calls to \link alpm_logaction many libalpm will + * @brief Libalpm option getters and setters getter/accessor - or is that too C++? +/**Returns the callback used for operation progress. Space after /** + * Hooks and scriptlets will also be run in a chroot to ensure they behave correctly in a chroot at this directory + * matter if the lockfile is actually presant on disk. Typo +/** Gets the currently configured cachedirs, Inconsistent trailing , + * @param cachedirs a char* list of cachdirs. The list will be duped and duplicated +/** Gets the currently configured overwritable files, Comma + * @param globs a char* list of overwritable file globs. The list will be duped and Duplicated + * @return the path to libalpms's GnuPG home directory s's + * The list will be duped and the original will still need to be freed by the caller. duplicated + * @return 0 is the path matches a glob, negative if there is no match and + * positive is the match was inverted double space. Also "inverted"? + * The list will be duped and the original will still need to be freed by the caller. duplicated + * @return 0 is the path matches a glob, negative if there is no match and + * positive is the match was inverted As above. + * The list will be duped and the original will still need to be freed by the caller. duplicated + * The list will be duped and the original will still need to be freed by the caller. Duplicated +/** Gets the list of dependencies that are assumed to be met s/dependencies/packages +/** Add a depend to the assumed installed list s/dependencies/packages +/** Sets the list of dependnecies that are assumed to be met packages that are assumed to be installed +/** @name Accessors for check space. I know this is literally called "CheckSpace", but can we be more
Re: [pacman-dev] [PATCH 2/2] Docs docs docs and more docs
On 26/1/20 5:01 pm, morganamilo wrote: > Write docs for every public alpm member and expand on the existing > documentation for other members. > > --- > > The entire .h file has basically been restructed. The best way to see > the end result is either to read the generated man pages or enabled html > and view the generated html. > > Also note alpm_list is still not documented. I have not gone through all the content yet, but here is a few things I noticed when apply and building docs: Applying: Docs docs docs and more docs .git/rebase-apply/patch:220: trailing whitespace. /** Returns the current error code from the handle. .git/rebase-apply/patch:683: trailing whitespace. /** A database is missing .git/rebase-apply/patch:760: trailing whitespace. /** Event callback. .git/rebase-apply/patch:1010: trailing whitespace. /** Sets the callback used for logging. .git/rebase-apply/patch:1023: trailing whitespace. /** Returns the callback used to report download progress. warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. /home/allan/arch/code/pacman/lib/libalpm/alpm_list.h:40: warning: group alpm_list: ignoring title "ALPM List" that does not match old title "List Functions" /home/allan/arch/code/pacman/lib/libalpm/alpm.h:1128: warning: Found unknown command '\parama' /home/allan/arch/code/pacman/lib/libalpm/alpm.h:1597: warning: unable to resolve link to 'alpm_siglevel_t' for \link command (not sure if that last one is due to this patch) Looks like our Doxyfile.in could be updated. Probably could restrict the files it makes documentation for if everything is going to alpm.h and alpm_list.h. > +/** > + * @file alpm.h > + * @author Pacman Development Team > + * @date 26 Jan 2020 > + * @brief Arch Linux Package Manager Library > + * > + * bork > + */ > + Can we get rid of the date? It is like to become outdated with the next patch... Also, bork? Allan
