date:20170613

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #162

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #155

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #154

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

Re: [pgadmin-hackers] PG Admin 4

2017-06-13 Thread Dave Page

Hi

On Tue, Jun 13, 2017 at 3:09 AM, Matt Owen  wrote:

> Hi
>
>
>
> PGADMIN4 looks great –
>

Thanks!


> however Is there a way to disable the dashboard stuff – the “remove panel”
> option doesn’t seem to work that we can see (you can float it but not close
> it).  We are accessing an Amazon RDS a long way away and its quite slow and
> the server status refreshing function we suspect is slowing things down
>
> Could be doing something wrong – but couldn’t seem to find it.
>

You cannot remove the dashboard panel, but if you go to File -> Preferences
-> Dashboard -> Graphs, you can adjust the refresh intervals to very high
values to work around the issue.


>
>
>
>
>
>
>
>
> Regards
>
>
>
> Matt
>
>
>
>
>
>
>
>
>
> Matt Owen | Principal Consultant | Theta
>
>
> [image: Theta Logo]
>
>
>
> Level 2, Theta House, 8-10 Beresford Square, Auckland Central 1010, NZ
>
> M. +64274394930 <+64%20274%20394%20930>
>
> matt.o...@theta.co.nz | theta.co.nz 
>
>
> [image: FaceBook Logo]   [image:
> Twitter Logo]   [image: LinkedIn Logo]
> 
>
>
> --
>
> This information is intended for the addressee only. It may contain
> confidential and legally privileged information. If you are not the
> intended recipient, please reply to advise the sender and do not disclose,
> copy or redistribute this document or any information contained herein.
>
> Please consider the environment before printing this email.
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Fix the fix for RM2324.

2017-06-13 Thread Dave Page

Fix the fix for RM2324.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=16a15bf9344ed9938cade6eb7090cd7149c4b550
Author: Khushboo Vashi 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py  | 18 +++---
.../databases/schemas/tables/column/__init__.py   | 19 +++
.../servers/databases/schemas/types/__init__.py   | 17 ++---
3 files changed, 32 insertions(+), 22 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-13 Thread Dave Page

Thanks, applied.

On Tue, Jun 13, 2017 at 4:45 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> On Mon, Jun 12, 2017 at 8:24 PM, Dave Page  wrote:
>
>> Hi Khushboo,
>>
>> Looks like this patch broke the regressions tests :-(. Can you take a
>> look ASAP please?
>>
>> please find the attached fix. However I didn't get any error while
> running regression tests.
>
>> Thanks!
>>
>> 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
>> 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
>> Traceback (most recent call last):
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 2000, in __call__
>> return self.wsgi_app(environ, start_response)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1991, in wsgi_app
>> response = self.make_response(self.handle_exception(e))
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1567, in handle_exception
>> reraise(exc_type, exc_value, tb)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1988, in wsgi_app
>> response = self.full_dispatch_request()
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
>> rv = self.handle_user_exception(e)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
>> reraise(exc_type, exc_value, tb)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
>> rv = self.dispatch_request()
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1625, in dispatch_request
>> return self.view_functions[rule.endpoint](**req.view_args)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/views.py", line 84, in view
>> return self.dispatch_request(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
>> line 235, in dispatch_request
>> return method(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 315, in wrap
>> return f(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 2555, in sql
>> data = self._formatter(did, scid, tid, data)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 1081, in
>> _formatter
>> data = self._columns_formatter(tid, data)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 663, in
>> _columns_formatter
>> column['attlen'] = matchObj.group(1)
>> AttributeError: 'NoneType' object has no attribute 'group'
>>
>>
>> On Mon, Jun 12, 2017 at 12:49 PM, Dave Page  wrote:
>>
>>> Thanks, applied.
>>>
>>> On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached updated patch.

 Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
 Table, Column, Foreign Table and Type node.

 Regarding  the review comment given by Dave (Also, I there should be a
 space between the , and value in the_geom geometry(MultiPolygon,3310).),
 won't be fixed as this format is returned by format_type() function itself.

 As per the conversation with Dave, I have logged RM #2473
  to add support for
 PostGIS Datatypes.

 Thanks,
 Khushboo

 On Tue, Jun 6, 2017 at 6:49 PM, Dave Page  wrote:

>
>
> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On 6 Jun 2017 18:36, "Dave Page"  wrote:
>>
>>
>>
>> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On 6 Jun 2017 17:42, "Dave Page"  wrote:
>>>
>>> Hi
>>>
>>> The table and column dialogues seem to have related problems. For
>>> example, the table dialogue shows the length of the geometry field in 
>>> the
>>> test case as 847,380, whilst the column dialogue shows no length at all.
>>>
>>> What should be there in length and precision fields in this case?
>>>
>>
>> I have no idea :-). What did pgAdmin 3 do here? I assume there's some
>> way to decode the typm

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #161

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #166

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #160

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] pgAdmin 4 commit: Initial re-vamp of the History tab.

2017-06-13 Thread Dave Page

Initial re-vamp of the History tab.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1208206bc0eca2d135469258e8a209b983e668be
Author: Shruti B Iyer 

Modified Files
--
web/.eslintrc.js   |   7 +-
web/karma.conf.js  |   2 +-
web/package.json   |   6 +
.../feature_tests/query_tool_journey_test.py   | 111 +
.../xss_checks_pgadmin_debugger_test.py|   2 +-
.../static/js/history/history_collection.js|  34 
web/pgadmin/static/js/history/index.js |  14 ++
web/pgadmin/static/jsx/components.jsx  |   2 +
web/pgadmin/static/jsx/history/query_history.jsx   |  49 ++
.../static/jsx/history/query_history_entry.jsx |  93 +++
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 179 -
web/pgadmin/utils/javascript/javascript_bundler.py |   2 +-
.../javascript/tests/test_javascript_bundler.py|   4 +-
web/regression/feature_utils/app_starter.py|   2 +
web/regression/feature_utils/pgadmin_page.py   |  28 ++--
.../javascript/check_node_visibility_spec.js   |  32 
.../javascript/check_node_visiblity_spec.js|  32 
.../javascript/history/history_collection_spec.js  |  83 ++
.../history/query_history_entry_spec.jsx   |  50 ++
.../javascript/history/query_history_spec.jsx  | 103 
web/regression/python_test_utils/test_utils.py |   2 +
web/webpack.config.js  |  11 +-
web/webpack.test.config.js |  10 +-
web/yarn.lock  |  79 -
24 files changed, 726 insertions(+), 211 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page

Hi

On Mon, Jun 12, 2017 at 7:22 PM, Shruti B Iyer  wrote:
> Hi Dave,
>
> We regenerated the patch to add new tasks to package.json to compile react
> code for development and to not minimize it. This should fix the error you
> captured in the screenshot.
>
> The new task to lint and bundle everything for development is:
> yarn run bundle:dev
>
> The new task only bundle everything is:
> yarn run webpacker:dev
>
> We also changed the task test:feature to bundle without optimization before
> we start the tests.
>
> When we ran these commands in our machine, they did not display any error.
> Is it possible that you forgot to run yarn install before running the
> webpacker task? We are asking this because the errors look like missing node
> packages.

I did run an install, yes. This patch does work though, so applied - thanks!

Could you answer my earlier question about the need for the delay in
app_starter.py please?

Thanks.

> On Mon, Jun 12, 2017 at 12:15 PM Dave Page  wrote:
>>
>> To add to that; running the JS tests gives:
>>
>> ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx 13:21-46
>>
>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
>> Module not found: Error: Can't resolve 'immutability-helper' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>>
>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
>> Module not found: Error: Can't resolve 'moment' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>>
>> ERROR in ./regression/javascript/history/query_history_spec.jsx
>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>>  @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
>> webpack: Failed to compile.
>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>>   Error: Cannot find module "immutability-helper"
>>   at regression/javascript/history/query_history_entry_spec.jsx:30705
>>
>>
>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>>   Error: Cannot find module "immutability-helper"
>>   at regression/javascript/history/query_history_spec.jsx:30705
>>
>>
>> error Command failed with exit code 1.
>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>> this command.
>> error Command failed with exit code 1.
>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>> this command.
>>
>>
>> Also, while I think of it, why the addition of the delay to
>> app_starter.py?
>>
>>
>> On Mon, Jun 12, 2017 at 5:12 PM, Dave Page  wrote:
>> > Hi,
>> >
>> > So 01 and 02 are now committed :-).
>> >
>> > 03 has a couple of problems though (likely the same):
>> >
>> > - Running the webpacker results in:
>> >
>> > (pgadmin4)piranha:web dpage$ yarn run webpacker
>> > yarn run v0.24.4
>> > $ yarn run webpack -- --optimize-minimize --config webpack.config.js
>> > yarn run v0.24.4
>> > $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
>> > --optimize-minimize --config webpack.config.js
>> > (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
>> > non-string value which can be problematic, see
>> > https://github.com/webpack/loader-utils/issues/56
>> > parseQuery() will be replaced with getOptions() in the next major
>> > version of loader-utils.
>> > Hash: a5e75aa70eb6b09bdb78
>> > Version: webpack 2.3.3
>> > Time: 3983ms
>> >  Asset Size  Chunks Chunk Names
>> > reactComponents.js   222 kB   0  [emitted]  reactComponents
>> > history.js  1.58 kB   1  [emitted]  history
>> >[0] /Users/dpage/git/pgadmin4/web/~/process/browser.js 5.42 kB {0}
>> > [built]
>> >   [18] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactReconciler.js
>> > 6.21 kB {0} [built]
>> >   [19] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0}
>> > [built]
>> >   [31] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0}
>> > [built]
>> >   [80] ./js/history/history_collection.js 1.91 kB {1} [built]
>> >   [81] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
>> >   [82] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0}
>> > [built]
>> >   [83] ./js/history/index.js 690 bytes {1} [built]
>> >   [84] ./jsx/components.jsx 599 bytes {0} [built]
>> >   [85] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
>> >  [113] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
>> > kB {0} [built]
>> >  [175] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactDOMFactories.js
>> > 5.53 kB {0} [built]
>

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #167

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node

[pgadmin-hackers] pgAdmin 4 commit: Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime t

2017-06-13 Thread Dave Page

Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the zoom level to 
be reset. Fixes #2485

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a5fda44e400492bd76811906f5261334d819956
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/keyboard_shortcuts.rst |  2 ++
runtime/BrowserWindow.cpp | 69 +++
runtime/BrowserWindow.h   |  5 +--
3 files changed, 32 insertions(+), 44 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-13 Thread Dave Page

Nice work! Committed (along with an update to the docs).

Congratulations on your first C++ patch :-)

On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi
 wrote:
> Hi,
>
> On Mon, Jun 12, 2017 at 5:27 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
>>  wrote:
>> > Hi,
>> >
>> > Please find the attached patch to reset the zoom level in the desktop
>> > runtime.
>> >
>> > Added the new shortcut CTRL + 0 to reset the zoom level.
>>
>> The code looks good, however I don't think resetting to the startup
>> value is really what we want. Shouldn't it reset it to 1.0?
>>
> I have changed the code.
> Also, introduced a single slot for Zoom In/Out/Reset rather than 3
> different.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #163

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-13 Thread Dave Page

On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang  wrote:
>>>
>>>
>>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
>>>  wrote:
>>> > Hi
>>> >
>>> > The current font-family applied to slick-grid is
>>> > 'Verdana,Arial,sans-serif'.
>>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif
>>> > but
>>> > the font size and spacing between text is reduced. so to match style I
>>> > used
>>> > "Verdana".
>>> >
>>> > Also, as per my knowledge, the Helvetica font will work only for
>>> > Operating
>>> > Systems where this font actually exists in system, otherwise it will
>>> > pick
>>> > Arial font.
>>> >
>>> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot'
>>> > files
>>> > and use in CSS so that it appears same on all machines:
>>> >
>>> > https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>>> >
>>> > But it seems it is not available for free
>>> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
>>>
>>> Oh, that's not good. I assume we were relying on it being on a users
>>> machine already. I think we need to do one of two things:
>>>
>>> 1) Default to a font that we know should exist everywhere.
>>> 2) Have a fallback from Helvetica Neue to Arial or similar.
>>>
>>> 3) Choose something completely new and free, and ship it with the app.
>>>
>>> I prefer 1 if possible, then 2, finally 3.
>>>
>>> Shirley, any thoughts?
>
>
> Option 1 would require us choosing something new and free (there are a lot
> of webfonts you can get from Google) but would take some time to pick the
> appropriate one.
>
> Option 2 would be the best option for now. We should stick with Helvetica
> and Arial until we have more time to choose the right font.

Sounds good to me.

Surinder, can you make that change please? And update any other font
definitions in our CSS to have the same fallback?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Skip a test that uses the COLLATE option on PG versio

2017-06-13 Thread Dave Page

Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. 
Greenplum).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ce9c97173e904792073597f90ff30c4bfdc1fc
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
web/pgadmin/feature_tests/view_data_dml_queries.py | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-13 Thread Dave Page

Thanks, applied.

On Mon, Jun 12, 2017 at 8:14 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hello Hackers,
> We sent the wrong patch. Attached is the correct one.
>
> Sorry
>
> Shruti & Joao
>
> On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira
>  wrote:
>>
>> Hi Hackers,
>>
>> We were trying to run the feature tests against GreenPlum and one of the
>> tests was failing (CheckForViewDataTest). In this test, we are creating a
>> table using COLLATE, and the COLLATE command is only available starting in
>> version 9.1 of Postgres, per the documentation. We decided to skip this test
>> for now for all PG Versions below 9.1
>>
>> Thanks
>> Shruti & Joao
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-13 Thread Khushboo Vashi

On Tue, Jun 13, 2017 at 2:52 PM, Dave Page  wrote:

> Nice work! Committed (along with an update to the docs).
>
> Congratulations on your first C++ patch :-)
>
> Thanks Dave. :)

> On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi
>  wrote:
> > Hi,
> >
> > On Mon, Jun 12, 2017 at 5:27 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
> >>  wrote:
> >> > Hi,
> >> >
> >> > Please find the attached patch to reset the zoom level in the desktop
> >> > runtime.
> >> >
> >> > Added the new shortcut CTRL + 0 to reset the zoom level.
> >>
> >> The code looks good, however I don't think resetting to the startup
> >> value is really what we want. Shouldn't it reset it to 1.0?
> >>
> > I have changed the code.
> > Also, introduced a single slot for Zoom In/Out/Reset rather than 3
> > different.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Ashesh Vashi

Required mock package for python < 3.3.
It was required for the commit:
1208206bc0eca2d135469258e8a209b983e668be

Also, do not fetch the scenario-name, when it is not avaiable (but - use
default vaule as the stringified test-case itself).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=903389d7b76046141c92a720e9e515cc4bb46274

Modified Files
--
requirements.txt   | 3 ++-
web/regression/runtests.py | 8 +---
2 files changed, 7 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #163

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

--
[...truncated 270.77 KB...]
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue of opening file manager dialog from Query

2017-06-13 Thread Akshay Joshi

Fixed issue of opening file manager dialog from Query Tool.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=794b70daeaafced3ee15c0f6ac7e252ae7ef8ca6

Modified Files
--
web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #284

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 272.94 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page

Is mock required at runtime, or just for tests? It's already in
web/regressions/requirements.txt

On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
 wrote:
> Required mock package for python < 3.3.
> It was required for the commit:
> 1208206bc0eca2d135469258e8a209b983e668be
>
> Also, do not fetch the scenario-name, when it is not avaiable (but - use
> default vaule as the stringified test-case itself).
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=903389d7b76046141c92a720e9e515cc4bb46274
>
> Modified Files
> --
> requirements.txt   | 3 ++-
> web/regression/runtests.py | 8 +---
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Ashesh Vashi

On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:

> And then I find a problem. Sigh.
>
> When running in the desktop runtime, under QtWekKit (the forked,
> updated version that is by far the best of the browser engines we've
> used), we get the attached error at startup. I don't see this under
> QtWebEngine, though as we've already found, that's not usable for
> other reasons.
>
> Is this fixable?
>
As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
"
*WebKit engine itself has not been updated since Qt 5.2 release. That's why
it didn't support recent changes in Web standards that happened after 2013,
including: new JavaScript language standard ES2015 (also known as ES6), as
well as improvements in DOM API and CSS.*
*...*
"

Could this be a reason?

-- Thanks, Ashesh

>
> On Tue, Jun 13, 2017 at 9:52 AM, Dave Page  wrote:
> > Hi
> >
> > On Mon, Jun 12, 2017 at 7:22 PM, Shruti B Iyer  wrote:
> >> Hi Dave,
> >>
> >> We regenerated the patch to add new tasks to package.json to compile
> react
> >> code for development and to not minimize it. This should fix the error
> you
> >> captured in the screenshot.
> >>
> >> The new task to lint and bundle everything for development is:
> >> yarn run bundle:dev
> >>
> >> The new task only bundle everything is:
> >> yarn run webpacker:dev
> >>
> >> We also changed the task test:feature to bundle without optimization
> before
> >> we start the tests.
> >>
> >> When we ran these commands in our machine, they did not display any
> error.
> >> Is it possible that you forgot to run yarn install before running the
> >> webpacker task? We are asking this because the errors look like missing
> node
> >> packages.
> >
> > I did run an install, yes. This patch does work though, so applied -
> thanks!
> >
> > Could you answer my earlier question about the need for the delay in
> > app_starter.py please?
> >
> > Thanks.
> >
> >> On Mon, Jun 12, 2017 at 12:15 PM Dave Page  wrote:
> >>>
> >>> To add to that; running the JS tests gives:
> >>>
> >>> ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
> >>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
> >>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
> >>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
> 13:21-46
> >>>
> >>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
> >>> Module not found: Error: Can't resolve 'immutability-helper' in
> >>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
> >>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
> >>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
> >>>
> >>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
> >>> Module not found: Error: Can't resolve 'moment' in
> >>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
> >>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
> >>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
> >>>
> >>> ERROR in ./regression/javascript/history/query_history_spec.jsx
> >>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
> >>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
> >>>  @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
> >>> webpack: Failed to compile.
> >>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
> >>>   Error: Cannot find module "immutability-helper"
> >>>   at regression/javascript/history/query_history_entry_spec.jsx:30705
> >>>
> >>>
> >>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
> >>>   Error: Cannot find module "immutability-helper"
> >>>   at regression/javascript/history/query_history_spec.jsx:30705
> >>>
> >>>
> >>> error Command failed with exit code 1.
> >>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> >>> this command.
> >>> error Command failed with exit code 1.
> >>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> >>> this command.
> >>>
> >>>
> >>> Also, while I think of it, why the addition of the delay to
> >>> app_starter.py?
> >>>
> >>>
> >>> On Mon, Jun 12, 2017 at 5:12 PM, Dave Page  wrote:
> >>> > Hi,
> >>> >
> >>> > So 01 and 02 are now committed :-).
> >>> >
> >>> > 03 has a couple of problems though (likely the same):
> >>> >
> >>> > - Running the webpacker results in:
> >>> >
> >>> > (pgadmin4)piranha:web dpage$ yarn run webpacker
> >>> > yarn run v0.24.4
> >>> > $ yarn run webpack -- --optimize-minimize --config webpack.config.js
> >>> > yarn run v0.24.4
> >>> > $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
> >>> > --optimize-minimize --config webpack.config.js
> >>> > (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
> >>> > non-string value which can be problematic, see
> >>> > https://github.com/webpack/loader-utils/issues/56
> >>> > parseQuery() will be replaced with getOptions() in the next major
> >>> > version of loader-utils.
> >>> > Hash: a5e75aa70eb6b09bdb78
> >>> > Version: webpack 2.3.3
>

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Ashesh Vashi

Oops.
let me revert it back.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Tue, Jun 13, 2017 at 3:50 PM, Dave Page  wrote:

> Is mock required at runtime, or just for tests? It's already in
> web/regressions/requirements.txt
>
> On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
>  wrote:
> > Required mock package for python < 3.3.
> > It was required for the commit:
> > 1208206bc0eca2d135469258e8a209b983e668be
> >
> > Also, do not fetch the scenario-name, when it is not avaiable (but - use
> > default vaule as the stringified test-case itself).
> >
> > Branch
> > --
> > master
> >
> > Details
> > ---
> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 903389d7b76046141c92a720e9e515cc4bb46274
> >
> > Modified Files
> > --
> > requirements.txt   | 3 ++-
> > web/regression/runtests.py | 8 +---
> > 2 files changed, 7 insertions(+), 4 deletions(-)
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Ashesh Vashi

On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi  wrote:

> Oops.
> let me revert it back.
>
'web/regressions/requirements.txt' needs to change as it is not require for
Python >= 3.3.
Will do the change.

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page  wrote:
>
>> Is mock required at runtime, or just for tests? It's already in
>> web/regressions/requirements.txt
>>
>> On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
>>  wrote:
>> > Required mock package for python < 3.3.
>> > It was required for the commit:
>> > 1208206bc0eca2d135469258e8a209b983e668be
>> >
>> > Also, do not fetch the scenario-name, when it is not avaiable (but - use
>> > default vaule as the stringified test-case itself).
>> >
>> > Branch
>> > --
>> > master
>> >
>> > Details
>> > ---
>> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=903389d7b76046141c92a720e9e515cc4bb46274
>> >
>> > Modified Files
>> > --
>> > requirements.txt   | 3 ++-
>> > web/regression/runtests.py | 8 +---
>> > 2 files changed, 7 insertions(+), 4 deletions(-)
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page

On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Oops.
>> let me revert it back.
>>
> 'web/regressions/requirements.txt' needs to change as it is not require
> for Python >= 3.3.
> Will do the change.
>

OK, thanks.


>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page  wrote:
>>
>>> Is mock required at runtime, or just for tests? It's already in
>>> web/regressions/requirements.txt
>>>
>>> On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
>>>  wrote:
>>> > Required mock package for python < 3.3.
>>> > It was required for the commit:
>>> > 1208206bc0eca2d135469258e8a209b983e668be
>>> >
>>> > Also, do not fetch the scenario-name, when it is not avaiable (but -
>>> use
>>> > default vaule as the stringified test-case itself).
>>> >
>>> > Branch
>>> > --
>>> > master
>>> >
>>> > Details
>>> > ---
>>> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=903389d7b76046141c92a720e9e515cc4bb46274
>>> >
>>> > Modified Files
>>> > --
>>> > requirements.txt   | 3 ++-
>>> > web/regression/runtests.py | 8 +---
>>> > 2 files changed, 7 insertions(+), 4 deletions(-)
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page

On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
 wrote:
> On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
>>
>> And then I find a problem. Sigh.
>>
>> When running in the desktop runtime, under QtWekKit (the forked,
>> updated version that is by far the best of the browser engines we've
>> used), we get the attached error at startup. I don't see this under
>> QtWebEngine, though as we've already found, that's not usable for
>> other reasons.
>>
>> Is this fixable?
>
> As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> "
> WebKit engine itself has not been updated since Qt 5.2 release. That's why
> it didn't support recent changes in Web standards that happened after 2013,
> including: new JavaScript language standard ES2015 (also known as ES6), as
> well as improvements in DOM API and CSS.
> ...
> "
>
> Could this be a reason?

For the old webkit, certainly, but if you read further down, the
version we're using has been updated and does now claim to support
most of ES2015.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Package 'mock' is required for testing, and for Pytho

2017-06-13 Thread Ashesh Vashi

Package 'mock' is required for testing, and for Python < 3.3 only.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=467825c2d19c1ce43e81ea34fa063ef04938c31a

Modified Files
--
requirements.txt| 1 -
web/regression/requirements.txt | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Ashesh Vashi

On Tue, Jun 13, 2017 at 3:57 PM, Dave Page  wrote:

>
>
> On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Oops.
>>> let me revert it back.
>>>
>> 'web/regressions/requirements.txt' needs to change as it is not require
>> for Python >= 3.3.
>> Will do the change.
>>
>
> OK, thanks.
>
Done.
Thanks.

-- Thanks, Ashesh

>
>
>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>
>>> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page  wrote:
>>>
 Is mock required at runtime, or just for tests? It's already in
 web/regressions/requirements.txt

 On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
  wrote:
 > Required mock package for python < 3.3.
 > It was required for the commit:
 > 1208206bc0eca2d135469258e8a209b983e668be
 >
 > Also, do not fetch the scenario-name, when it is not avaiable (but -
 use
 > default vaule as the stringified test-case itself).
 >
 > Branch
 > --
 > master
 >
 > Details
 > ---
 > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
 f;h=903389d7b76046141c92a720e9e515cc4bb46274
 >
 > Modified Files
 > --
 > requirements.txt   | 3 ++-
 > web/regression/runtests.py | 8 +---
 > 2 files changed, 7 insertions(+), 4 deletions(-)
 >
 >
 > --
 > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
 )
 > To make changes to your subscription:
 > http://www.postgresql.org/mailpref/pgadmin-hackers



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Ashesh Vashi

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Tue, Jun 13, 2017 at 3:56 PM, Dave Page  wrote:

> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>  wrote:
> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
> >>
> >> And then I find a problem. Sigh.
> >>
> >> When running in the desktop runtime, under QtWekKit (the forked,
> >> updated version that is by far the best of the browser engines we've
> >> used), we get the attached error at startup. I don't see this under
> >> QtWebEngine, though as we've already found, that's not usable for
> >> other reasons.
> >>
> >> Is this fixable?
> >
> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> > "
> > WebKit engine itself has not been updated since Qt 5.2 release. That's
> why
> > it didn't support recent changes in Web standards that happened after
> 2013,
> > including: new JavaScript language standard ES2015 (also known as ES6),
> as
> > well as improvements in DOM API and CSS.
> > ...
> > "
> >
> > Could this be a reason?
>
> For the old webkit, certainly, but if you read further down, the
> version we're using has been updated and does now claim to support
> most of ES2015.
>
This is in one of the comment section.

"This branch is 1099 commits ahead, 7251 commits behind WebKit:master."

-- Thanks, Ashesh

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Surinder Kumar

On Tue, Jun 13, 2017 at 3:56 PM, Dave Page  wrote:

> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>  wrote:
> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
> >>
> >> And then I find a problem. Sigh.
> >>
> >> When running in the desktop runtime, under QtWekKit (the forked,
> >> updated version that is by far the best of the browser engines we've
> >> used), we get the attached error at startup. I don't see this under
> >> QtWebEngine, though as we've already found, that's not usable for
> >> other reasons.
> >>
> >> Is this fixable?
> >
> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> > "
> > WebKit engine itself has not been updated since Qt 5.2 release. That's
> why
> > it didn't support recent changes in Web standards that happened after
> 2013,
> > including: new JavaScript language standard ES2015 (also known as ES6),
> as
> > well as improvements in DOM API and CSS.
> > ...
> > "
> >
> > Could this be a reason?
>
> For the old webkit, certainly, but if you read further down, the
> version we're using has been updated and does now claim to support
> most of ES2015.
>
In fact the modern browsers don't support ES6 JS so the JS files
containing ES6 code are first transpiled using babel into JS that browsers
supports.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-13 Thread Dave Page

Use a more sensible name for Query Tool tabs. Fixes #2482

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57d866f7b70996a82a881b20248c3285ab3a6900
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js   |  4 +-
web/pgadmin/static/css/webcabin.overrides.css  | 13 +
.../datagrid/templates/datagrid/js/datagrid.js | 58 --
.../sqleditor/templates/sqleditor/js/sqleditor.js  |  5 +-
4 files changed, 49 insertions(+), 31 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page

Thanks, patch applied.

On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
 wrote:
> Hi
>
> Changes:
>
> 1) When Query tool is opened, right now - panel title is displayed as "Query
> - 1 ", instead it should display Query - [db_name] on [server_name] as in
> pgAdmin3.
>
> 2) When Edit grid is opened for table, the panel title should display
> Edit Data - [server_name] - [db_name] - [table_name]
>
> These names are more meaningful instead of "Query - #'. helpful while
> switching to panel tabs.
>
> 3) If panel is inactive and its title is quite long, show ellipsis(...),
> otherwise display full title.
>
> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>
> Also tested with preference settings > Open query tool in new tab. It
> works!!.
>
> Please find attached patch
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page

On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
 wrote:
>
> On Tue, Jun 13, 2017 at 3:56 PM, Dave Page  wrote:
>>
>> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>>  wrote:
>> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
>> >>
>> >> And then I find a problem. Sigh.
>> >>
>> >> When running in the desktop runtime, under QtWekKit (the forked,
>> >> updated version that is by far the best of the browser engines we've
>> >> used), we get the attached error at startup. I don't see this under
>> >> QtWebEngine, though as we've already found, that's not usable for
>> >> other reasons.
>> >>
>> >> Is this fixable?
>> >
>> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
>> > "
>> > WebKit engine itself has not been updated since Qt 5.2 release. That's
>> > why
>> > it didn't support recent changes in Web standards that happened after
>> > 2013,
>> > including: new JavaScript language standard ES2015 (also known as ES6),
>> > as
>> > well as improvements in DOM API and CSS.
>> > ...
>> > "
>> >
>> > Could this be a reason?
>>
>> For the old webkit, certainly, but if you read further down, the
>> version we're using has been updated and does now claim to support
>> most of ES2015.
>
> In fact the modern browsers don't support ES6 JS so the JS files containing
> ES6 code are first transpiled using babel into JS that browsers supports.

Well, we *could* do that, but are we? I'm not sure the current code
does anything more than lint and webpack it.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Surinder Kumar

On Tue, Jun 13, 2017 at 4:05 PM, Dave Page  wrote:

> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
>  wrote:
> >
> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page  wrote:
> >>
> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
> >>  wrote:
> >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
> >> >>
> >> >> And then I find a problem. Sigh.
> >> >>
> >> >> When running in the desktop runtime, under QtWekKit (the forked,
> >> >> updated version that is by far the best of the browser engines we've
> >> >> used), we get the attached error at startup. I don't see this under
> >> >> QtWebEngine, though as we've already found, that's not usable for
> >> >> other reasons.
> >> >>
> >> >> Is this fixable?
> >> >
> >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> >> > "
> >> > WebKit engine itself has not been updated since Qt 5.2 release. That's
> >> > why
> >> > it didn't support recent changes in Web standards that happened after
> >> > 2013,
> >> > including: new JavaScript language standard ES2015 (also known as
> ES6),
> >> > as
> >> > well as improvements in DOM API and CSS.
> >> > ...
> >> > "
> >> >
> >> > Could this be a reason?
> >>
> >> For the old webkit, certainly, but if you read further down, the
> >> version we're using has been updated and does now claim to support
> >> most of ES2015.
> >
> > In fact the modern browsers don't support ES6 JS so the JS files
> containing
> > ES6 code are first transpiled using babel into JS that browsers supports.
>
> Well, we *could* do that, but are we? I'm not sure the current code
> does anything more than lint and webpack it.
>
Yes. babel is used in webpack config which converts JSX, JS and react JS
library code into browser supportable JS code and put them into generated
directory which we are then imported in sqleditor.js

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #164

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #157

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #160

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 270.94 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page

On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar
 wrote:
> On Tue, Jun 13, 2017 at 4:05 PM, Dave Page  wrote:
>>
>> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
>>  wrote:
>> >
>> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page  wrote:
>> >>
>> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>> >>  wrote:
>> >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page  wrote:
>> >> >>
>> >> >> And then I find a problem. Sigh.
>> >> >>
>> >> >> When running in the desktop runtime, under QtWekKit (the forked,
>> >> >> updated version that is by far the best of the browser engines we've
>> >> >> used), we get the attached error at startup. I don't see this under
>> >> >> QtWebEngine, though as we've already found, that's not usable for
>> >> >> other reasons.
>> >> >>
>> >> >> Is this fixable?
>> >> >
>> >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
>> >> > "
>> >> > WebKit engine itself has not been updated since Qt 5.2 release.
>> >> > That's
>> >> > why
>> >> > it didn't support recent changes in Web standards that happened after
>> >> > 2013,
>> >> > including: new JavaScript language standard ES2015 (also known as
>> >> > ES6),
>> >> > as
>> >> > well as improvements in DOM API and CSS.
>> >> > ...
>> >> > "
>> >> >
>> >> > Could this be a reason?
>> >>
>> >> For the old webkit, certainly, but if you read further down, the
>> >> version we're using has been updated and does now claim to support
>> >> most of ES2015.
>> >
>> > In fact the modern browsers don't support ES6 JS so the JS files
>> > containing
>> > ES6 code are first transpiled using babel into JS that browsers
>> > supports.
>>
>> Well, we *could* do that, but are we? I'm not sure the current code
>> does anything more than lint and webpack it.
>
> Yes. babel is used in webpack config which converts JSX, JS and react JS
> library code into browser supportable JS code and put them into generated
> directory which we are then imported in sqleditor.js

Ahh, yes - I see it (still getting my head around this stuff). So,
perhaps we need a different transform to support webkit?


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-13 Thread Surinder Kumar

Hi

On Tue, Jun 13, 2017 at 2:54 PM, Dave Page  wrote:

> On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang  wrote:
> >>>
> >>>
> >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
> >>>  wrote:
> >>> > Hi
> >>> >
> >>> > The current font-family applied to slick-grid is
> >>> > 'Verdana,Arial,sans-serif'.
> >>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif
> >>> > but
> >>> > the font size and spacing between text is reduced. so to match style
> I
> >>> > used
> >>> > "Verdana".
> >>> >
> >>> > Also, as per my knowledge, the Helvetica font will work only for
> >>> > Operating
> >>> > Systems where this font actually exists in system, otherwise it will
> >>> > pick
> >>> > Arial font.
> >>> >
> >>> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot'
> >>> > files
> >>> > and use in CSS so that it appears same on all machines:
> >>> >
> >>> > https://stackoverflow.com/questions/13013616/css-
> helvetica-neue-not-working
> >>> >
> >>> > But it seems it is not available for free
> >>> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
> >>>
> >>> Oh, that's not good. I assume we were relying on it being on a users
> >>> machine already. I think we need to do one of two things:
> >>>
> >>> 1) Default to a font that we know should exist everywhere.
> >>> 2) Have a fallback from Helvetica Neue to Arial or similar.
> >>>
> >>> 3) Choose something completely new and free, and ship it with the app.
> >>>
> >>> I prefer 1 if possible, then 2, finally 3.
> >>>
> >>> Shirley, any thoughts?
> >
> >
> > Option 1 would require us choosing something new and free (there are a
> lot
> > of webfonts you can get from Google) but would take some time to pick the
> > appropriate one.
> >
> > Option 2 would be the best option for now. We should stick with Helvetica
> > and Arial until we have more time to choose the right font.
>
> Sounds good to me.
>
> Surinder, can you make that change please? And update any other font
> definitions in our CSS to have the same fallback?
>
Added fonts Arial, Verdana as fallback in pgadmin.styles.css file. Also
used text-12 class for datagrid element.

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_2477_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #286

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

--
[...truncated 274.00 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #168

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.Sc

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #164

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #169

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #161

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #161

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #172

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

--
[...truncated 271.29 KB...]
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 31, in runTest
server_response = server_utils.con

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #289

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 272.37 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #168

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 270.94 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #160

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page

Temporarily disable the Javascript bundler test until it handle more than one 
run.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9

Modified Files
--
web/pgadmin/utils/javascript/tests/test_javascript_bundler.py | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #173

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 271.29 KB...]
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 31, in runTest
server_response = server_utils.connect_server(s

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page

Pivotal team,

Per the commit below, and the probably many messages you've likely
seen from Jenkins, I've had to disable the JavascriptBundler test. It
works fine if you're testing a single server, but if you have more
than one enabled in test_config.json, then it will fail on the second
(and I imagine subsequent) servers.

Can you take a look at this please?

Thanks.

On Tue, Jun 13, 2017 at 2:22 PM, Dave Page  wrote:
> Temporarily disable the Javascript bundler test until it handle more than one 
> run.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9
>
> Modified Files
> --
> web/pgadmin/utils/javascript/tests/test_javascript_bundler.py | 1 +
> 1 file changed, 1 insertion(+)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #166

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #171

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 271.26 KB...]
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 31, in runTest
server_response = server_utils.connect_ser

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #174

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #162

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Joao Pedro De Almeida Pereira

Hello Hackers,
We will create a new patch to solve this issue.

Thanks
Joao & Shruti

On Tue, Jun 13, 2017 at 9:37 AM, Dave Page  wrote:

> Pivotal team,
>
> Per the commit below, and the probably many messages you've likely
> seen from Jenkins, I've had to disable the JavascriptBundler test. It
> works fine if you're testing a single server, but if you have more
> than one enabled in test_config.json, then it will fail on the second
> (and I imagine subsequent) servers.
>
> Can you take a look at this please?
>
> Thanks.
>
> On Tue, Jun 13, 2017 at 2:22 PM, Dave Page  wrote:
> > Temporarily disable the Javascript bundler test until it handle more
> than one run.
> >
> > Branch
> > --
> > master
> >
> > Details
> > ---
> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> cb97722fc3826f94f375f5f48807a486383ee3a9
> >
> > Modified Files
> > --
> > web/pgadmin/utils/javascript/tests/test_javascript_bundler.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Joao Pedro De Almeida Pereira

Hi Hackers,

Attached you can find the patch that corrects that Bundle tests that was
polluting the os and subprocess modules.

This patch reverts the commit that skipped the test.


Thanks
Shruti & Joao


correct-bundle-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #169

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #292

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #166

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 270.94 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Dave Page

Hi

On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hi Hackers,
>
> Attached you can find the patch that corrects that Bundle tests that was
> polluting the os and subprocess modules.
>
> This patch reverts the commit that skipped the test.

This is almost exactly what Ashesh and I came up with (along with a
few other variations). Unfortunately, whilst all the other tests now
pass, the second execution of the bundler test fails with:

==
FAIL: runTest 
(pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
scenario name: JavascriptBundlerTestCase
--
Traceback (most recent call last):
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 44, in runTest
self._bundling_succeeds()
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 70, in _bundling_succeeds
self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
'bundle:dev'])
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
line 947, in assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'call' to be called once. Called 0 times.

--

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #165

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #170

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #168

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #162

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #170

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

--
[...truncated 271.23 KB...]
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #164

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Fixed issue of opening file manager dialog from Query Tool.

--
[...truncated 270.94 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #171

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #167

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

--
[...truncated 270.77 KB...]
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #167

2017-06-13 Thread pgAdmin 4 Jenkins

See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Joao Pedro De Almeida Pereira

Hi Hackers,

Good catch Dave.

You can find attached the new diff with the correction of the problem above.

Thanks
Shruti & Joao

On Tue, Jun 13, 2017 at 10:35 AM, Dave Page  wrote:

> Hi
>
> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
>  wrote:
> > Hi Hackers,
> >
> > Attached you can find the patch that corrects that Bundle tests that was
> > polluting the os and subprocess modules.
> >
> > This patch reverts the commit that skipped the test.
>
> This is almost exactly what Ashesh and I came up with (along with a
> few other variations). Unfortunately, whilst all the other tests now
> pass, the second execution of the bundler test fails with:
>
> ==
> FAIL: runTest (pgadmin.utils.javascript.tests.test_javascript_bundler.
> JavascriptBundlerTestCase)
> scenario name: JavascriptBundlerTestCase
> --
> Traceback (most recent call last):
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/
> tests/test_javascript_bundler.py",
> line 44, in runTest
> self._bundling_succeeds()
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/
> tests/test_javascript_bundler.py",
> line 70, in _bundling_succeeds
> self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
> 'bundle:dev'])
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/mock/mock.py",
> line 947, in assert_called_once_with
> raise AssertionError(msg)
> AssertionError: Expected 'call' to be called once. Called 0 times.
>
> --
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


correct-bundle-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #287

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 274.00 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #288

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Required mock package for python < 3.3. It was required for the 
commit:

--
[...truncated 273.27 KB...]
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page

Hmm, this seems to have broken the feature tests. Can you look at that
ASAP please? I think it's because the tab text has changed.

On Tue, Jun 13, 2017 at 11:34 AM, Dave Page  wrote:
> Thanks, patch applied.
>
> On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
>  wrote:
>> Hi
>>
>> Changes:
>>
>> 1) When Query tool is opened, right now - panel title is displayed as "Query
>> - 1 ", instead it should display Query - [db_name] on [server_name] as in
>> pgAdmin3.
>>
>> 2) When Edit grid is opened for table, the panel title should display
>> Edit Data - [server_name] - [db_name] - [table_name]
>>
>> These names are more meaningful instead of "Query - #'. helpful while
>> switching to panel tabs.
>>
>> 3) If panel is inactive and its title is quite long, show ellipsis(...),
>> otherwise display full title.
>>
>> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>>
>> Also tested with preference settings > Open query tool in new tab. It
>> works!!.
>>
>> Please find attached patch
>>
>> Thanks
>> Surinder
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Shirley Wang

Awesome!! This is super helpful :)

Does this affect a new query window (currently the title is 'Query -
untitled')?

On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> Changes:
>
> 1) When Query tool is opened, right now - panel title is displayed as
> "Query - 1 ", instead it should display Query - [db_name] on [server_name] as
> in pgAdmin3.
>
> 2) When Edit grid is opened for table, the panel title should display
> Edit Data - [server_name] - [db_name] - [table_name]
>
> These names are more meaningful instead of "Query - #'. helpful while
> switching to panel tabs.
>
> 3) If panel is inactive and its title is quite long, show ellipsis(...),
> otherwise display full title.
>
> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>
> Also tested with preference settings > Open query tool in new tab. It
> works!!.
>
> Please find attached patch
>
> Thanks
> Surinder
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-13 Thread Robert Eckhardt

Akshay,

Have you determined the minimum feature set you are shooting for before you
commit this? The reason I ask is that we were thinking that some level of
simple automation would probably be nice to make this super useful.

Basically if you consider a simple example of partitioning 90 days of data
by day the manual process of creating the names and to - from fields
becomes rather painful. If you couple that with potentially wanting to do
list subpartitioning if just multiplies the work.

If we could get something committed then we could more easily work to
define where simple automation makes sense and where it doesn't.

-- Rob

On Tue, Jun 13, 2017 at 6:59 AM, Akshay Joshi  wrote:

> Hi All
>
> For further implementation following task needs to be work upon:
>
>- How to parse and show partitions keys. For example user has created
>below partitioned table
>
> CREATE TABLE public.sales
> (
> country character varying COLLATE pg_catalog."default" NOT NULL,
> sales bigint,
> saledate date
> ) PARTITION BY RANGE (*country, date_part('year'::text, sale date)*)
>
> When user open the properties dialog I am not able to figure out how to
> parse keys(displayed in bold in above example) and show them in our control
> that we used. For the time being I have hide that control in 'Edit' mode
> (Refer Attach Partition.png)
>
>
>- *Support of sub partitioning*: To implement sub-partitioning,
>specify the PARTITION BY clause in the commands used to create individual
>partitions, for example:
>-
>
>CREATE TABLE measurement_y2006 PARTITION OF measurement
>FOR VALUES FROM ('2006-02-01') TO ('2006-03-01')
>PARTITION BY RANGE (peaktemp);
>
>
>To achieve above I have made some changes in GUI (Refer Sub
> Partition.png).
>*Complex and challenging part here is "measurement_y2006" is
> partition of "measurement" and parent table for other partitions too which
> user can create later. How we will going to show this in browser tree? *
>One option could be
>Tables
>  ->measurement(table)
>->Partitions
>  ->measurement_y2006(Partition of measurement and parent
> of p1)
>->Partitions
>  ->p1
>
>- *Attach Partitions*: To implement attach N partitions I have made
>some changes in GUI( Refer Attach Partition.png). Attach Partitions
>control will only be visible in "Edit" mode.
>
> I have only modified the UI changes, there are lots of work needs to be
> done to complete that.
> Please review the design. Suggestions/Comments are welcome.
>
>
> On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt 
> wrote:
>
>>
>>
>> On Tue, Jun 6, 2017 at 4:32 AM, Dave Page  wrote:
>>
>>>
>>> For roll up this pattern seems obvious, identify the n partitions you
 need/want to combine and then run a job to combine them.

>>>
>>> You're thinking Greenplum :-). There is no roll up in PostgreSQL, unless
>>> you're thinking we should create such a feature in pgAdmin.
>>>
>>> Of course, I have no objection to extending what we do in PG to add GP
>>> feature support, but let's start with PG.
>>>
>>
>> No not at all. That was a very specific and consistent pattern described
>> by users leveraging time based range partitions in Postgres. I'm not sure
>> if that same use case will be supported with partitioning as implemented in
>> Postgres 10 but it is a Postgres pattern.
>>
>> -- Rob
>>
>>
>>>
>>>

 For other patterns such as creating indexes and such it requires a bit
 more thought. Generally users described wanting to treat all of the
 children like a single table (just like Oracle), however, other users
 described potentially modifying chunks of partitions differently depending
 on some criterion. This means that users will need to identify the subset
 they want to optimize and then ideally be able to act on them all at once.

>>>
>>> Right.
>>>
>>>

 -- Rob






>
> So... it sounds like we're on the right lines :-)
>
>
>>
>> For the former, this can be addressed by enabling users to modify one
>> or more child partitions at the same time. For the latter, that is a
>> workflow that might be addressed outside of the create table with 
>> partition
>> workflow we're working on currently.
>>
>>
>>
>>
>>
>> On Mon, Jun 5, 2017 at 5:21 AM Dave Page  wrote:
>>
>>> On Fri, Jun 2, 2017 at 9:01 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi All

 Following are the further implementation updates to support
 Declarative Partitioning:

- Show all the existing partitions of the parent table in
Partitions tab (Refer Existing_Partitions.png)
- Ability to create N partitions and detach existing
partitions. Refer (Create_Det

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #165

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #290

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

--
[...truncated 273.42 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #163

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #156

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fix the fix for RM2324.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-13 Thread Shirley Wang

To add some interview context - from talking to DBAs, partitioning is the
most frequent use case we should account for first. Breaking down child
partitions into smaller pieces wasn't something we heard as a need. This is
probably not the highest priority work needed now.

We should think about when it would be good to release partitioning for
some feedback. Did you already have this planned out?

On Tue, Jun 13, 2017 at 9:46 AM Robert Eckhardt 
wrote:

> Akshay,
>
> Have you determined the minimum feature set you are shooting for before
> you commit this? The reason I ask is that we were thinking that some level
> of simple automation would probably be nice to make this super useful.
>

> Basically if you consider a simple example of partitioning 90 days of data
> by day the manual process of creating the names and to - from fields
> becomes rather painful. If you couple that with potentially wanting to do
> list subpartitioning if just multiplies the work.
>
> If we could get something committed then we could more easily work to
> define where simple automation makes sense and where it doesn't.
>
> -- Rob
>
> On Tue, Jun 13, 2017 at 6:59 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> For further implementation following task needs to be work upon:
>>
>>- How to parse and show partitions keys. For example user has created
>>below partitioned table
>>
>> CREATE TABLE public.sales
>> (
>> country character varying COLLATE pg_catalog."default" NOT NULL,
>> sales bigint,
>> saledate date
>> ) PARTITION BY RANGE (*country, date_part('year'::text, sale date)*)
>>
>> When user open the properties dialog I am not able to figure out how to
>> parse keys(displayed in bold in above example) and show them in our control
>> that we used. For the time being I have hide that control in 'Edit' mode
>> (Refer Attach Partition.png)
>>
>>
>>- *Support of sub partitioning*: To implement sub-partitioning,
>>specify the PARTITION BY clause in the commands used to create individual
>>partitions, for example:
>>-
>>
>>CREATE TABLE measurement_y2006 PARTITION OF measurement
>>FOR VALUES FROM ('2006-02-01') TO ('2006-03-01')
>>PARTITION BY RANGE (peaktemp);
>>
>>
>>To achieve above I have made some changes in GUI (Refer Sub
>> Partition.png).
>>*Complex and challenging part here is "measurement_y2006" is
>> partition of "measurement" and parent table for other partitions too which
>> user can create later. How we will going to show this in browser tree? *
>>One option could be
>>Tables
>>  ->measurement(table)
>>->Partitions
>>  ->measurement_y2006(Partition of measurement and parent
>> of p1)
>>->Partitions
>>  ->p1
>>
>>- *Attach Partitions*: To implement attach N partitions I have made
>>some changes in GUI( Refer Attach Partition.png). Attach Partitions
>>control will only be visible in "Edit" mode.
>>
>> I have only modified the UI changes, there are lots of work needs to be
>> done to complete that.
>> Please review the design. Suggestions/Comments are welcome.
>>
>>
>> On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt 
>> wrote:
>>
>>>
>>>
>>> On Tue, Jun 6, 2017 at 4:32 AM, Dave Page  wrote:
>>>

 For roll up this pattern seems obvious, identify the n partitions you
> need/want to combine and then run a job to combine them.
>

 You're thinking Greenplum :-). There is no roll up in PostgreSQL,
 unless you're thinking we should create such a feature in pgAdmin.

 Of course, I have no objection to extending what we do in PG to add GP
 feature support, but let's start with PG.

>>>
>>> No not at all. That was a very specific and consistent pattern described
>>> by users leveraging time based range partitions in Postgres. I'm not sure
>>> if that same use case will be supported with partitioning as implemented in
>>> Postgres 10 but it is a Postgres pattern.
>>>
>>> -- Rob
>>>
>>>


>
> For other patterns such as creating indexes and such it requires a bit
> more thought. Generally users described wanting to treat all of the
> children like a single table (just like Oracle), however, other users
> described potentially modifying chunks of partitions differently depending
> on some criterion. This means that users will need to identify the subset
> they want to optimize and then ideally be able to act on them all at once.
>

 Right.


>
> -- Rob
>
>
>
>
>
>
>>
>> So... it sounds like we're on the right lines :-)
>>
>>
>>>
>>> For the former, this can be addressed by enabling users to modify
>>> one or more child partitions at the same time. For the latter, that is a
>>> workflow that might be addressed outside of the create table with 
>>>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar

Hi

PFA patch.

On Tue, Jun 13, 2017 at 9:54 PM, Dave Page  wrote:

> Hmm, this seems to have broken the feature tests. Can you look at that
> ASAP please? I think it's because the tab text has changed.
>
Yes, now it will search for 'Query -' instead of 'Query-1'.

>
> On Tue, Jun 13, 2017 at 11:34 AM, Dave Page  wrote:
> > Thanks, patch applied.
> >
> > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
> >  wrote:
> >> Hi
> >>
> >> Changes:
> >>
> >> 1) When Query tool is opened, right now - panel title is displayed as
> "Query
> >> - 1 ", instead it should display Query - [db_name] on [server_name] as
> in
> >> pgAdmin3.
> >>
> >> 2) When Edit grid is opened for table, the panel title should display
> >> Edit Data - [server_name] - [db_name] - [table_name]
> >>
> >> These names are more meaningful instead of "Query - #'. helpful while
> >> switching to panel tabs.
> >>
> >> 3) If panel is inactive and its title is quite long, show ellipsis(...),
> >> otherwise display full title.
> >>
> >> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
> >>
> >> Also tested with preference settings > Open query tool in new tab. It
> >> works!!.
> >>
> >> Please find attached patch
> >>
> >> Thanks
> >> Surinder
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


fix_feature_test_regre_2482.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar

On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang  wrote:

> Awesome!! This is super helpful :)
>
> Does this affect a new query window (currently the title is 'Query -
> untitled')?
>
Yes, in this case the title of query window will be Query - [db_name] on
[server_name]. It was showing 'Query - untitled' when opened from context
menu because no tree information was passed.

>
> On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> Changes:
>>
>> 1) When Query tool is opened, right now - panel title is displayed as
>> "Query - 1 ", instead it should display Query - [db_name] on
>> [server_name] as in pgAdmin3.
>>
>> 2) When Edit grid is opened for table, the panel title should display
>> Edit Data - [server_name] - [db_name] - [table_name]
>>
>> These names are more meaningful instead of "Query - #'. helpful while
>> switching to panel tabs.
>>
>> 3) If panel is inactive and its title is quite long, show ellipsis(...),
>> otherwise display full title.
>>
>> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>>
>> Also tested with preference settings > Open query tool in new tab. It
>> works!!.
>>
>> Please find attached patch
>>
>> Thanks
>> Surinder
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Shirley Wang

On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang  wrote:
>
>> Awesome!! This is super helpful :)
>>
>> Does this affect a new query window (currently the title is 'Query -
>> untitled')?
>>
> Yes, in this case the title of query window will be Query - [db_name] on
> [server_name]. It was showing 'Query - untitled' when opened from context
> menu because no tree information was passed.
>

I know you enabled ellipses for names that are too long, but if it's a
database name and server name in a tab, I think that all the tabs will have
ellipses. Considering that, what if we just shorten it to the database
name, especially since the blue bar where you type the SQL has the name of
the server.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #167

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #161

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #285

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Initial re-vamp of the History tab.

--
[...truncated 274.00 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

=

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #166

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar

On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang  wrote:

>
>
> On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang  wrote:
>>
>>> Awesome!! This is super helpful :)
>>>
>>> Does this affect a new query window (currently the title is 'Query -
>>> untitled')?
>>>
>> Yes, in this case the title of query window will be Query - [db_name]
>> on [server_name]. It was showing 'Query - untitled' when opened from
>> context menu because no tree information was passed.
>>
>
> I know you enabled ellipses for names that are too long, but if it's a
> database name and server name in a tab, I think that all the tabs will have
> ellipses. Considering that, what if we just shorten it to the database
> name, especially since the blue bar where you type the SQL has the name of
> the server.
>
Yes ellipses and tooltips are used if name is too long.
But what I think is the title has all useful information about the
database and server it is connected to, considering the case:

1) When multiple instances of query tool are opened in New Tab/Window. or
when a user has multiple screens.

2) If a user is parallely running multiple instance of query tool for
different databases of different servers. server name will help uniquely
identify the tab.

3) The panel can be moved out of Panels tab by dragging out, so the panel
title must have server and database information.

considering the above cases, I think the blue bar could be removed If query
tool title already have server and database information.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #165

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #169

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Ashesh Vashi] Package 'mock' is required for testing, and for Python < 3.3 
only.

--
[...truncated 270.64 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #158

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #162

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the 
zoom

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 3

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #291

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Use a more sensible name for Query Tool tabs. Fixes #2482

--
[...truncated 272.36 KB...]
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
db_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #159

2017-06-13 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Skip a test that uses the COLLATE option on PG versions below 9.1 
(e.g.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

99 matches

Mail list logo