Re: Fix typo in comment

2022-05-06 Thread Tom Lane 
Alvaro Herrera  writes:
> On 2022-May-06, Zaorang Yang wrote:
>> Maybe, the first letter of comments in postinit.c should be capitalized.

> Hmm, typically these one-line comments are not "full sentences", so they
> don't have capitals and no ending periods either.  I wouldn't like the
> endless stream of patches that would result if we let this go in.

There is no project style guideline suggesting one over the other, so
I think we should just leave it alone.

regards, tom lane

Re: Fix typo in comment

2022-05-06 Thread Daniel Gustafsson 
> On 6 May 2022, at 14:50, Alvaro Herrera  wrote:
> 
> On 2022-May-06, Zaorang Yang wrote:
> 
>> Maybe, the first letter of comments in postinit.c should be capitalized.
> 
> Hmm, typically these one-line comments are not "full sentences", so they
> don't have capitals and no ending periods either.  I wouldn't like the
> endless stream of patches that would result if we let this go in.

Agreed. A quick grep turns up a fair number of such comments:

 $ git grep "^\s*\/\* [a-z].\+\*\/$" src/ | wc -l
   16588

If anything should be done to this it would perhaps be better to add to
pgindent or a similar automated process.  If anything.

--
Daniel Gustafsson   https://vmware.com/

Re: Fix typo in comment

2022-05-06 Thread Alvaro Herrera 
On 2022-May-06, Zaorang Yang wrote:

> Maybe, the first letter of comments in postinit.c should be capitalized.

Hmm, typically these one-line comments are not "full sentences", so they
don't have capitals and no ending periods either.  I wouldn't like the
endless stream of patches that would result if we let this go in.

-- 
Álvaro Herrera PostgreSQL Developer  —  https://www.EnterpriseDB.com/

Fix typo in comment

2022-05-06 Thread Zaorang Yang 
Maybe, the first letter of comments in postinit.c should be capitalized.
Attaching a tiny patch to fix it.


0001-Fix-typo-in-comment.patch
Description: Binary data

Re: Fix typo in comment

2021-01-04 Thread Amit Kapila 
On Tue, Jan 5, 2021 at 5:36 AM Peter Smith  wrote:
>
> PSA a trivial patch to correct a comment typo.
>

LGTM. Pushed!

-- 
With Regards,
Amit Kapila.

Fix typo in comment

2021-01-04 Thread Peter Smith 
PSA a trivial patch to correct a comment typo.


Kind Regards,
Peter Smith
Fujitsu Australia.


fix_typo.patch
Description: Binary data