Re: [PATCHES] Removing NONSEG mode

2008-05-01 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes:
> I attach patch which remove nonsegment mode support. It was discussed during
> last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
> XFS) and it is not safe on any OS because each OS support more filesystems.

Applied with revisions --- mostly, you missed updating the
documentation, but also I didn't like the "LL" constant you used in
RELSEG_SIZE.  It's unportable and there might be unexpected side effects
from having the macro represent an int64 constant instead of an integer.
So I had configure do the arithmetic and emit an integer.

regards, tom lane

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches


Re: [PATCHES] Removing NONSEG mode

2008-04-22 Thread Alvaro Herrera
Zdenek Kotala wrote:
> I attach patch which remove nonsegment mode support. It was discussed during
> last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
> XFS) and it is not safe on any OS because each OS support more filesystems.

Added to May commitfest, thanks.

-- 
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches