Bug #51076 [Com]: race condition in shtool's mkdir -p implementation
Edit report at https://bugs.php.net/bug.php?id=51076edit=1 ID: 51076 Comment by: fviard at lacie dot com Reported by:geissert at debian dot org Summary:race condition in shtool's mkdir -p implementation Status: Assigned Type: Bug Package:Compile Failure Operating System: * PHP Version:5.3SVN-2010-02-18 (SVN) Assigned To:geissert Block user comment: N Private report: N New Comment: Hi, So, after all, anyone to commit again the fix? Thank you Previous Comments: [2013-10-01 14:11:38] m...@php.net Looks like I have to apologize for being an asshole myself, some may even think I'm the only asshole here. [2013-10-01 13:55:06] m...@php.net And you make me angry by wasting my time. It was just a template when marking a bug as duplicate. Stop calling people and do something yourself. You do not have to apologize for being an asshole, just don't be an asshole. [2013-10-01 12:58:34] fviard at lacie dot com Hi, Today m...@php.net made me angry by posting a crappy comment on my 2,5years old bug report #54205 without even fixing the issue. This issue was so old that I completely forgot it. But now, I'm stupefied to notice that after 2 years, that issue that is resolvable with only a 5lines patch (easy to apply) is still not resolved. What are you doing? Mike, sorry to be offensive, but do you prefer harassing people on old bugs or fixing them? So, please close this bug soon! Thank you! [2013-10-01 12:30:15] m...@php.net Related To: Bug #54205 [2010-02-18 08:34:49] j...@php.net -Status: Closed +Status: Assigned Not fixed. The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=51076 -- Edit this bug report at https://bugs.php.net/bug.php?id=51076edit=1
Bug #51076 [Com]: race condition in shtool's mkdir -p implementation
Edit report at https://bugs.php.net/bug.php?id=51076edit=1 ID: 51076 Comment by: fviard at lacie dot com Reported by:geissert at debian dot org Summary:race condition in shtool's mkdir -p implementation Status: Assigned Type: Bug Package:Compile Failure Operating System: * PHP Version:5.3SVN-2010-02-18 (SVN) Assigned To:geissert Block user comment: N Private report: N New Comment: Hi, Today m...@php.net made me angry by posting a crappy comment on my 2,5years old bug report #54205 without even fixing the issue. This issue was so old that I completely forgot it. But now, I'm stupefied to notice that after 2 years, that issue that is resolvable with only a 5lines patch (easy to apply) is still not resolved. What are you doing? Mike, sorry to be offensive, but do you prefer harassing people on old bugs or fixing them? So, please close this bug soon! Thank you! Previous Comments: [2013-10-01 12:30:15] m...@php.net Related To: Bug #54205 [2010-02-18 08:34:49] j...@php.net -Status: Closed +Status: Assigned Not fixed. [2010-02-18 00:31:15] geiss...@php.net -Status: Open +Status: Closed This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. [2010-02-18 00:30:13] s...@php.net Automatic comment from SVN on behalf of geissert Revision: http://svn.php.net/viewvc/?view=revisionrevision=295225 Log: Fix race condition in shtool's mkdir -p implementation (bug #51076) [2010-02-18 00:18:48] geissert at debian dot org Description: There's a race condition in shtool's mkdir -p (not yet fixed in the latest version). At Debian we got hit by it when building with -jn. I've just reported it to upstream, but since php uses its local (old) copy I'm going to fix it here too. -- Edit this bug report at https://bugs.php.net/bug.php?id=51076edit=1
[PHP-BUG] Bug #54205 [NEW]: race condition in shtool's mkdir -p implementation. AND shtool 2.0.8
From: Operating system: Linux PHP version: trunk-SVN-2011-03-09 (SVN) Package: Compile Failure Bug Type: Bug Bug description:race condition in shtool's mkdir -p implementation. AND shtool 2.0.8 Description: Previous bug #51076 http://bugs.php.net/bug.php?id=51076 was fixed by: svn commit r295225 ( http://svn.php.net/viewvc?view=revisionrevision=295225 ) but later, commit r295230 ( http://svn.php.net/viewvc? view=revisionrevision=295230) updated shtool to version 2.0.8 without backporting the previous patch. (In upstream, nothing changed regarding mkdir between 2.0.6 and 2.0.8) And so, the race condition with -j1 is still there. (In my case, it appeared during the make install step processing the installation of the extensions) Error was: mkdir: cannot create directory ... : File exists So, the patch in r295225 should be reapplied to shtool 2.0.8. In a second time, why not replacing all the mkdir code block of shtool by something like: if opt_p = no: mkdir ... chmod ... chown ... chgrp ... ... else: mkdir -p ... chmod -R ... chown -R ... chgrp -R ... ... That would be safer I think ... -- Edit bug report at http://bugs.php.net/bug.php?id=54205edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=54205r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=54205r=trysnapshot53 Try a snapshot (trunk): http://bugs.php.net/fix.php?id=54205r=trysnapshottrunk Fixed in SVN: http://bugs.php.net/fix.php?id=54205r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=54205r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=54205r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=54205r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=54205r=needscript Try newer version: http://bugs.php.net/fix.php?id=54205r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=54205r=support Expected behavior: http://bugs.php.net/fix.php?id=54205r=notwrong Not enough info: http://bugs.php.net/fix.php?id=54205r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=54205r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=54205r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=54205r=php4 Daylight Savings:http://bugs.php.net/fix.php?id=54205r=dst IIS Stability: http://bugs.php.net/fix.php?id=54205r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=54205r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=54205r=float No Zend Extensions: http://bugs.php.net/fix.php?id=54205r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=54205r=mysqlcfg
