Re: [Pingus-Devel] Level fix

2013-07-29 Thread Gabriel Rota
Hi,

2013/7/29 Tom Flavel 
>
> Really? patch(1) can eat a non-unified diff: patch -n -p1 < x.patch
>

Excellent!

The file you attached looks the same as my patch, with a few
> insignificant whitespace differences. Looks good to me.
>

The fix is pushed
https://code.google.com/p/pingus/source/detail?r=d52ba2e4492dd6808498f3a6d2236cddd690324f


Cheers,
Gabriel
___
Pingus-Devel mailing list
Pingus-Devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pingus-devel


Re: [Pingus-Devel] Level fix

2013-07-29 Thread Tom Flavel
On 29/07/2013 16:40:06, Gabriel Rota wrote:
> Hi,
> 
> thanks for the fix.
> I'm lazy and apply patch manually is bad...next time attach file or use
> unified diff patch file.

Really? patch(1) can eat a non-unified diff: patch -n -p1 < x.patch


> I'm not tested it, can you try if work as expected?
> Patched file is in attach.

The file you attached looks the same as my patch, with a few
insignificant whitespace differences. Looks good to me.

Thanks!

-- 
Tom

___
Pingus-Devel mailing list
Pingus-Devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pingus-devel


Re: [Pingus-Devel] Level fix

2013-07-29 Thread Gabriel Rota
Hi,

thanks for the fix.
I'm lazy and apply patch manually is bad...next time attach file or use
unified diff patch file.
I'm not tested it, can you try if work as expected?
Patched file is in attach.
I'll commit patched file on git
https://code.google.com/p/pingus/source/list after
your ok.

Cheers,
Gabriel


desert5-tflavel.pingus
Description: Binary data
___
Pingus-Devel mailing list
Pingus-Devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pingus-devel


[Pingus-Devel] Level fix

2013-07-25 Thread Tom Flavel
Hi,

I wrote a couple of levels a long time ago. I just had a look, and I see
one got modified over time, such that it ended up being quite different
from how it was origionally designed.

The idea was to have one of every action, and to only use each action
once. Spoiler: if you do it the way I did it - which I think is the
only way to do it - you should end up with one blocker, after all the
other penguins are rescued. Then you can explode him.

Anyway, I wondered if maybe somebody misunderstood how the level worked,
and modified it. Or maybe the game mechanics changed over time and
things got broken. Or maybe it got broken when converting from XML.

I added a "remove" groundpiece to make it more obvious than pingus
aren't supposed to be able to walk up the branch.

Here's a patch:

iona* diff desert/desert5-tflavel.pingus /tmp/desert5-tflavel.pingus 
15c15
<   (bomber 2)
---
>   (bomber 1)
18d17
<   (digger 1)
20c19,20
<   (jumper 1))
---
>   (jumper 1)
>   (miner 1))
91c91
<   (position 573 467 0))
---
>   (position 572 467 0))
103c103
<   (position 967 434 0))
---
>   (position 1059 436 0))
115c115
<   (position 683 195 0))
---
>   (position 676 186 0))
121c121
<   (position 357 336 0))
---
>   (position 343 336 0))
139c139
<   (position 1079 423 0))
---
>   (position 1116 424 0))
398a399,404
> (groundpiece 
>   (type "remove")
>   (surface 
> (image "groundpieces/remove/misc/rect1")
> (modifier "ROT0"))
>   (position 899 414 0))
iona*   

Regards,

-- 
Tom

___
Pingus-Devel mailing list
Pingus-Devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pingus-devel