D22818: Avoid crash if kicker plugin is used outside plasma context
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c423eb7f959c: Avoid crash if kicker plugin is used outside plasma context (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22818?vs=62773=63843 REVISION DETAIL https://phabricator.kde.org/D22818 AFFECTED FILES applets/kicker/plugin/appsmodel.cpp To: davidedmundson, #plasma, apol, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22818: Avoid crash if kicker plugin is used outside plasma context
apol added a comment. It could make sense to have a helper function to do this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22818 To: davidedmundson, #plasma, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22818: Avoid crash if kicker plugin is used outside plasma context
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code currently gets the applet interface object passed in explicitly, from this it gets the configuration via the metaobject system We always guard the appletConfig not being available, but never the appletInterface, resulting in crashes if used from qmlscene or any potential tests. TEST PLAN Used from qmlscene REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22818 AFFECTED FILES applets/kicker/plugin/appsmodel.cpp To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
