D26565: KCM/Component Revamp email config

2020-01-20 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d1f62c16c878: KCM/Component Revamp email config (authored 
by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73957=73959

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-20 Thread Méven Car 
meven updated this revision to Diff 73957.
meven added a comment.


  Avoid indentation level

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73948=73957

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-20 Thread Kevin Ottens 
ervin accepted this revision.
ervin added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:109
> +}
> +if (service) {
> +// avoid duplicates entry when email clients are present in 
> mimeapps.list's Added Associations too

I really meant if (!service) + continue to avoid yet another indentation level 
but OK, fair enough.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-20 Thread Méven Car 
meven updated this revision to Diff 73948.
meven marked 2 inline comments as done.
meven added a comment.


  Move static variable to a proper namespace block, refactor some code for 
clarity, fix selecting a newly selected email client

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73747=73948

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-20 Thread Kevin Ottens 
ervin added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:67
>  }
> +static const char s_AddedAssociations[] = "Added Associations";
> +static const auto s_mimetype = QStringLiteral("x-scheme-handler/mailto");

Not a huge fan of static consts appearing like this in the middle of the file. 
Could you please move them up before the ctor? Bonus point for putting them in 
the anonymous namespace.

> componentchooseremail.cpp:106
> +}
> +if (service &&
> +// avoid duplicates entry when email clients are present in 
> mimeapps.list's Added Associations too

To simplify reading this I'd go for:

  if (!service) {
  continue;
  }

and then I'd put the result of none_of in a properly named intermediate 
variable before checking it in its own if. Will make the intents clearer.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-17 Thread Méven Car 
meven updated this revision to Diff 73747.
meven marked an inline comment as done.
meven added a comment.


  Remove a bad line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73695=73747

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-17 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:144
> +// select newly inserted email client
> +m_currentIndex = emailClientsCombo->count() - 2;
> +emailClientsCombo->setCurrentIndex(m_currentIndex);

remove

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-16 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'm so sorry, this was my mistake. Somehow KMail got re-installed without my 
knowledge. Probably https://bugzilla.suse.com/show_bug.cgi?id=1035802 biting me 
again.
  
  Once I've removed it again, everything works perfectly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-16 Thread Méven Car 
meven added a comment.


  In D26565#595522 , @ngraham wrote:
  
  > Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I 
don't think that makes sense.
  
  
  Everything in the combobox comes from /usr/share/applications/*desktop  (or 
similar path) or mimeapps.list's "Added Applications"
  
  So Are you sure ?
  Does it have an icon ?
  Do you have a `/usr/share/applications/org.kde.kmail2.desktop` file ?
  Is kmail mentioned in ~/.config/mimeapps.list ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-16 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I 
don't think that makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-16 Thread Méven Car 
meven updated this revision to Diff 73695.
meven added a comment.


  Add a couple of const

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73548=73695

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-15 Thread Méven Car 
meven added a comment.


  In D26565#594353 , @ngraham wrote:
  
  > Let me know if and when this is reviewable, or if it's still WIP.
  
  
  This is good for review.
  
  I am now working towards preventing a potential issue :
  If a user set say thunderbird as default email client, (it will show up now 
in componentchooser) but KToolInvocation::invokeMailer will keep using the mail 
client set in emaildefaults.
  KToolInvocation::invokeMailer needs to use the parameter set in mimeapps.list.
  And fixing https://bugs.kde.org/show_bug.cgi?id=416257
  KService would need to be extended to better handle default scheme-handler, 
currently it does not follow specs : it does not use the "Default Application" 
section of mimeapps.list at all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-14 Thread Nathaniel Graham 
ngraham added a comment.


  Let me know if and when this is reviewable, or if it's still WIP.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-14 Thread Méven Car 
meven updated this revision to Diff 73548.
meven added a comment.


  clean some unused incudes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73547=73548

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-14 Thread Méven Car 
meven updated this revision to Diff 73547.
meven added a comment.


  Allow to select any app as email client, mimeapps.list preferred email is the 
source of truth regarding default mail client, depends on KF5.67 (post plasma 
5.18)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73375=73547

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D26565#592891 , @meven wrote:
  
  > It means we will need to write .desktop file on the fly which 
KOpenWithDialog can do.
  >  Do we want the previously entered commands to appear in the list ?
  
  
  I think so. We don't want to break anyone who's currently using this feature.
  
  In D26565#592891 , @meven wrote:
  
  > > The combobox could have an entry entitled "Terminal Program" and 
selecting that option would make the text field allowing you to enter a command 
appear next to the combobox.
  >
  > Or open a KOpenWithDialog window.
  
  
  Yeah that might be better.
  
  In D26565#592891 , @meven wrote:
  
  > >> That would mean we could regroup everything in one tab also just like 
other DE do.
  > > 
  > > Exactly. Then we don't need tabs at all.
  >
  > I will probably do this incrementaly, refactor UIs in all tabs, then get 
rid of tabs, because this will move quite a bit of code.
  
  
  Sounds like a plan! Thanks a bunch for tackling this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-13 Thread Méven Car 
meven added a comment.


  In D26565#591581 , @ngraham wrote:
  
  > In D26565#591542 , @meven wrote:
  >
  > > Do you mean, we should drop command line text fields, like we have in the 
terminal and browser section ? Only comboxbox ?
  >
  >
  > We don't want to lose this feature, but the text field that lets you choose 
a command doesn't need to be always visible, either.
  
  
  It means we will need to write .desktop file on the fly which KOpenWithDialog 
can do.
  Do we want the previously entered commands to appear in the list ?
  
  > The combobox could have an entry entitled "Terminal Program" and selecting 
that option would make the text field allowing you to enter a command appear 
next to the combobox.
  
  Or open a KOpenWithDialog window.
  
  > 
  > 
  >> That would mean we could regroup everything in one tab also just like 
other DE do.
  > 
  > Exactly. Then we don't need tabs at all.
  
  I will probably do this incrementaly, refactor UIs in all tabs, then get rid 
of tabs, because this will move quite a bit of code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-13 Thread Méven Car 
meven updated this revision to Diff 73375.
meven added a comment.


  Clean reference to unused and not existant .config/emails directory

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73212=73375

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-10 Thread Nathaniel Graham 
ngraham added a comment.


  In D26565#591542 , @meven wrote:
  
  > Do you mean, we should drop command line text fields, like we have in the 
terminal and browser section ? Only comboxbox ?
  
  
  We don't want to lose this feature, but the text field that lets you choose a 
command doesn't need to be always visible, either.
  
  The combobox could have an entry entitled "Terminal Program" and selecting 
that option would make the text field allowing you to enter a command appear 
next to the combobox.
  
  > That would mean we could regroup everything in one tab also just like other 
DE do.
  
  Exactly. Then we don't need tabs at all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-10 Thread Méven Car 
meven added a comment.


  In D26565#591535 , @ngraham wrote:
  
  > Very nice, I think this is the way to go, not only for this component but 
for the others too. We should drop the group box too because with only one 
item, there's no longer anything to group! :) We can just switch it out for a 
label to the left of the combobox.
  
  
  Do you mean, we should drop command line text fields, like we have in the 
terminal and browser section ? Only comboxbox ?
  I would be encline to do so.
  That would mean we could regroup everything in one tab also just like other 
DE do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-10 Thread Nathaniel Graham 
ngraham added a comment.


  Very nice, I think this is the way to go, not only for this component but for 
the others too. We should drop the group box too because with only one item, 
there's no longer anything to group! :) We can just switch it out for a label 
to the left of the combobox.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-10 Thread Méven Car 
meven updated this revision to Diff 73212.
meven added a comment.


  minor change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73211=73212

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

2020-01-10 Thread Méven Car 
meven created this revision.
meven added reviewers: ngraham, ervin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Simplify UI:
  
  - Select option in the available email clients

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart