D27807: Changed style of pressed list item to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove abandoned this revision.
niccolove added a comment.


  Actually, there is a proper way to do this. Gimme a sec.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns


D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Nathaniel Graham
ngraham added a comment.


  In D27807#621347 , @ndavis wrote:
  
  > It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.
  
  
  Because then people who are both subscribed to the mailing list and also 
members/watchers of the #plasma  group 
get two emails for every comment/change/update/etc.
  
  Anyway, it seems like we generally need to rethink these states. I think 
KRunner should be used as the model for how to have both visually distinct and 
visually pleasing hovered and pressed states.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns


D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a subscriber: plasma-devel.
ndavis added a comment.


  It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns