D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham added a comment.


  Managed to re-introduce https://bugs.kde.org/show_bug.cgi?id=414045, so it 
looks like that's not related to this. Will fix it in another patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham updated this revision to Diff 82324.
ngraham added a comment.


  Move the config bar as the panel changes thickness

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29535?vs=82280&id=82324

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts 
abetts added a comment.


  +1 from me!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham planned changes to this revision.
ngraham added a comment.


  Need to re-implement the panel thickness change handling

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham added a subscriber: ahiemstra.
ngraham added a comment.


  An idea brought up by @ahiemstra would be to add dragability into the SpinBox 
control itself, which was suggested in T9460 
 and would automatically 
re-implement/preserve draggability. I can look into that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham added a comment.


  In D29535#666303 , @abetts wrote:
  
  > I love this idea. I would request to keep the drag behavior and follow up 
with a second ticket to propose a change in the drag behavior for the panel.
  
  
  I considered that, but while implementing it and playing with the result I 
became less and less convinced that a drag-based interaction makes sense here. 
Dragging favors large movements where precision of the final result is not 
important, which is pretty much the opposite of how people adjust their panels.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham updated this revision to Diff 82280.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use less arbitrary min and max values

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29535?vs=82277&id=82280

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts 
abetts added a comment.


  I love this idea. I would request to keep the drag behavior and follow up 
with a second ticket to propose a change in the drag behavior for the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> ToolBar.qml:119-120
> +
> +from: 2
> +to: 960
> +stepSize: 2

These values seem arbitrary. Could it be possible to base off the screen 
dimensions?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We receive many complaints and bug reports about the current UI for adjusting 
panel
  thickness. People don't figure out that they have to drag on the button, and 
when they do,
  they complain that they can't set the value finely enough. Furthermore there 
are some bugs
  with scrolling and dragging behavior.
  
  This patch removes the draggable button and replaces it with a more 
conventional SpinBox,
  this is given scroll-adjustment behaviors in D29534 
. This yields the following
  improvements:
  
  - The way you adjust panel thickness is now more obvious
  - Fine-tuning panel thickness is now easier
  - Panel thickness can now be specified numerically
  - We have one fewer custom control to maintain
  - Bugs in custom scrolling implementation go away
  
  The current click/touch-and-drag behavior is therefore removed. I think this 
is acceptable
  because it's not a very good match for this use case anyway; a drag-based UI 
favors large
  changes where precision of the final result is not important. This does not 
describe the
  panel adjustment use case where you are changing the value by at most a few 
dozen and very
  commonly just want to adjust it up or down a tiny amount or want to end up at 
a specific
  size.
  
  BUG: 414045
  BUG: 418700
  BUG: 421169
  FIXED-IN: 5.19

TEST PLAN
  F8300568: Horizontal panel.webm 
  F8300567: Vertical panel.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart