D9462: KCM: show scaled outputs correctly
sebas added a comment. @dvratil that's much appreciated (I made that same mistake ;-)) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
dvratil added a comment. Indeed, I'll rework the whole scaling thing to abstract away the difference between scaling in Wayland and in X11 including the UI side (it's not related to the OSD changes, I'm just trying to work around my silly decision to get a hi-dpi monitor alongside a regular one) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
sebas added a comment. I agree with David, scaling the output makes the previewed "device" smaller. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
davidedmundson added a comment. If I have a 2000x2000 montior at scale 2 I want it to appear the same size as a 1000x1000 monitor at scale 1. Or in other terms: We want to see things at their logical size, not their device size. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
dvratil added a comment. If mode reports resolution 1920x1080, but the screen is scaled by 2, then we want to show the output rectangle in KCM to be 3840x2160 so that it's in the correct ratio. If you put the scaled output next to a HiDPI output (3840x2160) in the KCM the rectangles should both be the same size. Hence the multiplication. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. iIf we have your patch with the scaled modes, then we woudln't need to divide here, sure. But why would we multiply it?? The size should be the size in normalised space. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
dvratil added a dependency: D9461: Report modes unscaled and geometry scaled. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9462: KCM: show scaled outputs correctly
dvratil created this revision. dvratil added reviewers: sebas, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since the change in libkscreen modes are now always unscaled, so there's no need to divide them by the scale factor. Instead, we actually want them shown scaled appropriately in the UI so that user can see how the screens will look in the correct ratio. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 AFFECTED FILES kcm/src/declarative/qmloutput.cpp To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
