Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Playlist reordering used to work only in one direction i.e you could only drag a media to somewhere below it's current index. After this patch it will work both ways. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 Diff: https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/#review52257 --- Ship it! Ship It! - Shantanu Tushar On March 6, 2014, 6:26 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116626/ > --- > > (Updated March 6, 2014, 6:26 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Playlist reordering used to work only in one direction i.e you could only > drag a media to somewhere below it's current index. After this patch it will > work both ways. > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp 9c1dea9 > > Diff: https://git.reviewboard.kde.org/r/116626/diff/ > > > Testing > --- > > Reordered a playlist both ways. > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/#review52258 --- This review has been submitted with commit 86f20ec9a746efb0add1de56e44bc5064de45a53 by Shantanu Tushar to branch master. - Commit Hook On March 6, 2014, 6:26 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116626/ > --- > > (Updated March 6, 2014, 6:26 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Playlist reordering used to work only in one direction i.e you could only > drag a media to somewhere below it's current index. After this patch it will > work both ways. > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp 9c1dea9 > > Diff: https://git.reviewboard.kde.org/r/116626/diff/ > > > Testing > --- > > Reordered a playlist both ways. > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/ --- (Updated March 6, 2014, 2:20 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Playlist reordering used to work only in one direction i.e you could only drag a media to somewhere below it's current index. After this patch it will work both ways. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 Diff: https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
