[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland
xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > > method for Qt. > > That's totally fine in this case. It only affects KWin and KWin doesn't have > any text input fields. > > > IMHO for wayland there should be a wayland specific im module that talk to > > input method via wl_text. > > QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think > that's exactly what you want. > > > And X11 app should use a different QT_IM_MODULE. > > Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all. Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the session I wonder if it will be inherit by the whole desktop session. REPOSITORY rKWIN KWin BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: xuetianweng, sebas, mart, broulik, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D1638: Integrate QtVirtualKeyboard into KWin/Wayland
xuetianweng added inline comments.
INLINE COMMENTS
> main_wayland.cpp:449
> qunsetenv("QT_DEVICE_PIXEL_RATIO");
> -qunsetenv("QT_IM_MODULE");
> +qputenv("QT_IM_MODULE", "qtvirtualkeyboard");
> qputenv("QSG_RENDER_LOOP", "basic");
Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method
for Qt.
IMHO for wayland there should be a wayland specific im module that talk to
input method via wl_text.
And X11 app should use a different QT_IM_MODULE.
FYI: https://fcitx-im.org/wiki/Input_method_related_environment_variables
REPOSITORY
rKWIN KWin
BRANCH
virtual-keyboard
REVISION DETAIL
https://phabricator.kde.org/D1638
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland
xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > I don't understand the concern. The QT_IM_MODULE env variable set here in the > code only affects KWin. It is not passed to any other process. > > Setting QT_IM_MODULE env variables will still overwrite everything - except > in KWin where the variable is pointless. So nothing changes except by default > KWin can now offer a virtual keyboard. Ah, ok, I misunderstood that this will inherit by session since I thought kwin start the script exit-with-session. But then I still have one minor concern, for any window that actually inside kwin (e.g. right click on title bar -> window specific settings), the input method will be forced to qtvirtualkeyboard. Though I know input method is not commonly being used there, but I don't think that's expected behavior for input method user. REPOSITORY rKWIN KWin BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: xuetianweng, sebas, mart, broulik, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D2000: Make it possible to adjust volume even if it's muted
xuetianweng marked an inline comment as done. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2000 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 8 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng updated this revision to Diff 4779. xuetianweng added a comment. change it against master REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4749=4779 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1998: Make sure to unmute when changing volume with hotkeys
xuetianweng accepted this revision. xuetianweng added a comment. This revision is now accepted and ready to land. LGTM tested on my desktop. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1998 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, xuetianweng Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 7 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng updated this revision to Diff 4714. xuetianweng added a comment. also do the same thing to kcm's slider REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4713=4714 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2000: Make it possible to adjust volume even if it's muted
xuetianweng added inline comments. INLINE COMMENTS > drosca wrote in VolumeSlider.qml:44 > It should also change opacity when muted here. I'd rather not, because this is widget style, and disable style is actually "grey out". REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2000 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2000: Make it possible to adjust volume even if it's muted
xuetianweng added a comment. In https://phabricator.kde.org/D2000#36954, @drosca wrote: > The same is in applet, disabled slider is greyed out. And Jens has a point here, it would be better if we come up with a different way to visualize muted stream without changing opacity of sliders (if we want to make them interactive when muted). Actually now I looked at the one in windows, probably opacity makes sense. Shall we do it this way (set opacity) for now, since this is not only about visual but also functionality REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2000 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 8 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng updated this revision to Diff 4749. xuetianweng added a comment. also apply opacity to kcm's slider REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4714=4749 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng created this revision. xuetianweng added a reviewer: drosca. xuetianweng added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Do not disable the slider if it's muted. It would be more convinient if it's possible to change muted item volume, just like other mixers. Also unmute the device/stream if it's muted at the same time. Unfortunately, I didn't find a way to pretend to be visually disabled, thus here we use opacity to get the similar visual feedback. TEST PLAN test on my desktop REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1094: [KRunner] Don't override user input in history
xuetianweng accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1094 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, xuetianweng Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 7 lines] D1075: Display mouse image in mouse kcm properly on highdpi screen
xuetianweng created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1075 AFFECTED FILES kcms/input/mouse.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1075: Display mouse image in mouse kcm properly on highdpi screen
xuetianweng added reviewers: broulik, apol. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, broulik, apol Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D2000: Make it possible to adjust volume even if it's muted
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA3f4e449de8bf: Make it possible to adjust volume even if it's muted (authored by xuetianweng). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4779=4816 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D3184: Bring potd wallpaper back to life.
xuetianweng added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng added a dependent revision: D3184: Bring potd wallpaper back to life.. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3184: Bring potd wallpaper back to life.
xuetianweng added a dependency: D3183: Port potd (picture of the day) dataengine to KF5.. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 345 lines] D3184: Bring potd wallpaper back to life.
xuetianweng created this revision. xuetianweng added a reviewer: mart. xuetianweng added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Port the potd wallpaper plugin to KF5/QML. TEST PLAN Test manually with plasmashell REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3184 AFFECTED FILES wallpapers/potd/contents/config/main.xml wallpapers/potd/contents/ui/config.qml wallpapers/potd/contents/ui/main.qml wallpapers/potd/metadata.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 564 lines] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng created this revision. xuetianweng added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Osei site was discontinued, replace it with its successor which is also from NOAA. Also fix flickr, wikipedia, national geography provider, which are broken becauses of changes from providers. Use KPluginLoader to load plugin instead of KServiceTypeTrader. TEST PLAN Manually with plasmaengineexplorer REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3183 AFFECTED FILES CMakeLists.txt dataengines/CMakeLists.txt dataengines/potd/CMakeLists.txt dataengines/potd/PoTD-list.txt dataengines/potd/apodprovider.cpp dataengines/potd/cachedprovider.cpp dataengines/potd/epodprovider.cpp dataengines/potd/flickrprovider.cpp dataengines/potd/flickrprovider.h dataengines/potd/natgeoprovider.cpp dataengines/potd/noaaprovider.cpp dataengines/potd/noaaprovider.desktop dataengines/potd/noaaprovider.h dataengines/potd/oseiprovider.cpp dataengines/potd/oseiprovider.desktop dataengines/potd/oseiprovider.h dataengines/potd/plasma_potd_export.h dataengines/potd/potd.cpp dataengines/potd/potd.h dataengines/potd/potdprovider.h dataengines/potd/wcpotdprovider.cpp wallpapers/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 346 lines] D3184: Bring potd wallpaper back to life.
xuetianweng updated this revision to Diff 7712. xuetianweng added a comment. add missing change in CMakeLists.txt REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3184?vs=7711=7712 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3184 AFFECTED FILES wallpapers/CMakeLists.txt wallpapers/potd/contents/config/main.xml wallpapers/potd/contents/ui/config.qml wallpapers/potd/contents/ui/main.qml wallpapers/potd/metadata.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng added inline comments. INLINE COMMENTS > mart wrote in wcpotdprovider.cpp:54 > other copy of invalid url emm.. I thought I fixed. nvm. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 571 lines] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng updated this revision to Diff 8083. xuetianweng marked 8 inline comments as done. xuetianweng added a comment. Update flickr api key and wiki potd url REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3183?vs=7710=8083 BRANCH arcpatch-D3183 REVISION DETAIL https://phabricator.kde.org/D3183 AFFECTED FILES CMakeLists.txt dataengines/CMakeLists.txt dataengines/potd/CMakeLists.txt dataengines/potd/PoTD-list.txt dataengines/potd/apodprovider.cpp dataengines/potd/cachedprovider.cpp dataengines/potd/epodprovider.cpp dataengines/potd/flickrprovider.cpp dataengines/potd/flickrprovider.h dataengines/potd/natgeoprovider.cpp dataengines/potd/noaaprovider.cpp dataengines/potd/noaaprovider.desktop dataengines/potd/noaaprovider.h dataengines/potd/oseiprovider.cpp dataengines/potd/oseiprovider.desktop dataengines/potd/oseiprovider.h dataengines/potd/plasma_potd_export.h dataengines/potd/potd.cpp dataengines/potd/potd.h dataengines/potd/potdprovider.h dataengines/potd/wcpotdprovider.cpp wallpapers/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3372: Remove Webkit usage in potd data engine.
xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.
xuetianweng updated the summary for this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.
xuetianweng updated the summary for this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3183: Port potd (picture of the day) dataengine to KF5.
xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3184: Bring potd wallpaper back to life.
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS8f1310dd1e9a: Bring potd wallpaper back to life. (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3184?vs=7712=8180#toc REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3184?vs=7712=8180 REVISION DETAIL https://phabricator.kde.org/D3184 AFFECTED FILES wallpapers/potd/contents/config/main.xml wallpapers/potd/contents/ui/config.qml wallpapers/potd/contents/ui/main.qml wallpapers/potd/metadata.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D3372: Remove Webkit usage in potd data engine.
xuetianweng added a subscriber: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.
xuetianweng created this revision. xuetianweng added reviewers: mart, hein, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For natgeoprovider, since the page it can be accepted by QXmlStreamReader to get required content, we simple parse it as XML (HTML is NOT necessarily valid XML). For noaaprovider, QXmlStreamReader will hit an error in the middle of parsing so we use regular expression to extract the url. TEST PLAN Manually test with plasmashell REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3372 AFFECTED FILES CMakeLists.txt dataengines/potd/CMakeLists.txt dataengines/potd/natgeoprovider.cpp dataengines/potd/natgeoprovider.h dataengines/potd/noaaprovider.cpp dataengines/potd/noaaprovider.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71988, @graesslin wrote: > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > > > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel > > > > > > I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey. > > > Which "event"? search XIPropertyEvent in xlibnotifications.cpp For whatever reason, that part of code is not reached if it is triggered by global hotkey with current code, the display pointer is not shared with anyone.. I really don't understand why adding a new one helps, but it does help. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connection and event handling. At that time the xinput in xcb is incomplete and buggy so XLib is the only choice. Not sure if things change now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 31 lines] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng created this revision. xuetianweng added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason, the XI event is not received if the change is from global shortcut. This makes global shortcut always disable the touchpad because kded5 never aware it is disabled. This simple workaround may fix it. CCBUG:370588 TEST PLAN Manually test with global shortcut. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3829 AFFECTED FILES kcms/touchpad/src/backends/x11/xlibbackend.cpp kcms/touchpad/src/backends/x11/xlibnotifications.cpp kcms/touchpad/src/backends/x11/xlibnotifications.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71724, @knambiar wrote: > Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to confirm it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey. The Display* used in touchpad kded is already a separated one instead of Qt's, so I don't know if there's any interference between them. If someone could highlight me about what is the real cause of this I'd appreciated it. My guess is that it could be caused by mix Xinput call on the same display and there's some interference. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
