[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243684#comment-15243684 ] ASF subversion and git services commented on PROTON-1153: - Commit 9be087df797229fb025d6d9cdd96ca1051d15596 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9be087d ] PROTON-1153: [C++ binding] Change message member names: - address -> to (retaining address as an alias) - application_properties -> properties > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231106#comment-15231106 ] ASF subversion and git services commented on PROTON-1153: - Commit ac5d3c6871fed288cec36f8a7d9473a14033dfe7 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ac5d3c6 ] PROTON-1153: [C++ binding] Remove all data members from proton_handler - It's now a pure interface - This does mean that you currently create more pn_handler_t structs than before, but they could be cached somewhere else. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219039#comment-15219039 ] ASF subversion and git services commented on PROTON-1153: - Commit c7dff22d4d4ab05ffd7f6375bfa64222fc148a05 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7dff22 ] PROTON-1153, PROTON-1153: [C++ binding] Align code with API doc - Remove sender/receiver/session member functions no longer needed - Removed sasl member functions not needed - Made private some sasl member functions that shouldn't be exposed to API - Made condition and sasl object not user creatable or copyable > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219040#comment-15219040 ] ASF subversion and git services commented on PROTON-1153: - Commit c7dff22d4d4ab05ffd7f6375bfa64222fc148a05 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7dff22 ] PROTON-1153, PROTON-1153: [C++ binding] Align code with API doc - Remove sender/receiver/session member functions no longer needed - Removed sasl member functions not needed - Made private some sasl member functions that shouldn't be exposed to API - Made condition and sasl object not user creatable or copyable > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202005#comment-15202005 ] ASF subversion and git services commented on PROTON-1153: - Commit 045768b4171c5f0f9129669a57ed9e9ca72c88fc in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=045768b ] PROTON-1153: [C++ binding] Stop exporting symbols for overridable handler virtuals > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202236#comment-15202236 ] ASF subversion and git services commented on PROTON-1153: - Commit 2390f77ecd0e6cc04b347daceaff98865c8b8883 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2390f77 ] Revert "PROTON-1153: [C++ binding] Stop exporting symbols for overridable handler virtuals" This seems to break the Visual Studio build (not sure why, reverting whilst I investigate) This reverts commit 045768b4171c5f0f9129669a57ed9e9ca72c88fc. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178496#comment-15178496 ] ASF subversion and git services commented on PROTON-1153: - Commit 500f3597cea11fea461aa24d1232ac9f096f74c3 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=500f359 ] PROTON-1153: Settle on what() as name for printable condition summary. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178373#comment-15178373 ] ASF subversion and git services commented on PROTON-1153: - Commit 5d106e15ccbc05677ca5edca38ae6db0837d13f8 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5d106e1 ] PROTON-1153: Fix VS 2010 dll export problem > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176349#comment-15176349 ] ASF subversion and git services commented on PROTON-1153: - Commit 1832e326900b2cffd9dac71040dd44468b55674c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1832e32 ] PROTON-1153: [C++ binding] Finish renaming PN_... -> PN_CPP_... - Fix Windows compiler feature detection > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176318#comment-15176318 ] ASF subversion and git services commented on PROTON-1153: - Commit 2a8bc3c142c8543582ae56ca41ed5982018c6144 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2a8bc3c ] PROTON-1153: [C++ binding] Clean up #defines - Rename the C++ binding defines to be PN_CPP_... > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175807#comment-15175807 ] ASF subversion and git services commented on PROTON-1153: - Commit 3b62bf91b8fb12ec47f0062a8b0720e820555775 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3b62bf9 ] PROTON-1153: [C++ binding] Tidy up link - This involved some tidying up of delivery and message too > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175806#comment-15175806 ] ASF subversion and git services commented on PROTON-1153: - Commit e3e1d7da55b859f17935c5d3ad32ea826fed1294 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e3e1d7d ] PROTON-1153: [C++ binding] Tidy up proton::handler > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175805#comment-15175805 ] ASF subversion and git services commented on PROTON-1153: - Commit f55a67be88208d315410e2c4a297dd4e597626eb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f55a67b ] PROTON-1152, PROTON-1153: [C++ binding] Tidy up Header files API docs, and API - Make constructors for type wrapping proton-c types private as they are only to be used internally. - Allow default construction of the wrapper types so the use can declare a variable of the type that is not yet assigned. - Ensure that no private functions have exported symbols. - Small doc improvements > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175808#comment-15175808 ] ASF subversion and git services commented on PROTON-1153: - Commit d758832dd7341f786617502ace6cc0f0f08cc140 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d758832 ] PROTON-1153: [C+ binding] Made reactor an internal class - Moved header file from exported headers to internal source - Reworked reconnect_timer to not use reactor at all > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)