Re: [ptxdist] [PATCH 1/3] rules: Remove default assignments to _PATH and _ENV
On Tue, Oct 18, 2022 at 09:48:34AM +0200, Michael Olbrich wrote: > On Mon, Oct 17, 2022 at 09:59:04PM +0200, Ladislav Michl wrote: > > From: Ladislav Michl > > > > Undefined _PATH is set to PATH=$(CROSS_PATH) for target packages, > > PATH=$(HOST_PATH) for host packages and PATH=$(HOST_CROSS_PATH) for > > cross packages. > > > > Undefined _ENV is set to $(CROSS_ENV) for target packages, > > $(HOST_ENV) for host packages and $(HOST_CROSS_ENV) for cross > > packages. > > Hmmm, _ENV is also used in the install stage and it has no default > here. But it's not used in the compile stage. In general I think those two > stages should have the default environment. So if this breaks something, > then it was probably somewhat broken anyways. > I'll throw in in my 'build everything' test. Let's see what happens here. Thank you, it was meant as preparation for _AUTOCONF removal patch where _CONF_ENV is used when needed. _AUTOCONF and _ENV are two heavily used deprecated variables. There are few _MAKEVARS and _COMPILE_ENV left. I can prepare patch to replace them, so we can bail out with error after some transitional period. l. > Michael
Re: [ptxdist] [PATCH 1/3] rules: Remove default assignments to _PATH and _ENV
On Mon, Oct 17, 2022 at 09:59:04PM +0200, Ladislav Michl wrote: > From: Ladislav Michl > > Undefined _PATH is set to PATH=$(CROSS_PATH) for target packages, > PATH=$(HOST_PATH) for host packages and PATH=$(HOST_CROSS_PATH) for > cross packages. > > Undefined _ENV is set to $(CROSS_ENV) for target packages, > $(HOST_ENV) for host packages and $(HOST_CROSS_ENV) for cross > packages. Hmmm, _ENV is also used in the install stage and it has no default here. But it's not used in the compile stage. In general I think those two stages should have the default environment. So if this breaks something, then it was probably somewhat broken anyways. I'll throw in in my 'build everything' test. Let's see what happens here. Michael > Remove those default assignments. > > Signed-off-by: Ladislav Michl > --- > rules/argtable2.make | 3 --- > rules/bash.make | 1 - > rules/bc.make| 3 --- > rules/boost.make | 1 - > rules/bustle.make| 1 - > rules/cairomm.make | 3 --- > rules/calibrator.make| 1 - > rules/classpath.make | 1 - > rules/daemonize.make | 3 --- > rules/dash.make | 3 --- > rules/dbench.make| 1 - > rules/diffutils.make | 3 --- > rules/efax.make | 1 - > rules/etherwake.make | 3 --- > rules/eventlog.make | 3 --- > rules/failmalloc.make| 3 --- > rules/fbtest.make| 1 - > rules/fbutils.make | 1 - > rules/fftw.make | 3 --- > rules/findutils.make | 2 -- > rules/frodo.make | 1 - > rules/glibmm.make| 3 --- > rules/gnuplot.make | 3 --- > rules/grub.make | 2 -- > rules/haserl.make| 3 --- > rules/heirloom-mailx.make| 1 - > rules/host-libgd.make| 3 --- > rules/host-libpng.make | 3 --- > rules/host-libpthread-stubs.make | 3 --- > rules/host-libsigcpp.make| 3 --- > rules/host-libxml2.make | 3 --- > rules/host-libxslt.make | 3 --- > rules/host-pelts.make| 3 --- > rules/host-tz-database.make | 1 - > rules/host-xorg-app-bdftopcf.make| 3 --- > rules/host-xorg-app-mkfontscale.make | 3 --- > rules/host-xorg-font-util.make | 3 --- > rules/host-xorg-lib-Xfont.make | 3 --- > rules/host-xorg-lib-fontenc.make | 3 --- > rules/host-xorg-lib-xtrans.make | 3 --- > rules/hpanel.make| 1 - > rules/hping.make | 1 - > rules/hwdata.make| 3 --- > rules/inotify-tools.make | 3 --- > rules/iperf.make | 3 --- > rules/jamvm.make | 3 --- > rules/jed.make | 1 - > rules/joe.make | 3 --- > rules/kernel-header.make | 2 -- > rules/killproc.make | 3 --- > rules/krb5.make | 1 - > rules/libcaca.make | 1 - > rules/libcgi.make| 3 --- > rules/libcgicc.make | 3 --- > rules/libconfuse.make| 3 --- > rules/libdaemon.make | 3 --- > rules/libftdi.make | 3 --- > rules/libgd.make | 3 --- > rules/libgsloop.make | 3 --- > rules/libid3tag.make | 3 --- > rules/libiodbc.make | 2 -- > rules/liblist.make | 3 --- > rules/liblockfile.make | 2 -- > rules/libltdl.make | 1 - > rules/liblzo.make| 3 --- > rules/libmad.make| 3 --- > rules/libmng.make| 3 --- > rules/libpthread-stubs.make | 3 --- > rules/librn.make | 3 --- > rules/librsvg.make | 3 --- > rules/libsigcpp.make | 3 --- > rules/libssh2.make | 3 --- > rules/libsysfs.make | 3 --- > rules/libucdaemon.make | 3 --- > rules/libusb-compat.make | 3 --- > rules/libxml2.make | 3 --- > rules/libxmlconfig.make | 3 --- > rules/links.make | 3 --- > rules/lsuio.make | 3 --- > rules/ltt-control.make | 3 --- > rules/madplay.make | 3 --- >
[ptxdist] [PATCH 1/3] rules: Remove default assignments to _PATH and _ENV
From: Ladislav Michl Undefined _PATH is set to PATH=$(CROSS_PATH) for target packages, PATH=$(HOST_PATH) for host packages and PATH=$(HOST_CROSS_PATH) for cross packages. Undefined _ENV is set to $(CROSS_ENV) for target packages, $(HOST_ENV) for host packages and $(HOST_CROSS_ENV) for cross packages. Remove those default assignments. Signed-off-by: Ladislav Michl --- rules/argtable2.make | 3 --- rules/bash.make | 1 - rules/bc.make| 3 --- rules/boost.make | 1 - rules/bustle.make| 1 - rules/cairomm.make | 3 --- rules/calibrator.make| 1 - rules/classpath.make | 1 - rules/daemonize.make | 3 --- rules/dash.make | 3 --- rules/dbench.make| 1 - rules/diffutils.make | 3 --- rules/efax.make | 1 - rules/etherwake.make | 3 --- rules/eventlog.make | 3 --- rules/failmalloc.make| 3 --- rules/fbtest.make| 1 - rules/fbutils.make | 1 - rules/fftw.make | 3 --- rules/findutils.make | 2 -- rules/frodo.make | 1 - rules/glibmm.make| 3 --- rules/gnuplot.make | 3 --- rules/grub.make | 2 -- rules/haserl.make| 3 --- rules/heirloom-mailx.make| 1 - rules/host-libgd.make| 3 --- rules/host-libpng.make | 3 --- rules/host-libpthread-stubs.make | 3 --- rules/host-libsigcpp.make| 3 --- rules/host-libxml2.make | 3 --- rules/host-libxslt.make | 3 --- rules/host-pelts.make| 3 --- rules/host-tz-database.make | 1 - rules/host-xorg-app-bdftopcf.make| 3 --- rules/host-xorg-app-mkfontscale.make | 3 --- rules/host-xorg-font-util.make | 3 --- rules/host-xorg-lib-Xfont.make | 3 --- rules/host-xorg-lib-fontenc.make | 3 --- rules/host-xorg-lib-xtrans.make | 3 --- rules/hpanel.make| 1 - rules/hping.make | 1 - rules/hwdata.make| 3 --- rules/inotify-tools.make | 3 --- rules/iperf.make | 3 --- rules/jamvm.make | 3 --- rules/jed.make | 1 - rules/joe.make | 3 --- rules/kernel-header.make | 2 -- rules/killproc.make | 3 --- rules/krb5.make | 1 - rules/libcaca.make | 1 - rules/libcgi.make| 3 --- rules/libcgicc.make | 3 --- rules/libconfuse.make| 3 --- rules/libdaemon.make | 3 --- rules/libftdi.make | 3 --- rules/libgd.make | 3 --- rules/libgsloop.make | 3 --- rules/libid3tag.make | 3 --- rules/libiodbc.make | 2 -- rules/liblist.make | 3 --- rules/liblockfile.make | 2 -- rules/libltdl.make | 1 - rules/liblzo.make| 3 --- rules/libmad.make| 3 --- rules/libmng.make| 3 --- rules/libpthread-stubs.make | 3 --- rules/librn.make | 3 --- rules/librsvg.make | 3 --- rules/libsigcpp.make | 3 --- rules/libssh2.make | 3 --- rules/libsysfs.make | 3 --- rules/libucdaemon.make | 3 --- rules/libusb-compat.make | 3 --- rules/libxml2.make | 3 --- rules/libxmlconfig.make | 3 --- rules/links.make | 3 --- rules/lsuio.make | 3 --- rules/ltt-control.make | 3 --- rules/madplay.make | 3 --- rules/memedit.make | 3 --- rules/memtest86p.make| 1 - rules/memtester.make | 1 - rules/mii-diag.make | 3 --- rules/module-init-tools.make | 2 -- rules/mtr.make | 3 --- rules/netkit-ftp.make| 2 -- rules/ntpclient.make | 1 - rules/pangomm.make | 3 --- rules/pcmciautils.make | 3 --- rules/pelts_tests.make | 3 --- rules/pnputils.make | 7 ---
