Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  closed 
 Milestone:  |   Component:  core   
Resolution:  fixed   |Keywords: 
-+--
Changes (by zonque):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 I closed this patch now. I'm actively developing PA on OS X now and these
 problems don't seem to exist anymore. If anyone still sees issues, feel
 free to re-open.

 Daniel

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
 Milestone:  |   Component:  core   
Resolution:  |Keywords: 
-+--

Comment(by lennart):

 PA in git now checks for support of Wl,-z,nodelete. And uses it only when
 it exists. This half-way fixes this, but ideally on MacOS we had something
 that makes sure that the .sos are not unloaded either.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by Tron):

 The manual page of dlopen(3) mentions that open:

  RTLD_NODELETE   The specified image is tagged so that will never be
  removed from the address space, even after all
 clients
  have released it via dlclose()

 So it might be possible to use it.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by lennart):

 Sure, I know it's not ELF. That doesn't mean there is no equivalent for -z
 nodelete.

 Destructor functions unbfortunately are no option. We used them in the
 past and they are still used if you set $VALGRIND=1. The reason why they
 are not useful to us is that we have to deal with the case that a process
 exits while background threads that access pa structures are still
 running. The destructor functions will be called by the thread that calls
 exit() -- while the oher threads might still be running. Hence we cannot
 free all data structures they might still access. Except if we'd add a
 horrible and fragile and unportable locking logic just for this. This
 problem was exposed in the past in libcanberra  which may dynamically
 load/unload libpulse. The main program may call exit() at any time while a
 libcanberra thread might still be running. So using destructors resulted
 in segfaults in some cases. (Oh, and believe me this was hard to debug).
 The alternative, not using destructors is only viable if we have -z
 nodelete since otherwise we will leak memory each time we are pulled in
 via dlopen(). Which became very visible with libcanberra, too.

 So, I see no other option than having -z nodelete or some other similar
 option.

 Maybe it is possible to hack something based on dlopen(RTLD_NODELETE) for
 Macosx?

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by Tron):

 There is no equivalent of "-z nodelete" under Mac OS X. Please remember
 that it doesn't use the ELF binary format.

 And to be honest after reading what "-z nodelete" does I'm not convinced
 that using this option is a good idea in general. I would make more sense
 to use a destructor function that will make unloading the shared library
 or shared object safe.

 BTW: any problems with the patches for the C sources?

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by lennart):

 I commited those two patches in r04c3c67.

 Current git is a relatively big step forward and includes quite a few
 changes that might need porting. I'd recommend basing any porting work on
 current git master which will become .15 later next week.

 Not closing this bug, since there still needs to be found a way to replace
 -z nodelete sensibly on MacOS.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by lennart):

 hmm, indeed, i didn't backport the removals of those options to .14 when i
 did that release.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by Tron):

 My patches are for version 0.9.14, the latest release. And that version
 definitely uses these options.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by lennart):

 Uh, --gc-sections actually has been removed quite some time ago. Same is
 true for -no-undefined.

 Your patches are against which version of PA?

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #478: Fixes for build and run time problems under Mac OS X

[PulseAudio]

#478: Fixes for build and run time problems under Mac OS X
-+--
  Reporter:  Tron|   Owner:  lennart
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone: 
 Component:  core|Severity:  normal 
Resolution:  |Keywords: 
-+--
Comment (by lennart):

 Thanks for the patches.

 --gc-sections should probably be dropped anyway.

 The version script stuff is not that important, the same is true for -no-
 undefined. But -z nodelete *is* important. That flag controls whether
 libpulse is ever unloaded from a process' memory. I hope MacOS provides
 similar functionality by some other means.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets