Re: [pve-devel] qemu-server: address migrations issues
Hi, I don't have read the whole patches, but does it break migration from oldserver to newserver (with new code) ? - Mail original - De: "Thomas Lamprecht" À: "pve-devel" Envoyé: Mercredi 1 Juin 2016 12:09:38 Objet: [pve-devel] qemu-server: address migrations issues Changes since v2: - openssh is able to use UNIX socket forwards since 5.7 (and jessie has 5.7) so use that instead of socat. - split the part of child collection apart as it does not have antything to do with the tunnel problem ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
Hi, On 06/01/2016 02:50 PM, Alexandre DERUMIER wrote: > Hi, > > I don't have read the whole patches, > > but does it break migration from oldserver to newserver (with new code) ? Not with unsecure migrations. But yes with secure ones this would be the case, they would not crash but simply not work as the tcp tunnel is not made. We could actually support the old one for some time, even if it is broken (not our fault) as we see if we should open a tunnel or not, i.e. if the raddr is tcp and localhost then open a tcp tunnel like we did, if its tcp and not localhost its an unsecure and if its unix the do like in this patch. comments? > > > - Mail original - > De: "Thomas Lamprecht" > À: "pve-devel" > Envoyé: Mercredi 1 Juin 2016 12:09:38 > Objet: [pve-devel] qemu-server: address migrations issues > > Changes since v2: > - openssh is able to use UNIX socket forwards since 5.7 (and jessie has 5.7) > so use that instead of socat. > - split the part of child collection apart as it does not have antything to > do > with the tunnel problem > ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
>>We could actually support the old one for some time, even if it is broken >>(not our fault) as we see if we should open a tunnel or not, i.e. if the >>raddr is >>tcp and localhost then open a tcp tunnel like we did, if its tcp and not >>localhost its >>an unsecure and if its unix the do like in this patch. >> >>comments? yes, I think we should keep support for old migration, or I think users will complain ;) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" Cc: "aderumier" Envoyé: Mercredi 1 Juin 2016 15:03:05 Objet: Re: [pve-devel] qemu-server: address migrations issues Hi, On 06/01/2016 02:50 PM, Alexandre DERUMIER wrote: > Hi, > > I don't have read the whole patches, > > but does it break migration from oldserver to newserver (with new code) ? Not with unsecure migrations. But yes with secure ones this would be the case, they would not crash but simply not work as the tcp tunnel is not made. We could actually support the old one for some time, even if it is broken (not our fault) as we see if we should open a tunnel or not, i.e. if the raddr is tcp and localhost then open a tcp tunnel like we did, if its tcp and not localhost its an unsecure and if its unix the do like in this patch. comments? > > > - Mail original - > De: "Thomas Lamprecht" > À: "pve-devel" > Envoyé: Mercredi 1 Juin 2016 12:09:38 > Objet: [pve-devel] qemu-server: address migrations issues > > Changes since v2: > - openssh is able to use UNIX socket forwards since 5.7 (and jessie has 5.7) > so use that instead of socat. > - split the part of child collection apart as it does not have antything to > do > with the tunnel problem > ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
On 06/01/2016 03:37 PM, Alexandre DERUMIER wrote: >>> We could actually support the old one for some time, even if it is broken >>> (not our fault) as we see if we should open a tunnel or not, i.e. if the >>> raddr is >>> tcp and localhost then open a tcp tunnel like we did, if its tcp and not >>> localhost its >>> an unsecure and if its unix the do like in this patch. >>> >>> comments? > yes, I think we should keep support for old migration, or I think users will > complain ;) In fact it works on from not updated node to new, you just have to install (update) qemu-server with this patch on both then it works for and back on already running VMs. Its important to install it on all though. The way that it also works between different installed qemu-server versions would need to give the destination node an additional flag that we want to use a TCP tunnel. @Dietmar should that be done? I mean if they update qemu-server it works without it also and as a emergency fallback insecure can also be used. > > > - Mail original - > De: "Thomas Lamprecht" > À: "pve-devel" > Cc: "aderumier" > Envoyé: Mercredi 1 Juin 2016 15:03:05 > Objet: Re: [pve-devel] qemu-server: address migrations issues > > Hi, > > On 06/01/2016 02:50 PM, Alexandre DERUMIER wrote: >> Hi, >> >> I don't have read the whole patches, >> >> but does it break migration from oldserver to newserver (with new code) ? > Not with unsecure migrations. But yes with secure ones this would be the > case, they would not crash but simply not work as the tcp tunnel is not > made. > > We could actually support the old one for some time, even if it is broken > (not our fault) as we see if we should open a tunnel or not, i.e. if the > raddr is > tcp and localhost then open a tcp tunnel like we did, if its tcp and not > localhost its > an unsecure and if its unix the do like in this patch. > > comments? > > >> >> - Mail original - >> De: "Thomas Lamprecht" >> À: "pve-devel" >> Envoyé: Mercredi 1 Juin 2016 12:09:38 >> Objet: [pve-devel] qemu-server: address migrations issues >> >> Changes since v2: >> - openssh is able to use UNIX socket forwards since 5.7 (and jessie has 5.7) >> so use that instead of socat. >> - split the part of child collection apart as it does not have antything to >> do >> with the tunnel problem >> > ___ > pve-devel mailing list > pve-devel@pve.proxmox.com > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
> The way that it also works between different installed qemu-server > versions would need to give the destination node an additional flag that > we want to use a TCP tunnel. > > @Dietmar should that be done? I mean if they update qemu-server it works > without it also and as a emergency fallback insecure can also be used. I think migrate from old to new node should work. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
> > The way that it also works between different installed qemu-server > > versions would need to give the destination node an additional flag that > > we want to use a TCP tunnel. > > > > @Dietmar should that be done? I mean if they update qemu-server it works > > without it also and as a emergency fallback insecure can also be used. > > I think migrate from old to new node should work. @Alexandre: do you really need the other direction? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
>>@Alexandre: do you really need the other direction? No. Only old->new. I don't think that user try to migrate from new->old anyway. - Mail original - De: "dietmar" À: "Thomas Lamprecht" , "pve-devel" , "aderumier" Envoyé: Mercredi 1 Juin 2016 16:49:45 Objet: Re: [pve-devel] qemu-server: address migrations issues > > The way that it also works between different installed qemu-server > > versions would need to give the destination node an additional flag that > > we want to use a TCP tunnel. > > > > @Dietmar should that be done? I mean if they update qemu-server it works > > without it also and as a emergency fallback insecure can also be used. > > I think migrate from old to new node should work. @Alexandre: do you really need the other direction? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] qemu-server: address migrations issues
El 01/06/16 a las 17:01, Alexandre DERUMIER escribió: @Alexandre: do you really need the other direction? No. Only old->new. I don't think that user try to migrate from new->old anyway. Users try strange things, but I don't think a failure to migrate to older version would be a surprise. :-) old->new compat should be mantained in 4.x series, then in 4.x->5.x procedure note to first upgrade to latest 4.x (if adequate). Cheers Eneko -- Zuzendari Teknikoa / Director Técnico Binovo IT Human Project, S.L. Telf. 943493611 943324914 Astigarraga bidea 2, planta 6 dcha., ofi. 3-2; 20180 Oiartzun (Gipuzkoa) www.binovo.es ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel