[issue22845] Minor tweaks dis documentation
Roundup Robot added the comment: New changeset d676f2725699 by Serhiy Storchaka in branch '3.4': Issue #22845: Improved formatting of dis documentation. https://hg.python.org/cpython/rev/d676f2725699 New changeset ac0334665459 by Serhiy Storchaka in branch 'default': Issue #22845: Improved formatting of dis documentation. https://hg.python.org/cpython/rev/ac0334665459 New changeset 0a32764004ab by Serhiy Storchaka in branch '2.7': Issue #22845: Improved formatting of dis documentation. https://hg.python.org/cpython/rev/0a32764004ab -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22845 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22845] Minor tweaks dis documentation
Serhiy Storchaka added the comment: Done. Thank you Georg for your review. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22845 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
New submission from Mark Summerfield: When I try to build APSW (http://rogerbinns.github.io/apsw/index.html) with Python 3.3 or 3.4 on Debian stable 64-bit I get the error output shown below. I dug into the source and it seems that the problem is that distutils/ccompiler.py's gen_preprocess_options() functions expects to get a sequence of macros and each macro *must* be a 1 or 2 item tuple. But for some reason during the APSW build it gets a 2 item list which it then chokes on. Now, the code really does need a tuple because in some cases it uses Python's % print formatting option as in -D%s=%s % macro -- and this won't work if macro is a list. I solved this problem for me by adding two lines, shown here in context: pp_opts = [] for macro in macros: if isinstance(macro, list): # NEW macro = tuple(macro)# NEW I don't know how safe or wise a fix this is, but it did work for me for a locally built (from www.python.org tarball) 3.3 and 3.4. $ /home/mark/opt/python34/bin/python3 setup.py fetch --all build --enable-all-extensions install running fetch Getting download page to work out current SQLite version Fetching https://sqlite.org/download.html Version is 3.8.7.1 Getting the SQLite amalgamation Fetching https://sqlite.org/2014/sqlite-autoconf-3080701.tar.gz Length: 1998389 SHA1: 5601be1263842209d7c5dbf6128f1cc0b6bbe2e5 MD5: 8ee4541ebb3e5739e7ef5e9046e30063 Checksums verified Running configure to work out SQLite compilation flags setup.py:53: DeprecationWarning: 'U' mode is deprecated f=open(name, mode) running build running build_ext SQLite: Using amalgamation /home/mark/zip/apsw-3.8.7.1-r1/sqlite3/sqlite3.c setup.py:624: ResourceWarning: unclosed file _io.TextIOWrapper name=4 encoding='UTF-8' for part in shlex.split(os.popen(icu-config --cppflags, r).read()): setup.py:637: ResourceWarning: unclosed file _io.TextIOWrapper name=4 encoding='UTF-8' for part in shlex.split(os.popen(icu-config --ldflags, r).read()): ICU: Added includes, flags and libraries from icu-config building 'apsw' extension Traceback (most recent call last): File setup.py, line 862, in module 'win64hackvars': win64hackvars} File /home/mark/opt/python34/lib/python3.4/distutils/core.py, line 148, in setup dist.run_commands() File /home/mark/opt/python34/lib/python3.4/distutils/dist.py, line 955, in run_commands self.run_command(cmd) File /home/mark/opt/python34/lib/python3.4/distutils/dist.py, line 974, in run_command cmd_obj.run() File /home/mark/opt/python34/lib/python3.4/distutils/command/build.py, line 126, in run self.run_command(cmd_name) File /home/mark/opt/python34/lib/python3.4/distutils/cmd.py, line 313, in run_command self.distribution.run_command(command) File /home/mark/opt/python34/lib/python3.4/distutils/dist.py, line 974, in run_command cmd_obj.run() File setup.py, line 661, in run v=beparent.run(self) File /home/mark/opt/python34/lib/python3.4/distutils/command/build_ext.py, line 339, in run self.build_extensions() File /home/mark/opt/python34/lib/python3.4/distutils/command/build_ext.py, line 448, in build_extensions self.build_extension(ext) File /home/mark/opt/python34/lib/python3.4/distutils/command/build_ext.py, line 503, in build_extension depends=ext.depends) File /home/mark/opt/python34/lib/python3.4/distutils/ccompiler.py, line 566, in compile depends, extra_postargs) File /home/mark/opt/python34/lib/python3.4/distutils/ccompiler.py, line 341, in _setup_compile pp_opts = gen_preprocess_options(macros, incdirs) File /home/mark/opt/python34/lib/python3.4/distutils/ccompiler.py, line 1061, in gen_preprocess_options % macro) TypeError: bad macro definition '['_FORTIFY_SOURCE', '2']': each element of 'macros' list must be a 1- or 2-tuple -- components: Distutils messages: 231008 nosy: dstufft, eric.araujo, mark priority: normal severity: normal status: open title: distutils needlessly fails to build apsw type: behavior versions: Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22823] Use set literals instead of creating a set from a list
Larry Hastings added the comment: The patch is totally fine. I wonder why it was like that in the first place! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22823 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22843] doc error: 6.2.4. Match Objects
Georg Brandl added the comment: evaluates true should not be used in any case, the objects do not equal to True in any case. The phrase is considered true in a boolean context is already in the docs and could be used here too. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22843 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Ned Deily added the comment: Have you reported this problem to the author of apsw? It seems like figuring out why apsw is apparently creating an incorrect setup.py configuration should be a first step before suggesting a change to Distutils. You might want to supply the values from your system for: icu-config --cppflags icu-config --ldflags FWIW, with a current Debian testing, I get the following failure with either Python 3.4 or 2.7: running build_ext SQLite: Using amalgamation /tmp/e/apsw-3.8.7.1-r1/sqlite3/sqlite3.c ### icu-config: Can't find /usr/lib/i386-linux-gnu/libicuuc.so - ICU prefix is wrong. ### Try the --prefix= option ### or --detect-prefix ### (If you want to disable this check, use the --noverify option) ### icu-config: Exitting. ### icu-config: Can't find /usr/lib/i386-linux-gnu/libicuuc.so - ICU prefix is wrong. ### Try the --prefix= option ### or --detect-prefix ### (If you want to disable this check, use the --noverify option) ### icu-config: Exitting. ICU: Unable to determine includes/libraries for ICU using icu-config ICU: You will need to manually edit setup.py or setup.cfg to set them So there may be issues with icu-config on Debian. (Also, Python 3.3 is now in security-fix only mode.) -- nosy: +ned.deily versions: -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Ned Deily added the comment: Another data point: apsw appears to build OK on OS X with a MacPorts-supplied icu, including icu-config. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Mark Summerfield added the comment:
The first person I asked was the author of APSW (Roger Binns). He told me:
The ultimate cause of that is some interaction with the compilation
environment. Some sort of CFLAGS is ultimately ending up in some
Python code like above when it should be [ ('_FORTIFY_SOURCE', '2') ].
Note this is not part of the APSW source - it is something external.
I have seen it before when using the Ubuntu PPA build service. When
building locally everything was fine, but the build service injected
_FORTIFY_SOURCE like above and got it wrong. I presume your version
of Debian is doing something similar. Sadly I have no idea how to fix it.
So clearly he believes it is not a problem with his setup.py file.
Also, it strikes me as a bit unpythonic that a function should demand a
specific type (i.e., tuple) especially when this is just for the convenience of
being able to use % formatting.
I'm not asking or expecting you to add my change to distutils; but at least now
if someone encounters the same problem, they will have a potential fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22846
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Mark Summerfield added the comment: Here are the flags you asked for: $ icu-config --cppflags -D_FORTIFY_SOURCE=2 -D_REENTRANT -I/usr/include $ icu-config --ldflags -Wl,-z,relro -ldl -lm -L/usr/lib/x86_64-linux-gnu -licui18n -licuuc -licudata -ldl -lm -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22835] urllib2/httplib is rendering 400s for every authenticated-SSL request, suddenly
Antoine Pitrou added the comment: Le 11/11/2014 07:50, Dustin Oprea a écrit : Dustin Oprea added the comment: I think I was getting mixed results by using requests and urllib2/3. After nearly being driven crazy, I performed the following steps: 1. Recreated client certificates, and verified that the correct CA was being used from Nginx. 2. Experimenting using an SSL-wrapped client-socket directly, in tandem with s_client. 3. I then removed all of my virtualhosts except for a new one that pointed to a flat directory, just to make sure that I wasn't activating the wrong virtualhost, and there weren't any other complexities. 4. Implemented a bonafide, signed, SSL certificate on my local system, and overriding the hostname using /etc/hosts. 5. This got me past the 400. Ah! Perhaps your HTTPS setup was relying on SNI to select the proper virtual host ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Marc-Andre Lemburg added the comment: Shouldn't this be fixed in the APSW setup.py ? The patch is you are proposing looks harmless, but it can also mask programming errors in setup.py. -- nosy: +lemburg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Antoine Pitrou added the comment:
The ultimate cause of that is some interaction with the compilation
environment. Some sort of CFLAGS is ultimately ending up in some
Python code like above when it should be [ ('_FORTIFY_SOURCE', '2') ].
Note this is not part of the APSW source - it is something external.
That's as unhelpful as a bug report can get. If ICU doesn't provide the right
types, the setup.py should fix them up.
(assuming ICU provides the preprocessor flags here - I haven't check)
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22846
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Antoine Pitrou added the comment: I suggest closing. -- nosy: +ncoghlan resolution: - not a bug status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Ned Deily added the comment:
I was able to reproduce the behavior you saw with an older Debian system. The
following patch to the apsw setup.py file seems to fix the problem:
--- apsw-3.8.7.1-r1/setup.py2014-11-04 19:23:36.0 -0800
+++ apsw-3.8.7.1-r1_PATCHED/setup.py2014-11-11 02:01:16.0 -0800
@@ -628,7 +628,7 @@
elif part.startswith(-D):
part=part[2:]
if '=' in part:
-part=part.split('=', 1)
+part=tuple(part.split('=', 1))
else:
part=(part, '1')
ext.define_macros.append(part)
Also, requiring a tuple is the documented behavior of Distutils:
https://docs.python.org/2/distutils/apiref.html#distutils.core.Extension
I agree that the issue should be closed and am closing it.
--
stage: - resolved
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22846
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22846] distutils needlessly fails to build apsw
Mark Summerfield added the comment: I've notified APSW's author and I'm sure he'll fix it. Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22846 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18473] some objects pickled by Python 3.x are not unpicklable in Python 2.x because of incorrect REVERSE_IMPORT_MAPPING
Serhiy Storchaka added the comment: I think that both UserDict.UserDict and UserDict.IterableUserDict should be mapped to collections.UserDict. And reverse mapping should map collections.UserDict to UserDict.IterableUserDict. There are similar issues with other multiple to single mappings (e.g. to io, dbm, http.server). -- nosy: +serhiy.storchaka versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18473 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22407] re.LOCALE is nonsensical for Unicode
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22407 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20394] Coverity complains on audioop
Changes by Serhiy Storchaka storch...@gmail.com: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20394 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22407] re.LOCALE is nonsensical for Unicode
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Convert re tests to unittest ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22407 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22407] re.LOCALE is nonsensical for Unicode
Serhiy Storchaka added the comment: If there are no objections I'll commit the re_deprecate_unicode_locale.patch patch. But it would be good if someone will review doc changes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22407 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11820] idle3 shell os.system swallows shell command output
Serhiy Storchaka added the comment: What do you think about this patch Terry? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11820 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22827] Backport ensurepip to 2.7 (PEP 477)
Nick Coghlan added the comment: Thanks Donald, left some review comments on Reitveld. While I had some comments on the docs, I think the code changes all look fine - would it be worth incorporating this version immediately to make it easier to get started on the Windows and Mac OS X installer updates? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22827 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22827] Backport ensurepip to 2.7 (PEP 477)
Donald Stufft added the comment: I've updated the patch with Nick's comments, except for pulling in the latest versions of the documentation. -- Added file: http://bugs.python.org/file37175/pep-477-3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22827 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22827] Backport ensurepip to 2.7 (PEP 477)
Nick Coghlan added the comment: Thanks. I suggest committing that version, so the rest of the backport (installer integration packaging docs backport) can proceed in parallel. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22827 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22835] urllib2/httplib is rendering 400s for every authenticated-SSL request, suddenly
Dustin Oprea added the comment: I usually use both on my local system. Dustin On Nov 11, 2014 4:43 AM, Antoine Pitrou rep...@bugs.python.org wrote: Antoine Pitrou added the comment: Le 11/11/2014 07:50, Dustin Oprea a écrit : Dustin Oprea added the comment: I think I was getting mixed results by using requests and urllib2/3. After nearly being driven crazy, I performed the following steps: 1. Recreated client certificates, and verified that the correct CA was being used from Nginx. 2. Experimenting using an SSL-wrapped client-socket directly, in tandem with s_client. 3. I then removed all of my virtualhosts except for a new one that pointed to a flat directory, just to make sure that I wasn't activating the wrong virtualhost, and there weren't any other complexities. 4. Implemented a bonafide, signed, SSL certificate on my local system, and overriding the hostname using /etc/hosts. 5. This got me past the 400. Ah! Perhaps your HTTPS setup was relying on SNI to select the proper virtual host ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22834] Unexpected FileNotFoundError when current directory is removed
Changes by Brett Cannon br...@python.org: -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22834 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22840] strpdate('20141110', '%Y%m%d%H%S') returns wrong date
Brett Cannon added the comment: strptime very much follows the POSIX standard as I implemented strptime by reading that doc. If you want to see how the behaviour is implemented you can look at https://hg.python.org/cpython/file/ac0334665459/Lib/_strptime.py#l178 . But the key thing here is that the OP has unused formatters. Since strptime uses regexes underneath the hood, the re module does its best to match the entire format. Since POSIX says that e.g. the leading 0 for %m is optional, the regex goes with the single digit version to let the %H format match _something_ (same goes for %d and %M). So without rewriting strptime to not use regexes to support unused formatters and to stop being so POSIX-compliant, I don't see how to change the behaviour. Plus it would be backwards-incompatible as this is how strptime has worked in 2002. It's Alexander's call, but I vote to close this as not a bug. -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22840 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22840] strpdate('20141110', '%Y%m%d%H%S') returns wrong date
Alexander Belopolsky added the comment: After reading the standard a few more times, I agree with Brett and Ethan that this is at most a call for better documentation. I'll leave this open for a chance that someone will come up with a succinct description of what exactly datetime.strptime does. (Maybe we should just document the format to regexp translation implemented in _strptime.py.) We may also include POSIX's directive The application shall ensure that there is white-space or other non-alphanumeric characters between any two conversion specifications as a recommendation. -- assignee: - belopolsky components: +Documentation -Library (Lib) type: behavior - enhancement versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22840 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22827] Backport ensurepip to 2.7 (PEP 477)
Donald Stufft added the comment: Merged in https://hg.python.org/cpython/rev/592a5414fabd, I forgot to mention the issue number. I'm going to leave this open for the docs changes, however the OSX installer and Windows installer changes should be able to be made now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22827 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13444] closed stdout causes error on stderr when the interpreter unconditionally flushes on shutdown
Changes by Josh Lee jlee...@gmail.com: -- nosy: +jleedev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13444 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
New submission from Antoine Pitrou: The method cache is currently very small. Attached patch bumps the size a bit and improves the hash computation formula. -- components: Interpreter Core files: methcache.patch keywords: patch messages: 231031 nosy: pitrou, serhiy.storchaka priority: normal severity: normal status: open title: Improve method cache efficiency type: performance versions: Python 3.5 Added file: http://bugs.python.org/file37176/methcache.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
Antoine Pitrou added the comment: It's not easy to get stable benchmark runs, but here is an example: Report on Linux fsol 3.16.0-24-generic #32-Ubuntu SMP Tue Oct 28 13:07:32 UTC 2014 x86_64 x86_64 Total CPU cores: 4 ### 2to3 ### 7.083762 - 6.904087: 1.03x faster ### formatted_logging ### Min: 0.351515 - 0.330884: 1.06x faster Avg: 0.352954 - 0.332422: 1.06x faster Significant (t=62.94) Stddev: 0.00120 - 0.00197: 1.6382x larger ### mako_v2 ### Min: 0.035797 - 0.034659: 1.03x faster Avg: 0.036427 - 0.035378: 1.03x faster Significant (t=50.65) Stddev: 0.00032 - 0.00034: 1.0668x larger ### richards ### Min: 0.174242 - 0.163918: 1.06x faster Avg: 0.175643 - 0.165689: 1.06x faster Significant (t=58.69) Stddev: 0.00086 - 0.00084: 1.0168x smaller ### simple_logging ### Min: 0.300215 - 0.287112: 1.05x faster Avg: 0.301957 - 0.288785: 1.05x faster Significant (t=80.08) Stddev: 0.00086 - 0.00078: 1.1052x smaller The following not significant results are hidden, use -v to show them: django_v2, silent_logging, tornado_http. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22558] Missing hint to source code - complete
Alexander Belopolsky added the comment: +1 to add links to all the [Python] modules If the code is not readable, hard to understand or not self-documenting that's the reason to improve the code not to make it harder to find and see. -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22558 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
Serhiy Storchaka added the comment: Current hashing algorithm takes middle bits, proposed code takes low bits. Doesn't this make the hash worse? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22848] Subparser help does not respect SUPPRESS argument
New submission from Brett Hannigan:
When adding an argument to a subparser and passing help=argparse.SUPPRESS, I
would expect this argument to not show up when running help. Instead, I find
that the argument is listed and the help given is ==SUPPRESS==. For example
(also in attached python script):
import argparse
parser = argparse.ArgumentParser('test')
subparsers = parser.add_subparsers()
parser_foo = subparsers.add_parser('foo', help='This is help for foo')
parser_bar = subparsers.add_parser('bar', help=argparse.SUPPRESS)
parser.parse_args(['-h'])
usage: test [-h] {foo,bar} ...
positional arguments:
{foo,bar}
foo This is help for foo
bar ==SUPPRESS==
optional arguments:
-h, --help show this help message and exit
I believe I have found the proper fix in argparse.py
In the class _SubParsersAction look at the method add_parser().
There is the following block of code:
if 'help' in kwargs:
help = kwargs.pop('help')
choice_action = self._ChoicesPseudoAction(name, help)
self._choices_actions.append(choice_action)
This should instead check to see if help is SUPPRESS or not like so:
if 'help' in kwargs:
help = kwargs.pop('help')
if help != SUPPRESS:
choice_action = self._ChoicesPseudoAction(name, help)
self._choices_actions.append(choice_action)
If I make this change locally, then the above code does in fact suppress
printing the bar option.
--
components: Library (Lib)
files: argparse_test.py
messages: 231035
nosy: Brett.Hannigan
priority: normal
severity: normal
status: open
title: Subparser help does not respect SUPPRESS argument
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file37177/argparse_test.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22848
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22848] Subparser help does not respect SUPPRESS argument
Changes by Brett Hannigan bhanni...@dnanexus.com: Added file: http://bugs.python.org/file37178/argparse.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22848 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
Serhiy Storchaka added the comment: FYI method cache optimization was added in issue1700288. -- nosy: +arigo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Antoine Pitrou added the comment: Here is a patch which solves the algorithmic complexity issue by using a different scheme: instead of splitting, match words incrementally. -- keywords: +patch nosy: +pitrou stage: needs patch - patch review versions: -Python 2.7, Python 3.4 Added file: http://bugs.python.org/file37179/wordsplit_complexity.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
Antoine Pitrou added the comment: The low bits of the unicode hash should be as good as the middle bits. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Antoine Pitrou added the comment: Actually, it is enough to change the regexp while still using re.split(). Updated patch attached. -- Added file: http://bugs.python.org/file37180/wordsplit_complexity2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22847] Improve method cache efficiency
Antoine Pitrou added the comment: In addition, the tp_version_tag evolves incrementally, so the low bits should be better when the same name is looked up on different types. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22847 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue433030] SRE: Atomic Grouping (?...) is not supported
Serhiy Storchaka added the comment: Some unrelated to the topic changes from the patch are committed in 30a6c74ad87f. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue433030 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22835] urllib2/httplib is rendering 400s for every authenticated-SSL request, suddenly
Antoine Pitrou added the comment: In any case, it sounds like your problem is fixed, so we can close this issue. -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22434] Use named constants internally in the re module
Serhiy Storchaka added the comment: Since the op codes are singletons, you can use identity tests instead of equality checks in sre_parse.py: Please ignore my reply in previous message. Op codes are always tested for identity in sre_compile.py, so I have applied your suggestion in sre_parse.py (30a6c74ad87f). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22434 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Serhiy Storchaka added the comment: Unfortunately there are two disadvantages: 1. wordsep_re and wordsep_simple_re are public attributes and user code can depend on this. Changing their is a way to customize TextWrapper. 2. This is slowdown common case (no abnormally long words): $ ./python -m timeit -s 'import textwrap; s = abcde * 10**4' -- 'textwrap.wrap(s)' Unpatched: 178 msec per loop Patched: 285 msec per loop First reason stopped me from writing a patch. When change the way how to split words, I suggest to use undocumented re scanner. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Antoine Pitrou added the comment: Are you sure? I get the reverse results here (second patch): Unpatched: $ ./python -m timeit -s 'import textwrap; s = abcde * 10**4' -- 'textwrap.wrap(s)' 10 loops, best of 3: 27 msec per loop Patched: $ ./python -m timeit -s 'import textwrap; s = abcde * 10**4' -- 'textwrap.wrap(s)' 10 loops, best of 3: 19.2 msec per loop wordsep_re and wordsep_simple_re are public attributes and user code can depend on this. Changing their is a way to customize TextWrapper. With my second patch, that shouldn't be a problem. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20220] TarFile.list() outputs wrong time
Antoine Pitrou added the comment: Any other ideas for a reliable method to restore the correct timezone after running a test? No. The best would be for you to investigate. Perhaps contact some glibc guys. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20220 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22619] Possible implementation of negative limit for traceback functions
Dmitry Kazakov added the comment: I updated the patch. -- Added file: http://bugs.python.org/file37181/traceback.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22619 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Serhiy Storchaka added the comment:
Oh, sorry, I tested your first patch. Your second patch is faster than current
code to me. But it changes behavior.
textwrap.wrap('1a-2b', width=5)
['1a-', '2b']
With the patch the result is ['1a-2', 'b'].
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22687
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue433030] SRE: Atomic Grouping (?...) is not supported
Serhiy Storchaka added the comment: Reopened because definitely regex will be not adopted in 3.5. Here is updated to 3.5 Jeffrey's patch. -- resolution: duplicate - status: closed - open versions: +Python 3.5 -Python 3.2 Added file: http://bugs.python.org/file37182/re_atomic_groups.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue433030 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Antoine Pitrou added the comment: Yes... but in both cases the result is nonsensical, and untested. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20220] TarFile.list() outputs wrong time
David Edelsohn added the comment: It doesn't fail on the Debian system. The Debian system will be successful after the test_gdb patch is installed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20220 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22687] horrible performance of textwrap.wrap() with a long word
Serhiy Storchaka added the comment: Possessive quantifiers (issue433030) is not a panacea. They allow to speed up regular expressions, but the complexity is still quadratic. Antoine's patch makes the complexity linear. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22687 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22835] urllib2/httplib is rendering 400s for every authenticated-SSL request, suddenly
Dustin Oprea added the comment: Agreed. Thank you, @Antoine. On Tue, Nov 11, 2014 at 2:21 PM, Antoine Pitrou rep...@bugs.python.org wrote: Antoine Pitrou added the comment: In any case, it sounds like your problem is fixed, so we can close this issue. -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22835 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22849] Double DECREF in TextIOWrapper
New submission from Tim Hatch:
There's a reproducible bug in textio.c that causes a double DECREF on codecs.
The conditions to trigger are probably rare in real life, so not remotely
exploitable (sandbox escape is the worst I can think of on its own, and I'm not
aware of any on 3.x):
* You need to create a TextIOWrapper wrapping a file-like object that only
partially supports the protocol. For example, supporting readable(),
writable(), and seekable() but not tell().
The crash I experience most of the time appears to be that the memory being
reused, such that the PyObject ob_type field is no longer a valid pointer.
Affected:
Source 3.5.0a0 (latest default branch yesterday, 524a004e93dd)
Archlinux: 3.3.5 and 3.4.2
Ubuntu: 3.4.0
Unaffected:
Centos: 3.3.2
All 2.7 branch (doesn't contain the faulty commit)
Here's where it's introduced --
https://hg.python.org/cpython/rev/f3ec00d2b75e/#l5.76
/* Modules/_io/textio.c line 1064 */
Py_DECREF(codec_info);
/* does not set codec_info = NULL; */
...
if(...) goto error;
...
error:
Py_XDECREF(codec_info);
The attached script is close to minimal -- I think at most you can reduce by
one TextIOWrapper instantiation. Sample stacktrace follows (which is after the
corruption occurs, on subsequent access to v-ob_type (which is invalid).
#0 0x004c8829 in PyObject_GetAttr (v=unknown at remote
0x77eb9688,
name='_is_text_encoding') at Objects/object.c:872
#1 0x004c871d in _PyObject_GetAttrId (v=unknown at remote
0x77eb9688,
name=0x945d50 PyId__is_text_encoding.10143) at Objects/object.c:835
#2 0x005c6674 in _PyCodec_LookupTextEncoding (
encoding=0x76f40220 utf-8, alternate_command=0x6c2fcd codecs.open())
at Python/codecs.c:541
#3 0x0064286e in textiowrapper_init (self=0x77f9ecb8,
args=(F at remote 0x76f40a18,), kwds={'encoding': 'utf-8'})
at ./Modules/_io/textio.c:965
--
components: Library (Lib)
files: segv.py
messages: 231054
nosy: thatch
priority: normal
severity: normal
status: open
title: Double DECREF in TextIOWrapper
type: crash
versions: Python 3.3, Python 3.4, Python 3.5
Added file: http://bugs.python.org/file37183/segv.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22849
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21514] update json module docs in light of RFC 7159 ECMA-404
Chris Rebert added the comment: Ping! It's been about 3 months since this was given the green light... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21514 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11820] idle3 shell os.system swallows shell command output
Terry J. Reedy added the comment:
Currently, when Idle is started from a command line or console interpreter,
import os; os.system('dir') produces the listing in the console window, as
expected.
Reading the patch, it *augments* one-channel socket communication, which
properly* combines and serializes stdout and stderr messages, with two-channel
pipe communication. This is rather messy and leads to inter-mixed displays, as
reported. If sensibly possible, the process stdout/err (fileno 12) written to
by the os functions in question should forward bytes to the idle process via
the rpc channel, properly labelled as stdout or stderr.
* There is a bug where the second prompt of a shell session gets intermixed
with previous output or clipboard content, but I do not have a repeatable test
case yet.
Issue #18823 is about *replacing* the socket with pipes (whether using
subprocess or multi-processing or whatever.). (There should still be just one
channel, not two, from user process to Idle process to keep the rpc protocol in
control of what the Idle process receives.) About last August, Roger sent at
least a few of us somewhat large proof of concept patch, which I have not
reviewed yet.
The patch uses Tk.createfilehandler, which seems not to exist on Windows, so I
cannot review further.
File F:\Python\dev\34\lib\tkinter\__init__.py, line 1932, in __getattr__
return getattr(self.tk, attr)
AttributeError: 'tkapp' object has no attribute 'createfilehandler'
File F:\Python\dev\34\lib\tkinter\__init__.py, line 1932, in __getattr__
return getattr(self.tk, attr)
AttributeError: 'tkapp' object has no attribute 'createfilehandler' File
F:\Python\dev\34\lib\tkinter\__init__.py, line 1932, in __getattr__
return getattr(self.tk, attr)
AttributeError: 'tkapp' object has no attribute 'createfilehandler'
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11820
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22364] Improve some re error messages using regex for hints
Terry J. Reedy added the comment: I already said we should either stick with what we have if better (and gave examples, including sticking with 'cannot') or possibly combine the best of both if we can improve on both. 13 should use 'bytes-like' (already changed?). There is no review button. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22364 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21514] update json module docs in light of RFC 7159 ECMA-404
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21514 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22849] Double DECREF in TextIOWrapper
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +ncoghlan, serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22849 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19494] Add urllib2.HTTPBasicPriorAuthHandler for use with APIs that don't return 401 errors
Nick Coghlan added the comment: Updated the issue title to reflect the current state of the proposal - adding a new Handler class for use when you want to send the auth details unconditionally, rather than requiring that the server send a 401 response before resubmitting the request with authentication attached. The use of a separate class addresses the concerns around sending credentials unconditionally, and the restriction to 3.5+ matches the general conclusion that it's a new feature. I'll commit this shortly (just making sure my local build environment is properly configured after upgrading to the F21 beta release). -- stage: patch review - commit review title: urllib2.HTTPBasicAuthHandler (or urllib.request.HTTPBasicAuthHandler) doesn't work with GitHub API v3 and similar - Add urllib2.HTTPBasicPriorAuthHandler for use with APIs that don't return 401 errors ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19494 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22850] Backport ensurepip Windows installer changes to 2.7
New submission from Steve Dower: I've merged the changes from when ensurepip was added to Python 3 into msi.py (and also fixed up the new externals dir location), but I'm no expert on this script, so at least a second set of eyes would be appreciated. It seems to build and work okay. -- assignee: steve.dower components: Windows files: ensurepipmsi.diff keywords: patch messages: 231059 nosy: benjamin.peterson, dstufft, loewis, ncoghlan, steve.dower, tim.golden, zach.ware priority: normal severity: normal stage: patch review status: open title: Backport ensurepip Windows installer changes to 2.7 type: enhancement versions: Python 2.7 Added file: http://bugs.python.org/file37184/ensurepipmsi.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22850 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22850] Backport ensurepip Windows installer changes to 2.7
Steve Dower added the comment: Issue #22827 was the ensurepip backport. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22850 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22850] Backport ensurepip Windows installer changes to 2.7
Donald Stufft added the comment: I don't know anything about msi or this script so I can't offer any help there, but thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22850 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13444] closed stdout causes error on stderr when the interpreter unconditionally flushes on shutdown
Martin Panter added the comment: Shouldn’t this issue be marked closed and fixed? -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13444 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13444] closed stdout causes error on stderr when the interpreter unconditionally flushes on shutdown
Changes by Berker Peksag berker.pek...@gmail.com: -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13444 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19796] urllib2.HTTPError.reason is not documented as Added in 2.7
Berker Peksag added the comment: issue 13211 was about a bug in exception hierarchy of the urllib2 module(not an addition to the public API - see msg147318 for detailed explanation). I don't think we need to update documentation. -- resolution: - wont fix stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19796 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22850] Backport ensurepip Windows installer changes to 2.7
Nick Coghlan added the comment: This looks to match the relevant pieces of the Python 3 version to me. However, it occurs to me that Python 2 will still be missing other Windows usability enhancements that make pip easier to use: - bundling the py launcher - providing the installer option to enable PATH modifications that add the Scripts directory to the path I forgot about those when writing PEP 477. -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22850 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
