[issue30988] Exception parsing invalid email address headers starting or ending with dot

[Tim Bell]

Changes by Tim Bell :


--
pull_requests: +2862

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Test config dialog font bold button and sample change

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed
title: IDLE: Add config dialog font page tests -> IDLE: Test config dialog font 
bold button and sample change

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 04864b491e3ce0f022e918ad344fb53a99ce2a1b by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-30981: IDLE -- Add more configdialog font page tests.  (GH-… (#2796)
https://github.com/python/cpython/commit/04864b491e3ce0f022e918ad344fb53a99ce2a1b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Guido van Rossum]

Guido van Rossum added the comment:

The copying approach likely won't work because there will be code that uses 
isinstance(x, collections.abc.Sequence) and other code that uses isinstance(x, 
collections.Sequence) and they'll expect both to be true.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30988] Exception parsing invalid email address headers starting or ending with dot

[Tim Bell]

New submission from Tim Bell:

Email addresses with a display name starting with a dot ("."), or ending with a 
dot without whitespace before the angle bracket trigger exceptions when 
accessing the header, after creating the message object with the "default" 
policy.

For example:

>>> import email
>>> from email.policy import default
>>> email.message_from_bytes(b'To: . Doe ')['to']
'. Doe '
>>> email.message_from_bytes(b'To: . Doe ', 
>>> policy=default)['to']
Traceback (most recent call last):
  File "", line 1, in 
  File "/Users/bhat/git/cpython/Lib/email/message.py", line 391, in __getitem__
return self.get(name)
  File "/Users/bhat/git/cpython/Lib/email/message.py", line 471, in get
return self.policy.header_fetch_parse(k, v)
  File "/Users/bhat/git/cpython/Lib/email/policy.py", line 162, in 
header_fetch_parse
return self.header_factory(name, value)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 586, in 
__call__
return self[name](name, value)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 197, in 
__new__
cls.parse(value, kwds)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 344, in parse
for mb in addr.all_mailboxes]))
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 344, in 

for mb in addr.all_mailboxes]))
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 834, 
in display_name
return self[0].display_name
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 768, 
in display_name
return self[0].display_name
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 931, 
in display_name
if res[0][0].token_type == 'cfws':
AttributeError: 'str' object has no attribute 'token_type'
>>>
>>> email.message_from_bytes(b'To: John X.')['to']
'John X.'
>>> email.message_from_bytes(b'To: John X.', 
>>> policy=default)['to']
Traceback (most recent call last):
  File "", line 1, in 
  File "/Users/bhat/git/cpython/Lib/email/message.py", line 391, in __getitem__
return self.get(name)
  File "/Users/bhat/git/cpython/Lib/email/message.py", line 471, in get
return self.policy.header_fetch_parse(k, v)
  File "/Users/bhat/git/cpython/Lib/email/policy.py", line 162, in 
header_fetch_parse
return self.header_factory(name, value)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 586, in 
__call__
return self[name](name, value)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 197, in 
__new__
cls.parse(value, kwds)
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 344, in parse
for mb in addr.all_mailboxes]))
  File "/Users/bhat/git/cpython/Lib/email/headerregistry.py", line 344, in 

for mb in addr.all_mailboxes]))
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 834, 
in display_name
return self[0].display_name
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 768, 
in display_name
return self[0].display_name
  File "/Users/bhat/git/cpython/Lib/email/_header_value_parser.py", line 936, 
in display_name
if res[-1][-1].token_type == 'cfws':
AttributeError: 'str' object has no attribute 'token_type'

--
components: email
messages: 298836
nosy: barry, r.david.murray, timb07
priority: normal
severity: normal
status: open
title: Exception parsing invalid email address headers starting or ending with 
dot
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 616ecf18f3aacbd8d172e01673877b22fe946e54 by Terry Jan Reedy in 
branch 'master':
bpo-30981: IDLE: Augment one configdialog font page test (#2810)
https://github.com/python/cpython/commit/616ecf18f3aacbd8d172e01673877b22fe946e54


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2861

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[Martin Panter]

Martin Panter added the comment:

Serhiy, that is what Dong-hee already proposed in 
, but someone needs to decide if 
we want to support RFC 2640, in which I understand LF on its own is legal, and 
CR is escaped by adding a NUL.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30987] Support for ISO-TP protocol in SocketCAN

[Pier-Yves Lessard]

New submission from Pier-Yves Lessard:

PF_CAN socket using ISO-TP protocol cannot be used as getsockaddrarg only 
supports CAN_RAW and CAN_BCM for AF_CAN addresses.

--
components: Library (Lib)
messages: 298832
nosy: Pier-Yves Lessard
priority: normal
severity: normal
status: open
title: Support for ISO-TP protocol in SocketCAN
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +pitrou, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The right way of fixing the vulnerability is checking a line for '\n' and '\r' 
in ftplib.FTP.putline().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Raymond Hettinger]

Raymond Hettinger added the comment:

> Yes we will need a deprecation period for this starting with 3.7.

There are two ways to do this.  A wimpy and clean way is to just add a 
deprecation notice in the docs.  The thorough and messy way is to temporarily 
copy everything from the 3.6 collections.abc into the regular collections 
module and then insert deprecation warning code directly in each of copied 
classes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Eric Huss]

Changes by Eric Huss :


--
nosy: +ehuss

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30392] default webbrowser fails on macOS Sierra 10.12.5

[Eric Huss]

Changes by Eric Huss :


--
nosy: +ehuss

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29403] mock's autospec's behavior on method-bound builtin functions is broken

[Berker Peksag]

Berker Peksag added the comment:

Thank you for the PR, Aaron!

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29403] mock's autospec's behavior on method-bound builtin functions is broken

[Berker Peksag]

Berker Peksag added the comment:


New changeset e78dc0aaf03cd98373910150c2d35418cf938254 by Berker Peksag in 
branch '3.5':
[3.5] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin 
functions (GH-3)
https://github.com/python/cpython/commit/e78dc0aaf03cd98373910150c2d35418cf938254


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29403] mock's autospec's behavior on method-bound builtin functions is broken

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +2860

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29403] mock's autospec's behavior on method-bound builtin functions is broken

[Berker Peksag]

Berker Peksag added the comment:


New changeset 64b9a15886840df422c5203fad25c9801b4cf61e by Berker Peksag in 
branch '3.6':
[3.6] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin 
functions (GH-3)
https://github.com/python/cpython/commit/64b9a15886840df422c5203fad25c9801b4cf61e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Changes by Segev Finer :


--
pull_requests: +2859

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29403] mock's autospec's behavior on method-bound builtin functions is broken

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +2858

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30986] Add --include-py argument to Tools/msi/make_zip.py

[Segev Finer]

Changes by Segev Finer :


--
pull_requests: +2857

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30986] Add --include-py argument to Tools/msi/make_zip.py

[Segev Finer]

New submission from Segev Finer:

Add an argument --include-py to Tools/msi/make_zip.py that allows including the 
Python modules sources and not only bytecode.

I found it useful while running Twisted's test suite in PR 2318, since I got an 
error otherwise. I don't remember what that error was and wasn't able to 
reproduce it while trying to run Twisted's test suite again.

--
components: Windows
messages: 298826
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Add --include-py argument to Tools/msi/make_zip.py
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Segev Finer added the comment:

Try with:

.\python.bat Tools\msi\make_zip.py -a amd64 -o py37-amd64.zip

It requires amd64 instead of x64. Probably can add a choices 
(https://docs.python.org/3/library/argparse.html#choices) argument there to 
make it more robust.

--
nosy: +Segev Finer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[ecbftw]

ecbftw added the comment:

> What is wrong with an URL containing '\n'? I suppose that when format a 
> request with a text protocol, embedded '\n' can split the request line on two 
> lines and inject a new command. The most robust way would be to check whether 
> the formatted line contains '\n', '\r', '\0' or other illegal characters.

I agree, there's nothing wrong with an encoded line feed (%0a) in a URL. HTTP 
can easily handle '\n' in a basic auth password field, for instance. The 
problem is when these characters are included in a context where they are 
interpreted as a delimiter of some kind. In FTP's case, they are being 
interpreted as the delimiter between commands.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[ecbftw]

ecbftw added the comment:

> The best place to reject invalid characters is where the URL is parsed, no? 
> See also my bpo-30713.

No I don't really agree with that.  What other APIs can be used to submit a 
directory name, user name, password, or other field in an FTP command?  If you 
block unacceptable characters only at URL parsing, then you fail to address 
those other vectors.

The normal way to fix any injection vulneability is to encode the dangerous 
characters just before then are included in the surrounding syntax. 
Unfortunately in FTP's case, there's no widely-accepted way to encode these 
characters. So I think you should instead throw an exception right before the 
commands are put on the control channel.  Fixing the bug at the "sink" like 
this is a far more resilient way to address injections.

Any "legitimate" use case that users might have for these characters wouldn't 
have worked anyway. The code is already broken for new lines in file names. If 
you change the code such that it throws an exception when they are written to 
the control channel, that's a better mode of failure than what you have right 
now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

[Segev Finer]

Segev Finer added the comment:

I think you will need to save and restore _filters_version and _onceregistry. 
Since _filters_version is a static variable in _warnings.c you will probably 
also have to modify it somehow to make it accessible to warnings.py.

--
components: +Library (Lib)
nosy: +Segev Finer
type:  -> behavior
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Brett Cannon]

Brett Cannon added the comment:

I'm -0 on the backport since as Raymond and Eric pointed out it won't benefit 
currently working code and I personally don't like changing what exception is 
raised in a bugfix release.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30971] Improve code readability of json.tool

[Raymond Hettinger]

Raymond Hettinger added the comment:

I concur with the other commenters and am marking this as closed.

Thank you for the effort to contribute.  May I suggest working on one the many 
open bug reports.

--
nosy: +rhettinger
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Akuli]

Akuli added the comment:

Oops, I forgot to mention that I have no thoughts about backporting
this. It would be nice to see this fixed in 3.7 though :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Akuli]

Akuli added the comment:

I think all exceptions should be passed through. Things like
dict.__contains__ don't selectively turn some errors to KeyError
either; if something is not hashable it's a TypeError, not a KeyError.

>>> [] in {}
Traceback (most recent call last):
  File "", line 1, in 
TypeError: unhashable type: 'list'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30953] Fatal python error when jumping into except clause

[Xavier de Gaye]

Xavier de Gaye added the comment:

issue 17288 is related.

--
nosy: +xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Raymond Hettinger]

Raymond Hettinger added the comment:

> What are your thoughts about backporting this Raymond?

+0 On the one hand, this can be considered a bug fix.  On the other hand, I 
would suspect that no code that is currently working would benefit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30985] Set closing variable in asyncore at close

[Nir Soffer]

Changes by Nir Soffer :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30985] Set closing variable in asyncore at close

[Nir Soffer]

New submission from Nir Soffer:

This is an old issue with asyncore - asyncore has a "closing" attribute,
but it was never used. Every user has to implement the closing once
logic in dispatcher subclasses.

Here is a typical fixes in user code:
- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/asyncevent.py#L497
- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/asyncevent.py#L540

Fixing closing attribute will allow fixing the races during
asyncore.poll() and asyncore.poll2(), see
https://github.com/python/cpython/pull/2764

--
nosy: +Nir Soffer
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

[Cooper Lees]

Changes by Cooper Lees :


--
nosy: +cooperlees

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22928] HTTP header injection in urrlib2/urllib/httplib/http.client (CVE-2016-5699)

[Ned Deily]

Ned Deily added the comment:

Getting to be the last chance to backport this for 3.3.x.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +2856

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30907] speed up comparisons to self for built-in containers

[wouter bolsterlee]

Changes by wouter bolsterlee :


--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30907] speed up comparisons to self for built-in containers

[Tim Peters]

Tim Peters added the comment:

Victor, this part of the docs explains what you're seeing; scroll down to the

"""
In enforcing reflexivity of elements, the comparison of collections assumes 
that for a collection element x, x == x is always true ...
"""

part.

https://docs.python.org/3/reference/expressions.html#value-comparisons

In passing, note that dicts indexed by strings (well, indexed by anything) _do_ 
compare hashes first.  In that specific case it's a major win - but in that 
specific case we also know in advance that "EQ or NE?" is the only question 
needing an answer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[STINNER Victor]

STINNER Victor added the comment:

For Python 3.5 and 3.6, would it make sense to modify the code to pass though 
BaseException, but replace all other exceptions with KeyError? It would be a 
compromise between doing nothing and fixing the bug :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30907] speed up comparisons to self for built-in containers

[STINNER Victor]

STINNER Victor added the comment:

I never understood how container comparison works.

>>> nan = float("nan")
>>> [nan] == [nan]
True
>>> (nan,) == (nan,)
True
>>> nan == nan
False
>>> nan is nan
True

I picked the float NaN because it's one of the weirdest object in Python: it's 
not equal to itself.

I don't know what is the impact of the proposed change on comparison. Can it 
break an application? It's unclear to me.

--

It also recalls me an optimization I proposed on string: begin with comparison 
on the hash, if the two hashs are already known. At the end, we decided that it 
wasn't worth it.

--

Raymond, Tim and Serhiy don't seem to be convince, so I will follow them and 
agree to reject this optimization :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30985] Set closing variable in asyncore at close

[Jaume]

Changes by Jaume :


--
pull_requests: +2854

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30985] Set closing variable in asyncore at close

[Jaume]

Changes by Jaume :


--
nosy: walkhour
priority: normal
severity: normal
status: open
title: Set closing variable in asyncore at close

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Guido van Rossum]

Guido van Rossum added the comment:

Yes we will need a deprecation period for this starting with 3.7. It's fine
not to import names newly added to collections.abc in 3.7 (i.e. collections
would have to explicitly import everything that it got via * in 3.6).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What are your thoughts about backporting this Raymond?

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30907] speed up comparisons to self for built-in containers

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I don't have any objections to closing this. The net benefit is contradictory, 
the maintenance cost is not zero. In many performance important cases 
(dictionary lookup, searching in sequences) the identity already is checked 
before calling the comparison method.

Maybe it is worth to remove the fast patch from slice_richcompare() or speed up 
the general case, but this is a different issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30984] traceback.print_exc return value documentation

[Jelle Zijlstra]

New submission from Jelle Zijlstra:

The documentation for traceback.format_tb says "Return a list of 
“pre-processed” stack trace entries extracted from the traceback object tb. It 
is useful for alternate formatting of stack traces. The optional limit argument 
has the same meaning as for print_tb(). A “pre-processed” stack trace entry is 
a 4-tuple (filename, line number, function name, text) representing the 
information that is usually printed for a stack trace."

However, as of 3.5 it actually returns a StackSummary object, which is a 
subclass of list and contains FrameSummary objects. FrameSummary objects are 
not tuples. The documentation is accurate for 3.4 and earlier. I'm surprised 
this change was made because it seems like a compatibility break, but it's too 
late to do something about that now.

The documentation should be changed to correct the return value and add a 
"versionchanged: 3.5" note.

--
assignee: docs@python
components: Documentation
messages: 298807
nosy: Jelle Zijlstra, docs@python
priority: normal
severity: normal
status: open
title: traceback.print_exc return value documentation
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30803] Truth value of sets not properly documented

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee: rhettinger -> terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30907] speed up comparisons to self for built-in containers

[Raymond Hettinger]

Raymond Hettinger added the comment:

Any objections to closing this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18875] Idle: Auto insertion of the closing parens, brackets, and braces

[Charles Wohlganger]

Changes by Charles Wohlganger :


Added file: http://bugs.python.org/file47031/test_parenclose.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12910] urllib.quote quotes too many chars, e.g., '()'

[Louie Lu]

Changes by Louie Lu :


--
title: urrlib.quote quotes too many chars, e.g., '()' -> urllib.quote quotes 
too many chars, e.g., '()'

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27584] New addition of vSockets to the python socket module

[Cathy Avery]

Cathy Avery added the comment:

Hi,

I believe I am waiting for a final review. Is there anything else I need to be 
doing at this point.

Thanks,

Cathy

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

[Bruno Penteado]

Changes by Bruno Penteado :


--
pull_requests: +2853

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

[Bruno Penteado]

Changes by Bruno Penteado :


--
title: eval frame rename in pep 0523 broke gdp's python extension -> eval frame 
rename in pep 0523 broke gdb's python extension

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30983] eval frame rename in pep 0523 broke gdp's python extension

[Bruno Penteado]

New submission from Bruno Penteado:

pep 0523 renames PyEval_EvalFrameEx to _PyEval_EvalFrameDefault while the gdb 
python extension only looks for PyEval_EvalFrameEx to understand if it is 
dealing with a frame.

Final effect is that attaching gdb to a python3.6 process doesnt resolve python 
objects. Eg. py-list and py-bt dont work properly

--
messages: 298804
nosy: bcap
priority: normal
severity: normal
status: open
title: eval frame rename in pep 0523 broke gdp's python extension
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[STINNER Victor]

STINNER Victor added the comment:

> What is wrong with an URL containing '\n'?

For the attack, see 
http://blog.blindspotsecurity.com/2017/02/advisory-javapython-ftp-injections.html

Honestly, I don't understand well the bug :) But it doesn't seem correct to me 
to have a newline in a hostname.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What is wrong with an URL containing '\n'? I suppose that when format a request 
with a text protocol, embedded '\n' can split the request line on two lines and 
inject a new command. The most robust way would be to check whether the 
formatted line contains '\n', '\r', '\0' or other illegal characters.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

[STINNER Victor]

STINNER Victor added the comment:


New changeset bb323b261d0f41ad6998d3a16c41b29b3bb8e982 by Victor Stinner in 
branch '3.6':
bpo-30891: Fix again importlib _find_and_load() (#2665) (#2801)
https://github.com/python/cpython/commit/bb323b261d0f41ad6998d3a16c41b29b3bb8e982


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:

Apparently that buildbot doesn't have libffi.  I submitted a PR in 
https://github.com/python/cpython/pull/2802.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +2852

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[Eric V. Smith]

Eric V. Smith added the comment:

I'm -0 on a backport. The new behavior is more correct, but I don't like 
changing the exception type in a micro release.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30618] readlink for pathlib paths

[Steve Ward]

Changes by Steve Ward :


--
nosy: +planet36 -smheidrich

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30618] readlink for pathlib paths

[Steve Ward]

Changes by Steve Ward :


--
nosy: +smheidrich

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

[STINNER Victor]

STINNER Victor added the comment:


New changeset e72b1359f81d1dd42bd8a5c5cc2b3928b74f8023 by Victor Stinner in 
branch 'master':
bpo-30891: Fix again importlib _find_and_load() (#2665)
https://github.com/python/cpython/commit/e72b1359f81d1dd42bd8a5c5cc2b3928b74f8023


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[STINNER Victor]

STINNER Victor added the comment:

Unhappy buildbot:

http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/1065/steps/test/logs/stdio

...
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_multiprocessing_fork.py",
 line 2, in 
import test._test_multiprocessing
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py",
 line 3180, in 
class _Foo(Structure):
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py",
 line 3184, in _Foo
('z', c_longlong,)
NameError: name 'c_longlong' is not defined

--
nosy: +haypo
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30814] Import dotted name as alias breaks with concurrency

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +2851

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[STINNER Victor]

STINNER Victor added the comment:

Since corona10 abandonned his https://github.com/python/cpython/pull/1216 I 
created a new PR:
https://github.com/python/cpython/pull/2800

I chose to only reject newline (\n): "\r" and "\0" are not rejected.

My PR rejects any URL containing "\n", even if the newline is part of the 
"path" part of the URL. While I expect that filenames containing newlines are 
very rare, my PR is an incompatible change which breaks such use case :-(

I don't know where is the balanace between security and backward 
compatibility... I started a thread on python-dev:
https://mail.python.org/pipermail/python-dev/2017-July/148699.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[STINNER Victor]

STINNER Victor added the comment:

> Wouldn't be better to solve this issue on the level of the ftplib module or 
> FTP handler in urllib.request instead of urllib.parse?

I'm not sure that it's possible, ftplib gets the wrong hostname parameter. The 
best place to reject invalid characters is where the URL is parsed, no? See 
also my bpo-30713.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30978] str.format_map() silences exceptions in __getitem__

[STINNER Victor]

STINNER Victor added the comment:

While KeyboardInterrupt and ZeroDivisionError are easy to understand, 
IndexError converted to KeyError doesn't look like a major bug. So I'm not sure 
about fixing Python 3.5 and 3.6. Maybe it's ok because this function is rarely 
used and exceptions are not "expected": I hardly imagine a code explicitly 
catching KeyError to do something on format_map() error.

In short, my vote for backport is +0 :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:


New changeset 3913bad4957ac30e58a7ffe9279333ad176a8eea by Antoine Pitrou 
(Gareth Rees) in branch 'master':
bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes (#2741)
https://github.com/python/cpython/commit/3913bad4957ac30e58a7ffe9279333ad176a8eea


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29606] urllib FTP protocol stream injection

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +2850

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24869] shlex lineno inaccurate with certain inputs

[Gareth Rees]

Gareth Rees added the comment:

I've made a pull request. (Not because I expect it to be merged as-is, but to 
provide a starting point for discussion.)

--
nosy: +petri.lehtinen, vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24869] shlex lineno inaccurate with certain inputs

[Gareth Rees]

Changes by Gareth Rees :


--
pull_requests: +2849

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I'm not sure that *new* names in collections.abc should be re-exported to 
collections. This isn't required for backward compatibility.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

Names from collections.abc are re-exported to collections for backward 
compatibility. IIRC Serhiy also wanted to stop re-exporting them. I am not sure 
whether we need any "deprecation period" for this.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[STINNER Victor]

STINNER Victor added the comment:

> Was this ever merged?

No.

> I'm not sure whats happening.

Hum, nothing is happening. In december, Berker wrote "Thanks for the updated 
patch, Joshua. I will review and commit it this week." and then it seems like 
he found issues, since he proposed a new patch. And then, nothing new happened. 
Nobody reviewed latest Berker's patch and Berker maybe forgot to push it.

Can someone pick a recent patch and convert it to a GitHub PR? Berker, the 
author of the most recent patch, maybe?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30982] AMD64 Windows8.1 Refleaks 3.x: compilation error, cannot open python37_d.dll

[STINNER Victor]

STINNER Victor added the comment:

Ah, the log also contains:

D:\buildarea\3.x.ware-win81-release.refleak\build\Tools\buildbot\..\..\build\test_python_5232
 - The process cannot access the file because it is being used by another 
process.

What's going on? A zombi process?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30982] AMD64 Windows8.1 Refleaks 3.x: compilation error, cannot open python37_d.dll

[STINNER Victor]

New submission from STINNER Victor:

http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.x/builds/55/steps/compile/logs/stdio

D:\buildarea\3.x.ware-win81-release.refleak\build>"C:\Program Files 
(x86)\MSBuild\14.0\bin\\msbuild.exe" 
"D:\buildarea\3.x.ware-win81-release.refleak\build\PCbuild\\pythoncore.vcxproj" 
/t:KillPython /nologo /v:m /p:Configuration=Release /p:Platform=x64 
/p:KillPython=true 
  Killing any running python.exe instances...

(...)

D:\buildarea\3.x.ware-win81-release.refleak\build>"C:\Program Files 
(x86)\MSBuild\14.0\bin\\msbuild.exe" 
"D:\buildarea\3.x.ware-win81-release.refleak\build\PCbuild\\pythoncore.vcxproj" 
/t:KillPython /nologo /v:m /p:Configuration=Debug /p:Platform=x64 
/p:KillPython=true 
  Killing any running python_d.exe instances...

(...)

LINK : fatal error LNK1104: cannot open file 
'D:\buildarea\3.x.ware-win81-release.refleak\build\PCBuild\amd64\python37_d.dll'
 [D:\buildarea\3.x.ware-win81-release.refleak\build\PCbuild\pythoncore.vcxproj]

--
components: Tests
messages: 298787
nosy: haypo, zach.ware
priority: normal
severity: normal
status: open
title: AMD64 Windows8.1 Refleaks 3.x: compilation error, cannot open 
python37_d.dll
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30822] Python implementation of datetime module is not being tested correctly.

[STINNER Victor]

STINNER Victor added the comment:

Utkarsh comment on the PR:
> I'm afraid I don't really know how to read the waterfall chart at 
> http://buildbot.python.org/all/waterfall.

Yeah, sorry about this awful view :-) We now have a mailing list getting 
notifications when a buildbot fails:
https://mail.python.org/mm3/mailman3/lists/buildbot-status.python.org/

We got two new failures since yesterday on Windows buildbots, but it's related 
to IDLE and so unrelated to your change. So a quick check says that 
test_datetime doesn't time out anymore!

Previously, the test failed on a few buildbots. I checked the test output to 
look if test_datetime became the new slowest test and ... no. For example, on 
PPC64 Fedora 3.x, test_datetime is not even listed in the "10 slowest tests", 
which means that it took 36 sec or less, whereas the test took longer than 15 
minutes when tzdata was used.

IMHO you can already cook a first backport for 3.6, but I would prefer to wait 
another day just to make sure to everything is fine (to wait for new buildbot 
builds).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30959] Constructor signature is duplicated in the help of namedtuples

[SylvainDe]

SylvainDe added the comment:

Regarding the `sorted.__doc__` issue, it seems like the signature does not 
appear in the `__doc__` member but it does appear when using `help(sorted)` 
which is probably what really matters.

In any case, I find PEP 257 about this part a bit ambiguous : "The one-line 
docstring should NOT be a "signature"". Even though is should not be JUST a 
signature, should it CONTAIN the signature ?

--
nosy: +SylvainDe

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30977] reduce uuid.UUID() memory footprint

[wouter bolsterlee]

wouter bolsterlee added the comment:

i consider uuids as low level data types, not as fancy containers, similar to 
how i view datetime objects. given the native support in e.g. postgresql and 
many other systems, it's common to deal with uuids.

of course you can convert to/from strings or numbers, but that is cumbersome in 
many cases. for comparison, one would typically not convert unicode text 
from/into utf-8 encoded byte strings either, even though the latter will save 
memory in many cases.

from experience: converting can lead to nasty bugs, e.g. because you forgot 
about a conversion, and then a uuid string does not compare equal to a 
uuid.UUID instance, leaving you puzzled.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30576] http.server should support HTTP compression (gzip)

[STINNER Victor]

STINNER Victor added the comment:

I used a lot http.server in the past to transfer files between two computers. I 
like transparent compression on the file. The implementation doesn't seem so 
complex, gzip is now standard and client HTTP headers are used to decide if 
gzip is wanted or not.

But I have comments on the current implementation.

My main question is on the Content-Length. Can we skip it to not have to 
compress the whole file just to get its size, whereas we can use gzip as a 
"stream" when compress while we write compressed bytes on the socket?

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30979] the winapi fails to run shortcuts (because considers a shortcut not a valid Win32App)

[Eryk Sun]

Eryk Sun added the comment:

That depends on the shortcut. I have some shortcuts that are designed to be run 
from the command line (e.g. python.lnk), which take arguments and inherit the 
working directory of the parent process. I add .LNK to PATHEXT so I can run 
them as commands without a filename extension. os.startfile doesn't allow 
passing command-line arguments to these shortcuts.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[STINNER Victor]

STINNER Victor added the comment:

Thanks for the fix :-) (Don't forget to fix it later ;-))

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 7c5798ebfa9b822d6cedf1fc8c034f6ea90644dc by Terry Jan Reedy in 
branch 'master':
bpo-30981: temporarity skip failing IDLE test class (#2798)
https://github.com/python/cpython/commit/7c5798ebfa9b822d6cedf1fc8c034f6ea90644dc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am too tired to fix this correctly right now, so I added @skip to class with 
failing tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2848

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[nicholas kobald]

nicholas kobald added the comment:

No problem! thanks for the help.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25988] collections.abc.Indexable

[Raymond Hettinger]

Raymond Hettinger added the comment:

Guido, do you think there is some way to decouple collections.abc from spilling 
into the namespace for non-abc collections module?

At the interactive prompt, running dir() on collections gives an alphabetical 
hodgepodge of the two modules.  To my eyes, it is difficult to discern the 
concrete from the abstract.

>>> dir(collections)
['AsyncGenerator', 'AsyncIterable', 'AsyncIterator', 'Awaitable', 'ByteString', 
'Callable', 'ChainMap', 'Collection', 'Container', 'Coroutine', 'Counter', 
'Generator', 'Hashable', 'ItemsView', 'Iterable', 'Iterator', 'KeysView', 
'Mapping', 'MappingView', 'MutableMapping', 'MutableSequence', 'MutableSet', 
'OrderedDict', 'Reversible', 'Sequence', 'Set', 'Sized', 'UserDict', 
'UserList', 'UserString', 'ValuesView', '_Link', '_OrderedDictItemsView', 
'_OrderedDictKeysView', '_OrderedDictValuesView', '__all__', '__builtins__', 
'__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', 
'__path__', '__spec__', '_chain', '_class_template', '_collections_abc', 
'_count_elements', '_eq', '_field_template', '_heapq', '_iskeyword', 
'_itemgetter', '_proxy', '_recursive_repr', '_repeat', '_repr_template', 
'_starmap', '_sys', 'abc', 'defaultdict', 'deque', 'namedtuple']

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

Viktor, I am aware that there are errors in the patch I pushed that will result 
in error on the Windows machines that run gui tests.  Am working on a fix now.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30979] the winapi fails to run shortcuts (because considers a shortcut not a valid Win32App)

[Tim Golden]

Tim Golden added the comment:

For shell objects such as shortcuts you could use os.startfile which invokes 
ShellExecute under the covers

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[Nick Coghlan]

Nick Coghlan added the comment:

Thanks for the contribution & backports!

--
stage: backport needed -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[Nick Coghlan]

Nick Coghlan added the comment:


New changeset df5837b5a916aac645087ae02c44e88ff77024ef by Nick Coghlan 
(Nicholas) in branch '3.6':
[3.6] bpo-30964: Mention ensurepip in package installation docs (GH-2797)
https://github.com/python/cpython/commit/df5837b5a916aac645087ae02c44e88ff77024ef


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[nicholas kobald]

Changes by nicholas kobald :


--
pull_requests: +2847

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[Nick Coghlan]

Nick Coghlan added the comment:


New changeset 82a77d38d6dc7df740e7b01b66aeff433730e9ca by Nick Coghlan 
(Nicholas) in branch '2.7':
[2.7] bpo-30964: Mention ensurepip in package installation docs (GH-2795)
https://github.com/python/cpython/commit/82a77d38d6dc7df740e7b01b66aeff433730e9ca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

I left out gui event tests since they depends on the widgets, which will likely 
change.  I though about tests for the uncovered load_font_config and 
load_tab_config, but am not sure what to do that would not amount to copying 
their code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2846

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30981] IDLE: Add config dialog font page tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset d0969d69245d9c4eea3498ba4bde4b4cd676ad7f by Terry Jan Reedy in 
branch 'master':
bpo-30981: IDLE -- Add more configdialog font page tests.  (#2794)
https://github.com/python/cpython/commit/d0969d69245d9c4eea3498ba4bde4b4cd676ad7f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30964] Mention ensurepip in package installation docs

[nicholas kobald]

Changes by nicholas kobald :


--
pull_requests: +2845

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com