[issue17570] Improve devguide Windows instructions
Roundup Robot added the comment: New changeset 49be7fba3568 by Zachary Ware in branch 'default': Closes #17570: Improve instructions for Windows. https://hg.python.org/devguide/rev/49be7fba3568 -- nosy: +python-dev resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: Made a couple of other fixes while fixing the point I'd already raised: - Changed all instances of `...` to *...* - Changed from PCbuild\python.exe to python.bat - Wrapped a couple long lines Thanks for the patch! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Carol Willing added the comment: Zach, Steve, Ezio: The latest patch is ready to be committed. Thanks. -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: The part of the patch that I pointed out in my previous message hasn't changed, and is wrong. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: commit review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: Sorry, I don't think we're on the same page yet :). My issue was with a different hunk further down. Looking at it again, the fix I want is simple enough I'll just do it at commit; I'll get it later today. -- assignee: willingc - zach.ware stage: needs patch - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Carol Willing added the comment: Zach, Sorry for not comprehending your comment re: latest patch correctly. Since Rietveld isn't available on devguide, which makes comparison of patches difficult (at least for me), here's some proposed wording to see if I am understanding your comment correctly. If so, I will submit a new patch. Thanks. Suggested wording for: Minimal Configuration - To use Mercurial as a committer (both of your and others’ patches), you should set up some basic options in your configuration file. On all platforms, you must edit ~/.hgrc. On Windows, TortoiseHg has a graphical settings dialog for most options, meaning you don’t need to edit the file directly if you find a graphical interface more helpful. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Carol Willing added the comment: Thanks Zach :D Makes more sense now ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Carol Willing added the comment: Steve and Zach, If you are happy with the changes, I have no objection to committing and closing this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Steve Dower added the comment: Looks like the patchcheck section also has a PCBuild/python.exe that should be fixed. Are the previous commenters satisfied with the fixes? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: In the patch: -add configuration settings to ``~/.hgrc`` for the relevant repo(s) (remember +add configuration settings to ``~/.hgrc`` (``mercurial.ini`` on Windows) +for the relevant repo(s) (remember This is nonsensical, `~/.hgrc` (`%USERPROFILE%\Mercurial.ini`) is the user-level Mercurial configuration; the settings for the relevant repo(s) are in `.hg/hgrc` in the repository (same on all platforms). Btw, for me, the user-level config file on Windows has always been title-cased (`Mercurial.ini`) unless I preemptively created it myself. Really doesn't matter, though :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Peter Lovett added the comment: Tiny change on case of Windows file 'mercurial.ini' Although Windows is case-insensitive on filenames, the file itself is named in lowercase (I'm using TortoiseHg v3.4.2; I'm assuming older versions of TortoiseHg also name it in this way.) -- nosy: +PeterLovett Added file: http://bugs.python.org/file40123/issue17570.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Peter Lovett added the comment: Also a similar change to patch.rst ./python.exe should be: PCbuild\target\python.exe -- Added file: http://bugs.python.org/file40124/issue17570-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Steve Dower added the comment: Right at the end of the patch, .hg/hgrc also exists on Windows and is not the same as mercurial.ini - hgrc here is per-repo and it seems from the context that this is relevant here. Otherwise, the rest looks good to me. I'll merge it in when I get a chance, unless someone else gets there first. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Carol Willing added the comment: This patch addresses Ezio's original issue in msg185482 to improve the Windows instructions on the committing page of the devguide. I have tried to match the style of the Getting Started page when distinguishing UNIX (Mac OS X) commands from Windows commands. Please take extra care during review that the Windows commands documented are correct. Barring reviewer changes, this patch should close this issue. -- assignee: - willingc nosy: +willingc stage: needs patch - patch review Added file: http://bugs.python.org/file39168/iss17570.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +steve.dower ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +zach.ware stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: What about adding a new Platform Quirks page listing all the known differences in usage between the three major platforms? Then in places where the instructions are a bit different per platform, like: ./python.exe -m test -j3 write something like python -m test -j3 and add a link to the relevant part of the Quirks page. On the other hand, are there enough such quirks (meaning things that really are the same, just different invocations/etc.) to warrant a new page? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Zachary Ware added the comment: As previously pointed out, the current patches are not adequate. -- stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Andrew Svetlov added the comment: Sorry, but you cannot just rewrite ./python.exe to just python.exe At least in http://docs.python.org/devguide/buildbots you have to make probably three sections: 1. for linux users to use just ./python 2. for Mac ./python.exe 3. for Windows path to repo/PCBuild/python.exe or python_d.exe (IIRC) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Volodymyr Bezkostnyy added the comment: Deleted ./ before python.exe -- keywords: +patch nosy: +asvetlov, webwin Added file: http://bugs.python.org/file29703/issue17570.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Georg Brandl added the comment: At least two of the changes in the patch are incorrect because they refer to the Mac OS X python.exe. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
Volodymyr Bezkostnyy added the comment: Revert changes for Mac OS X -- Added file: http://bugs.python.org/file29710/issue17570.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17570] Improve devguide Windows instructions
New submission from Ezio Melotti: This is a follow up of #14468, and in particular of msg183031. The instructions in the committing page of the devguide are unix-centric, in particular: 1) on Windows ~/.hgrc is $HOME$/mercurial.ini; 2) the Settings dialogs of TortoiseHG can/should be used to edit mercurial.ini; 3) the devguide suggests ./python.exe Tools/scripts/patchcheck.py, but ./ doesn't work on Windows. -- components: Devguide keywords: easy messages: 185482 nosy: chris.jerdonek, ezio.melotti, pitrou, terry.reedy priority: normal severity: normal stage: needs patch status: open title: Improve devguide Windows instructions type: enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
