[issue36793] Do not define unneeded __str__ equal to __repr__

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Josh Rosenberg]

Josh Rosenberg  added the comment:

Serhiy: Did you plan to do any further work, or can this issue be closed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 96aeaec64738b730c719562125070a52ed570210 by Serhiy Storchaka in 
branch 'master':
bpo-36793: Remove unneeded __str__ definitions. (GH-13081)
https://github.com/python/cpython/commit/96aeaec64738b730c719562125070a52ed570210


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Josh Rosenberg]

Josh Rosenberg  added the comment:

I like this. Always annoying to explicitly override both __repr__ and __str__ 
on subclasses of stuff like int when they should be the same. Patch looks good 
to me; I was originally wondering why some classes were replacing:

__str__ = __repr__

with:

__str__ = object.__str__

but checking their inheritance chains, it's clear *some* overload is needed for 
consistency, and using object.__str__ means reverting to the default case where 
subclasses only need to overload __repr__, rather than forcing all subclasses 
to overload both.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Gregory P. Smith]

Change by Gregory P. Smith :


--
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Gregory P. Smith]

Change by Gregory P. Smith :


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36793] Do not define unneeded __str__ equal to __repr__

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
title: Do not set tp_str -> Do not define unneeded __str__ equal to __repr__

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com