[issue40814] Update typing module documentation based on PEP 585

[Guido van Rossum]

Change by Guido van Rossum :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Ken Jin]

Ken Jin  added the comment:

IMO, this can now be closed.

Most code examples in typing were changed to builtin generics:
https://github.com/python/cpython/commit/d9ab95ff1fe81efdf70e545d536d9f6927d1ba81
https://github.com/python/cpython/commit/7f54e563dc150cd670ca8df678437455c3a7f2cd

Docs for PEP 585's GenericAlias was added:
https://github.com/python/cpython/commit/4173320920706b49a004b8d7108e8984e3fc

Dict, List, and friends were also all marked as deprecated in 3.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Ken Jin]

Ken Jin  added the comment:

The PR should be ready for review now. Thanks for your patience.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Guido van Rossum]

Guido van Rossum  added the comment:

Yes, let’s document __args__ and __origin__.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Ken Jin]

Ken Jin  added the comment:

I've created a PR 22615 which partly addresses the documentation for 
GenericAlias in stdtypes.

I have a side question: should __args__, and __origin__ be documented somewhere 
as well? I noticed it has no documentation even though it's used to check 
generics. At the same time, I'm not fully sure that it's a standard Python 
thing rather than a CPython implementation detail.

--
keywords: +patch
message_count: 3.0 -> 4.0
nosy: +kj
nosy_count: 5.0 -> 6.0
pull_requests: +21605
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22615

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Guido van Rossum]

Guido van Rossum  added the comment:

Alternatively, we at least need a section of documentation for things like 
`list[int]` and `dict[str, float]`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Guido van Rossum]

Guido van Rossum  added the comment:

I don't think we should deprecate List etc. (PEP 585 specifically punts on the 
topic) but it's good to start mentioning list[t] etc. in the docs. Do you want 
to volunteer to write some docs?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Florian Dahlitz]

Change by Florian Dahlitz :


--
nosy: +DahlitzFlorian

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40814] Update typing module documentation based on PEP 585

[Matúš Valo]

New submission from Matúš Valo :

In documentation of typing module there is no mention of new possibilities 
based on PEP 585. Moreover, should be old constructs like  List, Dict,... 
marked as deprecated?

--
assignee: docs@python
components: Documentation
messages: 370306
nosy: Matúš Valo, docs@python, gvanrossum, levkivskyi
priority: normal
severity: normal
status: open
title: Update typing module documentation based on PEP 585
type: behavior
versions: Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com