[issue45745] ./python -m test --help output for refleaks seems wrong

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9d3271438431c37c29c359f5b73e8094b5f82912 by Victor Stinner in 
branch 'main':
bpo-45745: Remove regrtest --findleaks options (GH-29514)
https://github.com/python/cpython/commit/9d3271438431c37c29c359f5b73e8094b5f82912


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[STINNER Victor]

STINNER Victor  added the comment:

To check for reference leaks, memory leaks and file descriptor leaks: 
--huntrleaks/-R should be used.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[STINNER Victor]

STINNER Victor  added the comment:

In Python 3.6, regrtest failed if --findleaks was used and gc.garbage was not 
empty after a test completed.

I modified regrtest to always run this check: --findleaks is now ignored.

But I also modified --findleaks to make it an alias to the --fail-env-changed 
option: non-zero exit code if a test fails with "ENV CHANGED" status.

I wrote PR 29514 to clarify the situation: remove --findleaks :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +27766
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29514

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[Irit Katriel]

Irit Katriel  added the comment:

That's probably why --findleaks was deprecated (in 3.8, PR12951).  We could 
remove it now. 

+ vstinner

--
nosy: +iritkatriel, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[Skip Montanaro]

Skip Montanaro  added the comment:

Thanks, I get that. My issue is with the apparent mismatch between the English 
meaning of "find leaks" and "fail env changed." It seems to me that the help 
message(s) for one or both of those options is probably incorrect and needs to 
be changed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[Dennis Sweeney]

Dennis Sweeney  added the comment:

IIUC you're looking for --huntrleaks/-R, not the unrelated --findleaks/-l:

In that -m test -h menu:

  -l, --findleaks   deprecated alias to --fail-env-changed

  -R RUNCOUNTS, --huntrleaks RUNCOUNTS
search for reference leaks (needs debug build, very 
slow). See the section at bottom
for more details.

--
nosy: +Dennis Sweeney

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45745] ./python -m test --help output for refleaks seems wrong

[Skip Montanaro]

New submission from Skip Montanaro :

Just preparing to make a refleaks test run, so I ran:

./python -m test --help

The output related to refleaks seemed suspicious:

...
Special runs:
  -l, --findleaks   deprecated alias to --fail-env-changed
...
  --fail-env-changedif a test file alters the environment, mark the test as 
failed

It's not obvious that "--fail-env-changed" has anything to do with 
"--findleaks". Does the -l/--findleaks message need to be corrected?

--
components: Build
messages: 405916
nosy: skip.montanaro
priority: normal
severity: normal
status: open
title: ./python -m test --help output for refleaks seems wrong
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com