[issue19610] setup.py does not allow a tuple for classifiers
Berker Peksag added the comment: Here is a new patch. I didn't touched provides, requires and obsoletes fields since they are not used much in the setuptools era. Distribution.finalize_options() already converts string types to lists for platforms and keywords fields. I didn't changed that behavior. -- Added file: http://bugs.python.org/file38655/issue19610_v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Serhiy Storchaka added the comment: I think it should include other list fields if we don't want to open separate issues for every list field. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Éric Araujo added the comment: I think classifiers and keywords are the only commonly used fields. This issue could be limited to classifiers, or also include other list fields. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Serhiy Storchaka added the comment: What about other list parameters? platform, keywords, provides, requires, obsoletes? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Serhiy Storchaka added the comment: I don't know in which cases a value should be a (key, value) tuple. I think this is for field 'content' only. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Éric Araujo added the comment: I think the change is acceptable. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Serhiy Storchaka added the comment: The patch changes this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Serhiy Storchaka added the comment: Does current code work with None or empty tuple? -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Berker Peksag added the comment: Does current code work with None or empty tuple? Yes, it works with both None and (). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Berker Peksag added the comment: Updated patch. I've tweaked tests and documentation a bit. Alternatively, I can leave Doc/distutils/setupscript.rst untouched and add a whatsnew entry to Doc/whatsnew/3.5.rst. -- Added file: http://bugs.python.org/file37097/issue19610_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Changes by Berker Peksag berker.pek...@gmail.com: -- assignee: - berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Berker Peksag added the comment: A patch to detect bad type for classifiers in the check command would also be acceptable for 3.5, or to catch it earlier, a check in the Distribution class. Thanks for the idea, Éric. New patch attached. -- stage: needs patch - patch review versions: -Python 2.7, Python 3.4 Added file: http://bugs.python.org/file35266/issue19610_catch_distribution.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Éric Araujo added the comment: You seem to misunderstand me Victor: There is no bug here, classifiers should be a list and are documented as such. It is possible to make this clearer in the docs for all versions. In addition, we could make this easier for users who don’t see that part of the docs by warning them (in the check command, or from the Distribution class), but as a new feature this would go in 3.5 only. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
Éric Araujo added the comment: I’m open to a patch that would make it clear in the docs that classifiers must be a list. A patch to detect bad type for classifiers in the check command would also be acceptable for 3.5, or to catch it earlier, a check in the Distribution class. -- title: setup.py should allow a tuple for classifiers - setup.py does not allow a tuple for classifiers versions: +Python 2.7, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19610] setup.py does not allow a tuple for classifiers
STINNER Victor added the comment: A patch to detect bad type for classifiers in the check command would also be acceptable for 3.5, or to catch it earlier, a check in the Distribution class. Why only in Python 3.5? Does it make sense to pass something different than a list in older Python versions? I would prefer to see a fix the bug fixed in Python 2.7, 3.4 and 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19610 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
